fix: Add Transfer owner option by nkdengineer · Pull Request #67989 · Expensify/App

nkdengineer · 2025-08-06T07:42:28Z

Explanation of Change

Fixed Issues

$ #67497
PROPOSAL: #67497 (comment)

Tests

Precondition:

User A is admin and user B is the owner of the workspace
In native app user A must have a payment card on the Subscription page

Login as User A
Go to workspace list page
Click to the three dots
Verify that: we have Transfer owner option
Click to this option
Verify that: everything works well
Do the same with the Transfer owner option in workspace overview page

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

android-mweb.mov

iOS: Native

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2025-08-06T19:20:33Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

nkdengineer · 2025-08-06T19:20:38Z

I am a little stuck on Native builds, will add later

ahmedGaber93 · 2025-08-10T10:09:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

20250811181340653.mp4

iOS: HybridApp

iOS: mWeb Safari

20250811181414762.mp4

MacOS: Chrome / Safari

20250811180922549.mp4

MacOS: Desktop

20250815152325262.mp4

ahmedGaber93 · 2025-08-10T15:08:21Z

@nkdengineer Let's handle the goBack to back to the correct page

20250810180535727.mp4

20250810180510166.mp4

ahmedGaber93 · 2025-08-10T15:15:29Z

Also, not works on native devices

20250810181426453.mp4

nkdengineer · 2025-08-11T07:30:53Z

@nkdengineer Let's handle the goBack to back to the correct page

@ahmedGaber93 i updated

nkdengineer · 2025-08-11T07:32:20Z

Also, not works on native devices

@ahmedGaber93 as this logic, we must have fundList to enable transfer owner option

App/src/libs/shouldRenderTransferOwnerButton/index.native.ts

Lines 20 to 22 in 54e5acb

    
           const shouldRenderTransferOwnerButton: ShouldRenderTransferOwnerButton = () => { 
        
               return !isEmpty(fundList); 
        
           };

ahmedGaber93 · 2025-08-11T15:05:24Z

@ahmedGaber93 as this logic, we must have fundList to enable transfer owner option

@nkdengineer Do you know how we can test it? Passing shouldRenderTransferOwnerButton as true crash the app with me. Are you able to test it?

Also, please add screenshots for native devices.

20250811180234612.mp4

ahmedGaber93 · 2025-08-11T15:20:23Z

We also need to update the test steps for native apps to cover this #67989 (comment)

nkdengineer · 2025-08-12T15:53:40Z

@nkdengineer Do you know how we can test it?

@ahmedGaber93 I have tried many ways but still don't know how to generate fundList Onyx data. Can we contact someone?

ahmedGaber93 · 2025-08-12T16:15:04Z

@ahmedGaber93 I have tried many ways but still don't know how to generate fundList Onyx data. Can we contact someone?

@mollfpr Do you have any idea about the steps to getting fundList on Onyx data?

ahmedGaber93 · 2025-08-12T16:19:42Z

@nkdengineer why passing shouldRenderTransferOwnerButton as true here crash the app, it looks like it uses a web codes on native (based on the error on the video here "window.addEventListener is not defined"), is this a hidden issue?

App/src/libs/shouldRenderTransferOwnerButton/index.native.ts

Lines 20 to 22 in 54e5acb

    
           const shouldRenderTransferOwnerButton: ShouldRenderTransferOwnerButton = () => { 
        
               return !isEmpty(fundList); 
        
           };

nkdengineer · 2025-08-13T09:19:12Z

@nkdengineer why passing shouldRenderTransferOwnerButton as true here crash the app, it looks like it uses a web file on native (based on the error on the video here "window.addEventListener is not defined"), is this a hidden issue?

@ahmedGaber93 Yes, i think so. This was added in this PR and it seems we didn't test this case on native

ahmedGaber93 · 2025-08-13T11:24:29Z

@JmillsExpensify Are we support transfer owner via native apps? Asking because we face an issue while testing, and it turns out the feature is not work on native apps because of the CardAuthenticationModal page (below image) not supported the native apps

App/src/pages/settings/Subscription/CardAuthenticationModal/index.tsx

Lines 59 to 62 in cd80be5

    
           window.addEventListener('message', handleSCAAuthentication); 
        
           return () => { 
        
               window.removeEventListener('message', handleSCAAuthentication); 
        
           };

Note: you must have fundList to see the transfer owner option on native apps

App/src/libs/shouldRenderTransferOwnerButton/index.native.ts

Lines 20 to 22 in 54e5acb

    
           const shouldRenderTransferOwnerButton: ShouldRenderTransferOwnerButton = () => { 
        
               return !isEmpty(fundList); 
        
           };

JmillsExpensify · 2025-08-13T17:10:24Z

No we don't support transfer on native platforms.

nkdengineer · 2025-08-14T05:59:35Z

@JmillsExpensify @ahmedGaber93 should we update this funtion to return false in native app?

App/src/libs/shouldRenderTransferOwnerButton/index.native.ts

Lines 20 to 22 in 54e5acb

    
           const shouldRenderTransferOwnerButton: ShouldRenderTransferOwnerButton = () => { 
        
               return !isEmpty(fundList); 
        
           };

ahmedGaber93 · 2025-08-14T06:58:40Z

hould we update this funtion to return false in native app?

Based on #67989 (comment), we should hide the button on native apps even if user have fundList

mollfpr · 2025-09-02T04:26:43Z

Mostly the changes looks good! @nkdengineer Could you resolve the conflict? Thanks!

nkdengineer · 2025-09-02T18:28:38Z

@mollfpr i merged

mollfpr · 2025-09-03T08:25:19Z

@nkdengineer We got another conflict 😅

nkdengineer · 2025-09-04T08:00:05Z

@mollfpr resolved

blimpich · 2025-09-04T19:35:28Z

@blimpich I made it work. Previously, I only set the NVP of amountOwed without other data like purchase and NVP for amountOwedPurchaseID. Where I am supposed to have purchase data, then NVP for amountOwed, amountOwedPurchaseID, and billingSubscription. Let me know if this correct.

Just got back from OOO. Wanted to say thank you @mollfpr for testing this. Looks good and your reasoning sounds correct to me! 👍 🙂. Can you link to where you made the changes so I can double check the code?

mollfpr · 2025-09-08T00:12:00Z

@blimpich I didn't change anything, I just had the wrong data setup for the amount owed and realized that need more that amountOwed nvp 😅

mollfpr

The changes look good to me! Sorry @nkdengineer maybe pull main again to resolve the failing perf-test 😄

nkdengineer · 2025-09-08T07:06:14Z

@mollfpr it's ready now

mollfpr · 2025-09-08T12:13:25Z

All yours @blimpich!

OSBotify · 2025-09-08T16:25:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-09T03:26:43Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.2.3-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-09T18:18:29Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.2.5-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2025-09-09T21:20:27Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.2.8-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

m-natarajan · 2025-09-10T00:01:24Z

@nkdengineer @blimpich Transfer owner option not displayed in Native apps, Is this expected? For the same account the option is displayed in desktop.

pr_67989.mp4

ahmedGaber93 · 2025-09-10T00:12:10Z

@m-natarajan, do you follow this precondition step?

In native app user A must have a payment card on the Subscription page

On the web, we can ask the user to add a payment card during the transfer flow, but on native apps, we can't because add payment is not allowed on native apps. So it's required to add them on the web to see the transfer option on native.

m-natarajan · 2025-09-10T03:02:09Z

@ahmedGaber93 Yes, The payment card was added in web. The user able to see the transfer option in web but with the same account the option not displayed in native apps. Video added in the previous comment

OSBotify · 2025-09-10T22:58:21Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.8-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

ahmedGaber93 · 2025-09-11T16:40:09Z

Yes, The payment card was added in web.

Hmm! Not sure what is missing here #67989 (comment), maybe @blimpich and @mollfpr can help.

nkdengineer added 3 commits August 6, 2025 14:42

fix: Add Transfer owner option

7825a21

fix lint

21555a4

Merge branch 'main' into fix/67497

a64c434

nkdengineer marked this pull request as ready for review August 6, 2025 19:20

nkdengineer requested a review from a team as a code owner August 6, 2025 19:20

melvin-bot Bot requested review from ahmedGaber93 and removed request for a team August 6, 2025 19:20

nkdengineer added 2 commits August 11, 2025 13:36

Merge branch 'main' into fix/67497

8a75e6c

handle backTo

fef6051

remove console log

f490c32

nkdengineer added 2 commits August 12, 2025 14:45

Merge branch 'main' into fix/67497

26881d1

fix lint

ef702f7

merge main

098f5db

resolve conflict

a1b7064

nkdengineer dismissed JmillsExpensify’s stale review via a1b7064 September 2, 2025 18:05

resolve conflict

27de238

blimpich assigned nkdengineer Sep 4, 2025

mollfpr approved these changes Sep 8, 2025

View reviewed changes

nkdengineer added 2 commits September 8, 2025 12:18

Merge branch 'main' into fix/67497

ed4f01b

Merge branch 'main' into fix/67497

07369ae

blimpich approved these changes Sep 8, 2025

View reviewed changes

blimpich merged commit e2fe31f into Expensify:main Sep 8, 2025
19 checks passed

OSBotify mentioned this pull request Sep 9, 2025

Deploy Checklist: New Expensify 2025-09-09 #70157

Closed

83 tasks

jponikarchuk mentioned this pull request Sep 9, 2025

Workspace - Not here page shows up briefly when transferring owner #70169

Closed

8 tasks

melvin-bot Bot mentioned this pull request Sep 10, 2025

[Due for payment 2025-09-17] [$250] Add Transfer owner option in workspace overflow menu and Overview > More #67497

Closed

situchan mentioned this pull request May 17, 2026

Replace FullscreenLoadingIndicator with ActivityIndicator in WorkspaceOwnerChangeWrapperPage #88741

Merged

52 tasks

Conversation

nkdengineer commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 6, 2025

Uh oh!

nkdengineer commented Aug 6, 2025

Uh oh!

ahmedGaber93 commented Aug 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ahmedGaber93 commented Aug 10, 2025

Uh oh!

ahmedGaber93 commented Aug 10, 2025

Uh oh!

nkdengineer commented Aug 11, 2025

Uh oh!

nkdengineer commented Aug 11, 2025

Uh oh!

ahmedGaber93 commented Aug 11, 2025

Uh oh!

ahmedGaber93 commented Aug 11, 2025

Uh oh!

nkdengineer commented Aug 12, 2025

Uh oh!

ahmedGaber93 commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahmedGaber93 commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nkdengineer commented Aug 13, 2025

Uh oh!

ahmedGaber93 commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JmillsExpensify commented Aug 13, 2025

Uh oh!

nkdengineer commented Aug 14, 2025

Uh oh!

ahmedGaber93 commented Aug 14, 2025

Uh oh!

mollfpr commented Sep 2, 2025

Uh oh!

nkdengineer commented Sep 2, 2025

Uh oh!

mollfpr commented Sep 3, 2025

Uh oh!

nkdengineer commented Sep 4, 2025

Uh oh!

blimpich commented Sep 4, 2025

Uh oh!

mollfpr commented Sep 8, 2025

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

nkdengineer commented Sep 8, 2025

Uh oh!

mollfpr commented Sep 8, 2025

Uh oh!

Uh oh!

OSBotify commented Sep 8, 2025

Uh oh!

OSBotify commented Sep 9, 2025

Uh oh!

OSBotify commented Sep 9, 2025

Uh oh!

OSBotify commented Sep 9, 2025

Uh oh!

m-natarajan commented Sep 10, 2025

nkdengineer commented Aug 6, 2025 •

edited

Loading

ahmedGaber93 commented Aug 10, 2025 •

edited

Loading

ahmedGaber93 commented Aug 12, 2025 •

edited

Loading

ahmedGaber93 commented Aug 12, 2025 •

edited

Loading

ahmedGaber93 commented Aug 13, 2025 •

edited

Loading

m-natarajan commented Sep 10, 2025 •

edited

Loading