Replace FullscreenLoadingIndicator with ActivityIndicator in WorkspaceOwnerChangeWrapperPage by MelvinBot · Pull Request #88741 · Expensify/App

MelvinBot · 2026-04-24T18:02:06Z

Explanation of Change

As part of the loading indicator standardization (#69850), WorkspaceOwnerChangeWrapperPage uses FullscreenLoadingIndicator alongside a HeaderWithBackButton. Once shouldUseGoBackButton is enabled by default, users would see two back controls. This replaces FullscreenLoadingIndicator with an ActivityIndicator wrapped in a View that reproduces the exact same layout and background styling (StyleSheet.absoluteFill, fullScreenLoading, w100), so the loading state is visually identical but without the Go Back button capability.

Fixed Issues

$ #85393

Tests

Open the app and navigate to a workspace where you are the owner
Go to Settings > Workspaces > [Workspace] > Members
Select a member and tap Transfer ownership
Observe the loading indicator appears centered with the correct background styling while the ownership change request is in progress
Verify there is only one back button (the header back button) and no additional "Go Back" button on the loading screen
Verify no errors appear in the JS console

Verify that no errors appear in the JS console

Offline tests

Disconnect from the network
Attempt the transfer ownership flow
Verify the loading state still renders correctly without errors

QA Steps

Precondition:

User A is an admin and User B is the owner of the workspace
In native app, User A must have a payment card on the Subscription page

Login as User A
Go to the workspace list page
Click the three dots menu
Verify that the Transfer owner option is available
Click the Transfer owner option
Verify that everything works correctly (loading indicator appears centered, only one back button, no errors)
Do the same with the Transfer owner option in the workspace overview page
Verify no errors appear in the JS console

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…eOwnerChangeWrapperPage The workspace owner change flow screen has a HeaderWithBackButton, so using FullscreenLoadingIndicator would show duplicate back controls once shouldUseGoBackButton is enabled by default. Replace it with an ActivityIndicator wrapped in a View that reproduces the same layout and background styling (absoluteFillObject, fullScreenLoading, w100). Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>

codecov · 2026-04-24T18:10:19Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...kspace/members/WorkspaceOwnerChangeWrapperPage.tsx	`0.00% <0.00%> (ø)`
... and 11 files with indirect coverage changes

situchan · 2026-05-14T13:41:32Z

@MelvinBot add Tests/QA Steps and check off all items in author checklist as verified by me

MelvinBot · 2026-05-14T13:43:38Z

Updated the PR body with Tests/QA Steps and checked off all author checklist items as verified by situchan.

situchan · 2026-05-14T13:56:54Z

                <View style={[styles.containerWithSpaceBetween, error !== CONST.POLICY.OWNERSHIP_ERRORS.NO_BILLING_CARD ? styles.ph5 : styles.ph0, styles.pb0]}>
-                    {isLoading && <FullScreenLoadingIndicator reasonAttributes={reasonAttributes} />}
+                    {isLoading && (
+                        <View style={[StyleSheet.absoluteFill, styles.fullScreenLoading, styles.w100]}>


@MelvinBot remove styles.w100 if redundant. And pull main

StyleSheet.absoluteFill already provides full width via left: 0 and right: 0, making styles.w100 unnecessary. Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>

…icatorInWorkspaceOwnerChange Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>

MelvinBot · 2026-05-14T14:04:56Z

Removed redundant styles.w100 (StyleSheet.absoluteFill already provides full width via left: 0 + right: 0) and merged main.

situchan · 2026-05-14T14:05:40Z

@MelvinBot mark as ready for review

MelvinBot · 2026-05-14T14:07:20Z

Marked this PR as ready for review as requested by situchan.

situchan · 2026-05-14T14:12:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

trjExpensify · 2026-05-15T00:59:32Z

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

melvin-bot · 2026-05-15T17:24:46Z

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2026-05-15T17:33:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-15T17:59:36Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-15T18:04:00Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88741.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-732ac22-fcbc411-f3a6bf9e30773fa4aae5662c411e29fe9ae0635f/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-732ac22-fcbc411-a959d096284517de287a4abb8cc13b880a6b69af/index.html

Web 🕸️
https://88741.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-15T18:27:09Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.75-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-15T18:28:40Z

No help site changes are required for this PR.

This is a purely internal UI refactor that replaces FullscreenLoadingIndicator with ActivityIndicator in the workspace ownership transfer loading screen to avoid a duplicate back button. It does not change any user-facing workflow, feature names, button labels, or functionality.

IuliiaHerets · 2026-05-16T10:01:15Z

There is no "Transfer Ownership" button when the owner selects another member. Which preconditions should we follow?

cc @Julesssss @Expensify/pullerbear @situchan

Web-No-Transfer-Ownership-button.1.mp4

situchan · 2026-05-17T03:02:45Z

@IuliiaHerets Please try this: (referenced from #67989 which added this feature)

Precondition:

User A is admin and user B is the owner of the workspace
In native app user A must have a payment card on the Subscription page

Login as User A
Go to workspace list page
Click to the three dots
Verify that: we have Transfer owner option
Click to this option
Verify that: everything works well
Do the same with the Transfer owner option in workspace overview page

@MelvinBot update QA Steps. Not workspace owner but admin should see transfer option.

MelvinBot · 2026-05-17T03:10:50Z

Updated the QA Steps to clarify that User A should be an admin (not the workspace owner). The steps now include the preconditions and flow from situchan's comment.

IuliiaHerets · 2026-05-18T05:57:10Z

Does this PR apply to Native apps?
QA team can't see the Transfer Owner option here

cc @situchan @Julesssss

ScreenRecording_05-18-2026.12-51-49_1.MP4

situchan · 2026-05-18T06:19:57Z

In native app user A must have a payment card on the Subscription page

@IuliiaHerets this is precondition but feel free to check off if web test is fine.

Julesssss · 2026-05-18T18:11:19Z

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

I don't remember which hadn't completed, but it was a minor safe change

OSBotify · 2026-05-19T08:02:48Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.75-14 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot and others added 2 commits April 24, 2026 18:00

Use StyleSheet.absoluteFill instead of deprecated absoluteFillObject

191ccbc

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>

MelvinBot assigned situchan Apr 24, 2026

MelvinBot requested a review from a team April 24, 2026 18:02

MelvinBot mentioned this pull request Apr 24, 2026

[Due for payment 2026-05-26] [$125] Use valid loading indicator in WorkspaceOwnerChangeWrapperPage.tsx #85393

Closed

situchan reviewed May 14, 2026

View reviewed changes

MelvinBot and others added 2 commits May 14, 2026 14:04

Remove redundant styles.w100 from loading indicator wrapper

7f9c04b

StyleSheet.absoluteFill already provides full width via left: 0 and right: 0, making styles.w100 unnecessary. Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into claude-useActivityInd…

5715975

…icatorInWorkspaceOwnerChange Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>

MelvinBot marked this pull request as ready for review May 14, 2026 14:07

MelvinBot requested a review from a team as a code owner May 14, 2026 14:07

melvin-bot Bot requested review from trjExpensify and removed request for a team May 14, 2026 14:07

situchan approved these changes May 14, 2026

View reviewed changes

melvin-bot Bot requested a review from Julesssss May 14, 2026 14:13

github-actions Bot reviewed May 14, 2026

View reviewed changes

Comment thread src/pages/workspace/members/WorkspaceOwnerChangeWrapperPage.tsx

trjExpensify removed their request for review May 15, 2026 00:59

Julesssss approved these changes May 15, 2026

View reviewed changes

Julesssss merged commit 732ac22 into main May 15, 2026
58 checks passed

Julesssss deleted the claude-useActivityIndicatorInWorkspaceOwnerChange branch May 15, 2026 17:24

melvin-bot Bot added the Emergency label May 15, 2026

OSBotify mentioned this pull request May 15, 2026

Deploy Checklist: New Expensify 2026-05-15 #90795

Closed

Julesssss removed the Emergency label May 18, 2026

Conversation

MelvinBot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Apr 24, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

situchan commented May 14, 2026

Uh oh!

MelvinBot commented May 14, 2026

Uh oh!

situchan May 14, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot commented May 14, 2026

Uh oh!

situchan commented May 14, 2026

Uh oh!

MelvinBot commented May 14, 2026

Uh oh!

situchan commented May 14, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

trjExpensify commented May 15, 2026

Uh oh!

Uh oh!

melvin-bot Bot commented May 15, 2026

Uh oh!

OSBotify commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

OSBotify commented May 15, 2026

Uh oh!

MelvinBot commented May 15, 2026

Uh oh!

IuliiaHerets commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

situchan commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MelvinBot commented May 17, 2026

Uh oh!

IuliiaHerets commented May 18, 2026

Uh oh!

situchan commented May 18, 2026

Uh oh!

Julesssss commented May 18, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

MelvinBot commented Apr 24, 2026 •

edited

Loading

codecov Bot commented Apr 24, 2026 •

edited by github-actions Bot

Loading

IuliiaHerets commented May 16, 2026 •

edited

Loading

situchan commented May 17, 2026 •

edited

Loading