fix: mweb- account- the highlight word and context menu option is persisted.#69853
Conversation
…sisted. Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-09-09.at.1.10.35.PM.movAndroid: mWeb ChromeScreen.Recording.2025-09-09.at.1.04.24.PM.moviOS: HybridAppScreen.Recording.2025-09-10.at.12.27.42.AM.moviOS: mWeb SafariScreen.Recording.2025-09-10.at.12.25.14.AM.movMacOS: Chrome / SafariScreen.Recording.2025-09-10.at.12.31.33.AM.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/chuckdries in version: 9.2.9-0 🚀
|
|
🚀 Deployed to staging by https://github.com/chuckdries in version: 9.2.11-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.2.12-4 🚀
|
| (state.hovered || isHovered) && StyleUtils.parseStyleFromFunction(hoverStyle, state), | ||
| state.pressed && StyleUtils.parseStyleFromFunction(pressStyle, state), | ||
| isDisabled && [StyleUtils.parseStyleFromFunction(disabledStyle, state), styles.noSelect], | ||
| isRoleButton && styles.userSelectNone, |
There was a problem hiding this comment.
On web, react-native-web maps accessibilityRole="button" to a native element.
Safari does not allow normal drag-to-select text behavior within the native button element. this change lead to includes -webkit-user-select: none but safari doesn't allow selecting the text within the button element, it leads to this issue:
#89301

Explanation of Change
Fixed Issues
$ #66272
PROPOSAL: #66272 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_native.mp4
Android: mWeb Chrome
android_chrome.mp4
iOS: Native
ios_native.mp4
iOS: mWeb Safari
ios_safari.mp4
MacOS: Chrome / Safari
web_chrome.mp4
MacOS: Desktop
desktop_app.mp4