Skip to content

fix: mweb- account- the highlight word and context menu option is persisted. #69853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chuckdries merged 1 commit into from
Sep 9, 2025
+4 −0
Merged

fix: mweb- account- the highlight word and context menu option is persisted. #69853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/components/Pressable/GenericPressable/implementation/BaseGenericPressable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ function GenericPressable({
interactive = true,
isNested = false,
ref,
dataSet,
...rest
}: PressableProps) {
const styles = useThemeStyles();
Expand All @@ -45,6 +46,7 @@ function GenericPressable({
const isScreenReaderActive = Accessibility.useScreenReaderStatus();
const [hitSlop, onLayout] = Accessibility.useAutoHitSlop();
const [isHovered, setIsHovered] = useState(false);
const isRoleButton = [rest.accessibilityRole, rest.role].includes(CONST.ROLE.BUTTON);

const isDisabled = useMemo(() => {
let shouldBeDisabledByScreenReader = false;
Expand Down Expand Up @@ -152,6 +154,7 @@ function GenericPressable({
onKeyDown={!isDisabled ? onKeyDown : undefined}
onPressIn={!isDisabled ? onPressIn : undefined}
onPressOut={!isDisabled ? onPressOut : undefined}
dataSet={{...(isRoleButton ? {[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true} : {}), ...(dataSet ?? {})}}
style={(state) => [
cursorStyle,
StyleUtils.parseStyleFromFunction(style, state),
Expand All @@ -160,6 +163,7 @@ function GenericPressable({
(state.hovered || isHovered) && StyleUtils.parseStyleFromFunction(hoverStyle, state),
state.pressed && StyleUtils.parseStyleFromFunction(pressStyle, state),
isDisabled && [StyleUtils.parseStyleFromFunction(disabledStyle, state), styles.noSelect],
isRoleButton && styles.userSelectNone,

@hungvu193 hungvu193 May 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On web, react-native-web maps accessibilityRole="button" to a native element.

Safari does not allow normal drag-to-select text behavior within the native button element. this change lead to includes -webkit-user-select: none but safari doesn't allow selecting the text within the button element, it leads to this issue:
#89301

]}
// accessibility props
accessibilityState={{
Expand Down
Loading