Fix last message text in LHN is not shown correctly by bernhardoj · Pull Request #70777 · Expensify/App

bernhardoj · 2025-09-18T02:57:53Z

Explanation of Change

Fixed Issues

$ #60746
PROPOSAL: #60746 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open any chat
Send a message with HTML tag (for example, <div>test</div>)
Verify in LHN, the last message text shows the whole text

Additional tests:
A. Moved expense to self DM

Create an expense in WS chat
Open the expense and select the Report field
Select Remove from report
Open the expense in the self DM
Verify the LHN's last message for the expense report has no HTML tag

B. Failed to integrate accounting

Enable accounting in WS
Connect to anything that will fail
Open the admins room
Finds the message that says the integration failed (it is sometimes inside a thread)
Verify the report where the message appears. The LHN's last message has no HTML tag

C. Move IOU report to workspace

User A has a workspace and invites User B
User B sends a money request to User A
User A opens the report
User changes the workspace to workspace in step 1
Verify the report LHN's last message has no HTML

D. Move expense to another report

Create an expense in a WS chat
Create a new empty report
Open the expense report in step 1
Press the Report field and change to the empty report
Now open the expense report from step 2
Verify the report LHN's last message has no HTML

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-09-18T02:57:58Z

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2025-09-18T02:58:57Z

I'm currently having trouble setting up for iOS.

s77rt · 2025-09-18T11:48:11Z

Can you please verify the message is displayed correctly in chat as well, test with <

bernhardoj · 2025-09-18T16:44:13Z

Works fine.

QichenZhu · 2025-09-22T07:50:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
iOS Native is not included due to Fix last message text in LHN is not shown correctly #70777 (comment).
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
Unit tests would really help us be confident this change doesn't break anything, but most branches in the relevant functions aren't tested, and covering them would be a big project, so it's not practical in this PR.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-native.webm

Android: mWeb Chrome

android-web.mov

iOS: HybridApp

ios-native.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

mac-web.mov

MacOS: Desktop

mac-desktop.mov

QichenZhu · 2025-09-22T07:50:25Z

            result.alternateText = translateLocal('workspaceActions.downgradedWorkspace');
        } else if (isActionOfType(lastAction, CONST.REPORT.ACTIONS.TYPE.INTEGRATION_SYNC_FAILED)) {
-            result.alternateText = getIntegrationSyncFailedMessage(lastAction, report?.policyID);
+            result.alternateText = Parser.htmlToText(getIntegrationSyncFailedMessage(lastAction, report?.policyID));


How can we be confident that we've handled all branches that can produce HTML entities?

That's the thing that I can't guarantee 100%, but I've tried to look at all cases, translation that is being use,d and add Parser.htmlToText if it contains HTML markdown. If there is a case missed, we can quickly raise another PR to fix it. (I don't think it's a severe issue though when it happens)

pecanoro

@bernhardoj Can you improve the QA steps? We are only testing the bug, but I am worried we might be bringing regressions, so it would be great if we add steps to also test more common cases

bernhardoj · 2025-09-23T15:11:11Z

I've added more test cases.

OSBotify · 2025-09-25T09:54:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-26T23:07:03Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 9.2.19-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…msg-is-not-shown-correctly" This reverts commit c3b5896, reversing changes made to 14b9c29.

OSBotify · 2025-09-29T20:16:15Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.19-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

show last message text as it is

806a0ad

bernhardoj requested a review from a team as a code owner September 18, 2025 02:57

melvin-bot Bot assigned bernhardoj Sep 18, 2025

melvin-bot Bot requested review from QichenZhu and removed request for a team September 18, 2025 02:57

fix some last message shows in html tag when it shouldn't be

bf18b35

QichenZhu reviewed Sep 22, 2025

View reviewed changes

QichenZhu approved these changes Sep 22, 2025

View reviewed changes

melvin-bot Bot requested a review from pecanoro September 22, 2025 16:31

pecanoro requested changes Sep 23, 2025

View reviewed changes

Merge branch 'main' into fix/60746-msg-is-not-shown-correctly

e4736d9

pecanoro approved these changes Sep 25, 2025

View reviewed changes

pecanoro merged commit c3b5896 into Expensify:main Sep 25, 2025
20 checks passed

OSBotify mentioned this pull request Sep 26, 2025

Deploy Checklist: New Expensify 2025-09-26 #71399

Closed

62 tasks

This was referenced Sep 26, 2025

[Due for payment 2025-10-21] Expense - Empty message appears above "marked as paid" system message #71403

Closed

LHN - LHN preview shows HTML tag #71415

Closed

QichenZhu mentioned this pull request Sep 27, 2025

Fix expense last message shows HTML tag #71418

Merged

54 tasks

bernhardoj added a commit to bernhardoj/Expensify that referenced this pull request Sep 27, 2025

Revert "Merge pull request Expensify#70777 from bernhardoj/fix/60746-…

6043ea5

…msg-is-not-shown-correctly" This reverts commit c3b5896, reversing changes made to 14b9c29.

nlemma mentioned this pull request Sep 28, 2025

[Due for payment 2025-12-19] [$250] chat-Thread header is not showing the exact message sent #71434

Closed

8 tasks

melvin-bot Bot mentioned this pull request Sep 29, 2025

[Due for payment 2025-11-03] [Due for payment 2025-10-27] [Due for payment 2025-10-22] [Due for payment 2025-10-06] [$250] Chat - Message sent is not shown correctly in LHN #60746

Closed

18 tasks

QichenZhu mentioned this pull request Oct 16, 2025

Fix last message shows in multiline for expense with multiline description #72702

Merged

54 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix last message text in LHN is not shown correctly#70777

Fix last message text in LHN is not shown correctly#70777
pecanoro merged 3 commits into
Expensify:mainfrom
bernhardoj:fix/60746-msg-is-not-shown-correctly

bernhardoj commented Sep 18, 2025 •

edited

Loading

Uh oh!

melvin-bot Bot commented Sep 18, 2025

Uh oh!

bernhardoj commented Sep 18, 2025

Uh oh!

s77rt commented Sep 18, 2025 •

edited

Loading

Uh oh!

bernhardoj commented Sep 18, 2025

Uh oh!

QichenZhu commented Sep 22, 2025 •

edited

Loading

Uh oh!

QichenZhu Sep 22, 2025

Uh oh!

bernhardoj Sep 22, 2025

Uh oh!

pecanoro left a comment

Uh oh!

bernhardoj commented Sep 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

OSBotify commented Sep 25, 2025

Uh oh!

OSBotify commented Sep 26, 2025

Uh oh!

OSBotify commented Sep 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

bernhardoj commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 18, 2025

Uh oh!

bernhardoj commented Sep 18, 2025

Uh oh!

s77rt commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bernhardoj commented Sep 18, 2025

Uh oh!

QichenZhu commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

QichenZhu Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

bernhardoj Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

pecanoro left a comment

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Sep 25, 2025

Uh oh!

OSBotify commented Sep 26, 2025

Uh oh!

OSBotify commented Sep 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bernhardoj commented Sep 18, 2025 •

edited

Loading

s77rt commented Sep 18, 2025 •

edited

Loading

QichenZhu commented Sep 22, 2025 •

edited

Loading

bernhardoj commented Sep 23, 2025 •

edited

Loading