Skip to content

add regex for US account number#7101

Merged
puneetlath merged 4 commits into
Expensify:mainfrom
thesahindia:thesahindia/ux/add-regex
Jan 11, 2022
Merged

add regex for US account number#7101
puneetlath merged 4 commits into
Expensify:mainfrom
thesahindia:thesahindia/ux/add-regex

Conversation

@thesahindia

@thesahindia thesahindia commented Jan 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Details

Added regex for US account number

Fixed Issues

$ #7056

Tests

  • Verify that no errors appear in the JS console

QA Steps

  1. Open app
  2. Navigate to settings > Workspace > Add bank account
  3. Proceed to the manual flow
  4. Add alphabets in account number
  • Verify that no errors appear in the JS console
  • Verify that account number shows error for alphanumeric characters.
  • Verify that account number works for numbers of length 4-17

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen.Recording.2022-01-10.at.6.50.13.PM.mov

Mobile Web

Desktop

iOS

Android

@thesahindia thesahindia requested a review from a team as a code owner January 10, 2022 13:23
@MelvinBot MelvinBot requested review from puneetlath and rushatgabhane and removed request for a team January 10, 2022 13:23
@rushatgabhane

rushatgabhane commented Jan 10, 2022

Copy link
Copy Markdown
Member

Hey @thesahindia, could you please add QA steps something like -
Verify that account number shows error for alphanumeric characters.

Verify that account number works for numbers of length 4-17

@thesahindia

thesahindia commented Jan 10, 2022

Copy link
Copy Markdown
Member Author

@rushatgabhane, updated the QA steps.
Also, do you know why Jest Unit tests are failing. There's something wrong with OSBotify.
Not sure if this is related to the pr itself.

@rushatgabhane

rushatgabhane commented Jan 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Logs show there's some error with bot's GPG key.
I wouldn't worry about it as it isn't related to PR. You can run local tests and they would pass because there isn't coverage for the changes you're making.

rushatgabhane
rushatgabhane reviewed Jan 10, 2022
View reviewed changes

@rushatgabhane rushatgabhane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Suggested some changes.

Comment thread src/CONST.js Outdated
rushatgabhane
rushatgabhane previously approved these changes Jan 10, 2022
View reviewed changes

@rushatgabhane rushatgabhane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉
All yours @puneetlath

puneetlath
puneetlath reviewed Jan 10, 2022
View reviewed changes
Comment thread src/pages/ReimbursementAccount/BankAccountStep.js Outdated
puneetlath
puneetlath requested changes Jan 10, 2022
View reviewed changes

@puneetlath puneetlath left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment. Otherwise looks good.

@puneetlath

puneetlath commented Jan 11, 2022

Copy link
Copy Markdown
Contributor

Looks good @thesahindia. Can you please merge main to fix the failing tests? Context here: https://expensify.slack.com/archives/C01GTK53T8Q/p1641911028289600

@thesahindia
Merge branch 'main' into thesahindia/ux/add-regex
b8bbc92 
Merge branch 'main' into thesahindia/ux/add-regex
@puneetlath puneetlath merged commit d69e3a3 into Expensify:main Jan 11, 2022
@OSBotify

OSBotify commented Jan 11, 2022

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jan 12, 2022
Closed
54 tasks
@OSBotify

OSBotify commented Jan 12, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @puneetlath in version: 1.1.27-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Jan 12, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @puneetlath in version: 1.1.27-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Jan 12, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @puneetlath in version: 1.1.27-3 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@kbecciv kbecciv mentioned this pull request Jan 12, 2022
Closed
@botify botify mentioned this pull request Jan 14, 2022
Closed
@OSBotify

OSBotify commented Jan 14, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.29-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@puneetlath puneetlath puneetlath approved these changes

+1 more reviewer

@rushatgabhane rushatgabhane rushatgabhane left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thesahindia @rushatgabhane @puneetlath @OSBotify