Disable save button after saving self-select pronoun with a sapce

[sobitneupane]

Details

After saving self-select pronoun with space, the Save button was not disabled. The issue is fixed by making proper change in the variable that determines whether the button should be disabled or not.

Fixed Issues

$ #7147

Tests

• Go to Profile
• Select "Self-select" in Preferred pronouns field.
• Enter preferred pronoun with space at the end.
• Click Save button.

QA Steps

• Go to Profile
• Select "Self-select" in Preferred pronouns field.
• Enter preferred pronoun with space at the end.
• Click Save button.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[parasharrajat]

Looks good. Could you please update the line 164 as well.

 const [hasFirstNameError, hasLastNameError, hasPronounError] = ValidationUtils.doesFailCharacterLimit(50, [this.state.firstName.trim(), this.state.lastName.trim(), this.state.pronouns.trim()]);

[sobitneupane]

Looks good. Could you please update the line 164 as well.

 const [hasFirstNameError, hasLastNameError, hasPronounError] = ValidationUtils.doesFailCharacterLimit(50, [this.state.firstName.trim(), this.state.lastName.trim(), this.state.pronouns.trim()]);

@parasharrajat Updated.

[parasharrajat]

LGTM.

cc: @Luke9389

🎀 👀 🎀 C+ reviewed

[Luke9389]

Thanks @parasharrajat & @sobitneupane!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @Luke9389 in version: 1.1.33-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @sketchydroide in version: 1.1.34-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅