Make NetSuiteCustomFieldMappingPicker use new SelectionList by OlGierd03 · Pull Request #72740 · Expensify/App

OlGierd03 · 2025-10-16T06:24:01Z

Explanation of Change

Performed standard SelectionList migration and fixed a navigation bug that occurred when navigating back from the NetSuiteCustomFieldMappingPicker screen.

Fixed Issues

$ #65655

Tests

As a signed-in user, go to the Workspaces tab
Choose a workspace where you're an admin (get yourself an admin role or create a new workspace if necessary)
Go to More features and enable the Accounting toggle
Navigate to the Accounting tab
Add the NetSuite accounting system to the workspace
While in the Accounting > Import > Custom Segments/records / Custom lists
Click Add custom segment/record / Add custom list
Provide information and Confirm it at the end of the addition process
Select the created segment / record / list
Click the Displayed as button
Verify that the list from the NetSuiteCustomFieldMappingPicker is working correctly

Offline tests

N/A

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

web_android.mov

iOS: Native

ios.mov

iOS: mWeb Safari

web_ios.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

codecov · 2025-10-16T06:35:40Z

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...ustomFieldNew/NetSuiteCustomFieldMappingPicker.tsx	0.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
.../netsuite/import/NetSuiteImportCustomFieldEdit.tsx	`0.00% <ø> (ø)`
...ustomFieldNew/NetSuiteCustomFieldMappingPicker.tsx	`0.00% <0.00%> (ø)`

... and 1497 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…gPicker

…_IMPORT_CUSTOM_FIELD_VIEW

zfurtak

LGTM, just left a minor comment and be sure to take care of the check 👍
I really appreciate that you spotted and fix the bug ✨

zfurtak · 2025-10-16T13:49:13Z

-                initiallyFocusedOptionKey={value ?? CONST.INTEGRATION_ENTITY_MAP_TYPES.TAG}
+                initiallyFocusedItemKey={value ?? CONST.INTEGRATION_ENTITY_MAP_TYPES.TAG}
                shouldSingleExecuteRowSelect
                shouldUpdateFocusedIndex


Could you double check if this prop is needed?

You're right. We might as well get rid of this prop here. Thanks for noticing

…n NetSuiteCustomFieldMappingPicker

melvin-bot · 2025-10-16T15:08:43Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2025-10-23T17:20:11Z

-                initiallyFocusedOptionKey={value ?? CONST.INTEGRATION_ENTITY_MAP_TYPES.TAG}
+                initiallyFocusedItemKey={value ?? CONST.INTEGRATION_ENTITY_MAP_TYPES.TAG}
                shouldSingleExecuteRowSelect
-                shouldUpdateFocusedIndex


Should we remove shouldUpdateFocusedIndex here? Are there any cases where the user selects an item but the selection page is not closed?

This prop is not needed. Selecting an item in the component makes the SelectionList close in every use case

Removing shouldUpdateFocusedIndex can cause a regression like #73449. Let me test it more carefully. Or to be safe, we can bring it back.

The alike regression shouldn't happen as the page always closes after an item selection. In the component that migration caused the issue (the one you mentioned), it turned out not to be the case. If you have any doubts, I would appreciate you testing it in detail

…gPicker

dukenv0307 · 2025-10-27T15:59:42Z

            }

-            Navigation.navigate(ROUTES.POLICY_ACCOUNTING_NETSUITE_IMPORT_CUSTOM_FIELD_VIEW.getRoute(policyID, importCustomField, valueIndex));
+            Navigation.goBack(ROUTES.POLICY_ACCOUNTING_NETSUITE_IMPORT_CUSTOM_FIELD_VIEW.getRoute(policyID, importCustomField, valueIndex));


Is it related to this PR?

It is. It's a fix for a navigation issue that occurred after item selection from the migrated component. Previously, instead of closing the modal screen after the selection, the user was navigated to a new one, as visible in the video:

Screen.Recording.2025-10-28.at.12.43.02.mov

dukenv0307 · 2025-10-30T02:55:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-10-30.at.22.42.43.mov

Android: mWeb Chrome

Screen.Recording.2025-10-30.at.21.25.00.mov

iOS: HybridApp

Screen.Recording.2025-10-30.at.22.41.58.mov

iOS: mWeb Safari

Screen.Recording.2025-10-30.at.21.24.04.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-30.at.21.22.28.mov

MacOS: Desktop

Screen.Recording.2025-10-30.at.21.40.07.mov

dukenv0307 · 2025-10-30T02:56:07Z

Removing shouldUpdateFocusedIndex can cause a regression like #73449. Let me test it more carefully. Or to be safe, we can bring it back.

@OlGierd03 the focused index is not updated in the 5th step

Screen.Recording.2025-10-30.at.09.55.02.mov

OlGierd03 · 2025-10-30T08:22:02Z

@OlGierd03 the focused index is not updated in the 5th step

You're right. I've missed this use case. Bringing back the shouldUpdateFocusedIndex. Thanks for the catch! 🫶

OSBotify · 2025-10-31T11:47:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-31T21:46:20Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.2.42-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-03T22:39:33Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.42-11 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Make NetSuiteCustomFieldMappingPicker use new SelectionList

7939340

melvin-bot Bot assigned OlGierd03 Oct 16, 2025

OlGierd03 added 2 commits October 16, 2025 12:30

Merge branch 'main' into @OlGierd03/migrate-NetSuiteCustomFieldMappin…

d1e857a

…gPicker

Fix the bug with navigating back to ROUTES.POLICY_ACCOUNTING_NETSUITE…

d00c003

…_IMPORT_CUSTOM_FIELD_VIEW

zfurtak approved these changes Oct 16, 2025

View reviewed changes

zfurtak mentioned this pull request Oct 16, 2025

[Due for payment 2026-01-23] [SelectionList Improvements][Phase 2] Migrate all usages (~100) #65655

Closed

Delete unnecessary shouldUpdateFocusedIndex prop from SelectionList i…

69efb44

…n NetSuiteCustomFieldMappingPicker

OlGierd03 marked this pull request as ready for review October 16, 2025 15:08

OlGierd03 requested a review from a team as a code owner October 16, 2025 15:08

melvin-bot Bot requested review from rushatgabhane and removed request for a team October 16, 2025 15:08

grgia mentioned this pull request Oct 20, 2025

Migrate Wave 2 #72968

Closed

zfurtak mentioned this pull request Oct 23, 2025

Make WorkspaceEditCardLimitTypePage use new SelectionList #72698

Merged

54 tasks

dukenv0307 reviewed Oct 23, 2025

View reviewed changes

Merge branch 'main' into @OlGierd03/migrate-NetSuiteCustomFieldMappin…

bc6f125

…gPicker

dukenv0307 reviewed Oct 27, 2025

View reviewed changes

Bring back the shouldUpdateFocusedIndex prop

4df870f

dukenv0307 approved these changes Oct 30, 2025

View reviewed changes

melvin-bot Bot requested a review from grgia October 30, 2025 15:43

grgia approved these changes Oct 31, 2025

View reviewed changes

grgia removed the request for review from rushatgabhane October 31, 2025 11:33

grgia merged commit d7bb5ab into Expensify:main Oct 31, 2025
26 checks passed

OSBotify mentioned this pull request Oct 31, 2025

Deploy Checklist: New Expensify 2025-10-31 #73985

Closed

Conversation

OlGierd03 commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zfurtak left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zfurtak Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

OlGierd03 Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Oct 16, 2025

Uh oh!

dukenv0307 Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

OlGierd03 Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OlGierd03 Oct 25, 2025

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

OlGierd03 Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Oct 30, 2025

Uh oh!

OlGierd03 commented Oct 30, 2025

Uh oh!

Uh oh!

OSBotify commented Oct 31, 2025

Uh oh!

OSBotify commented Oct 31, 2025

Uh oh!

OSBotify commented Nov 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

OlGierd03 commented Oct 16, 2025 •

edited

Loading

codecov Bot commented Oct 16, 2025 •

edited

Loading

zfurtak left a comment •

edited

Loading

OlGierd03 Oct 24, 2025 •

edited

Loading

dukenv0307 Oct 25, 2025 •

edited

Loading

dukenv0307 commented Oct 30, 2025 •

edited

Loading