Remove Block transaction thread report creation toggle

[VickyStash]

Explanation of Change

Fixed Issues

$ #58828
PROPOSAL: N/A

Tests

• Verify that no errors appear in the JS console

IMPORTANT! For all of the tests, make sure you have the noOptimisticTransactionThreads beta turned on! Overall, the app should act the same as before, no changes should be noticeable.

One transaction expense

1. Open any chat where you haven't had any expenses before.
2. Create a manual expense
3. Left-click (long tap on mobile) on the expense to see the actions menu. Make sure you see the Hold, Delete, and Edit options.
4. Open the expense - make sure it displays as expected.
5. Delete the expense.
6. Create a new expense in the same chat.
7. Left-click (long tap on mobile) on the expense to see the actions menu.
8. Tap Hold -> Enter the reason -> Make sure the expense is held as usual.
9. Delete the expense.
10. Create a new expense.
11. Left-click (long tap on mobile) on the expense to see the actions menu.
12. Tap Edit -> Make sure the expense is opened as usual.
13. Delete the expense.
14. Create a new expense.
15. Left-click (long tap on mobile) on the expense to see the actions menu.
16. Delete the expense using the menu option, and make sure it works as expected.

Multiple transactions expense

1. Open any 1-1 chat and create several expenses. Tap on the expenses preview.
2. Select one or several expenses (using checkboxes)
3. Open actions dropdown (Hold, Export, Delete)
4. Test Hold and make sure it works as expected.
5. Create a couple more new expenses and select them. Test Export and make sure it works as expected.
6. Test Delete and make sure it works as expected.
7. Open any workspace chat and create several expenses. Tap on the expenses preview.
8. Select one or several expenses (using checkboxes)
9. Open actions dropdown (Hold, Export, Move, Merge, Delete)
10. Test Hold and make sure it works as expected.
11. Create a couple more new expenses and select them. Test Merge and make sure it works as expected.
12. Create a couple more new expenses and select them. Test Export and make sure it works as expected.
13. Test Delete and make sure it works as expected.
14. Create two similar expenses -> Review duplicates button will appear in the header
15. Try to resolve duplicates, make sure it works the same way as before.
16. Create a couple more new expenses. Open one of them, then switch between others using the arrows in the header. Make sure it works the same as before.

Self DM expenses

1. Open Self DM.
2. Create an expense and open it. Make sure it looks as it did before.
3. Go to workspace chat.
4. Submit two expenses to the workspace chat.
5. Click on the expense preview.
6. Click More > Delete. Delete the report.
7. Go to self DM. You will see the two expenses are displayed there now.
8. Go offline.
9. Click on any expense preview. Make sure it opens as expected.

Manager McTest

1. Log in with a new account.
2. Open FAB > Create expense > Manual.
3. Enter amount > Next.
4. Select Manager McTest.
5. Click Create expense.
6. In 1:1 DM, click on the expense preview.
7. See the transaction thread opened as expected.

Reports page tabs - Expenses

1. In Workspace chat create sevral expenses and an empty report
2. In 1-1 chat with user A create just one expense
3. In 1-1 chat with user B create sevral expenses
4. Go to the Reports -> Expenses tab.
5. Open any expense by tapping on the row (one transaction expense, several transactions expense)
6. Open any expense by tapping on the View button
7. Select one or several expenses that wasn't opened before (using checkboxes)
8. Open actions dropdown (Hold, Export, Delete)
9. Test Hold and make sure it works as expected.
10. Test Export and make sure it works as expected.
11. Test Delete and make sure it works as expected.
12. Select using checkbox the workspace expense that wan't opened before and Move expense to the empty report.

Reports page tabs - Reports

1. In Workspace chat create several expenses and an empty report
2. In 1-1 chat with user A create just one expense
3. In 1-1 chat with user B create sevral expenses
4. Go to the Reports -> Reports tab.
5. Open multi-expense report by tapping on the report header/preview, View button in the header
6. Open one-expense report by tapping on the report header/preview, View button in the header
7. Expand any Report.
8. Open any expense by tapping on the View button in the expense row
9. Select one or several expenses that wasn't opened before (using checkboxes)
10. Open actions dropdown (Hold, Export, Delete)
11. Test Hold and make sure it works as expected.
12. Test Export and make sure it works as expected.
13. Test Delete and make sure it works as expected.
14. Select using checkbox the workspace expense that wan't opened before and Move expense to the empty report.

Reports page tabs - Chats

1. Create several expenses in different chats.
2. Go to the Reports -> Chats tab.
3. Open any expense by tapping on the preview. Repeat it with a couple of expenses.

Offline tests

Same, as in the Tests section

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

Same, as in the Tests section

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android1.mp4

Android: mWeb Chrome

android_web1.mp4

iOS: Native

ios1.mp4

iOS: mWeb Safari

ios_web1.mp4

MacOS: Chrome / Safari

web_oneTransaction.mp4

web_multipleTransactions.mp4

web_mcTest.mp4

web_ReportsTab.mp4

web_selfDM.mp4

MacOS: Desktop

desktop-oneTransaction.mp4

desktop_mcTest.mp4

desktop_selfDM.mp4

desktop_Reports.mp4

desktop_multipleTransactions.mp4

[codecov]

Codecov Report

❌ Patch coverage is 34.78261% with 15 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/pages/TransactionMerge/ConfirmationPage.tsx	0.00%	6 Missing ⚠️
src/components/Search/index.tsx	0.00%	5 Missing ⚠️
...thSections/Search/TransactionGroupListExpanded.tsx	0.00%	1 Missing ⚠️
src/libs/SearchUIUtils.ts	87.50%	1 Missing ⚠️
...u/request/step/IOURequestStepScan/index.native.tsx	0.00%	1 Missing ⚠️
...ages/iou/request/step/IOURequestStepScan/index.tsx	0.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
src/components/TestToolMenu.tsx	96.15% <ø> (+2.60%)	⬆️
src/libs/actions/User.ts	28.27% <ø> (+0.16%)	⬆️
src/pages/Share/SubmitDetailsPage.tsx	0.00% <ø> (ø)
...rc/pages/iou/request/step/IOURequestStepAmount.tsx	5.97% <ø> (+0.17%)	⬆️
...es/iou/request/step/IOURequestStepConfirmation.tsx	48.04% <100.00%> (-0.12%)	⬇️
...thSections/Search/TransactionGroupListExpanded.tsx	55.12% <0.00%> (+0.69%)	⬆️
src/libs/SearchUIUtils.ts	69.29% <87.50%> (-0.05%)	⬇️
...u/request/step/IOURequestStepScan/index.native.tsx	1.07% <0.00%> (+<0.01%)	⬆️
...ages/iou/request/step/IOURequestStepScan/index.tsx	0.00% <0.00%> (ø)
src/components/Search/index.tsx	0.00% <0.00%> (ø)
... and 1 more

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[VickyStash]

The list of bugs I've found:

• Try to merge two expenses without threads => endless loading on the confirmation page - fix b951177
• Opening transaction thread from Reports -> Expenses when one wasn't created before and cache was cleared -> loading for a couple of seconds (should show preview right away - need to check if it's possible) - fix dcc14c3
• One transaction thread report - no thread is created if open from Reports -> Reports after cache reset - fix 22a2751

[melvin-bot]

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[hungvu193]

@VickyStash Do you want to include #72736 in this PR too?

[VickyStash]

@VickyStash Do you want to include #72736 in this PR too?

Let's not mix them, thank you!

[hungvu193]

I thought we could remove this entirely. No 🤔 ?

[VickyStash]

No, we just remove the toggle, so any user with the beta enabled has access to the functionality right away.

[hungvu193]

Then we need another PR to remove the beta right? I thought we're ready to remove beta entirely

[VickyStash]

Yeah, we will remove the beta later! The updates were never tested together at once, so we should keep it for now.
You can also check this discussion: https://expensify.slack.com/archives/C07NMDKEFMH/p1760988106084329?thread_ts=1760987307.278189&cid=C07NMDKEFMH

[trjExpensify]

Hans isn't in that channel. Copying for ref:

[trjExpensify]

@hungvu193 how are we looking on the review? When can @roryabraham start his?

[hungvu193]

@hungvu193 how are we looking on the review? When can @roryabraham start his?

I'm still testing but will complete the review before EOD

[hungvu193]

Bug: Report not found when submitting expense to someone else.

1. Submit an expense to your self DM.
2. Choose Submit it to someone.
3. Choose anyone
4. Click on that expense preview.
5. Observe the result

expens.not.found.mov

[VickyStash]

@hungvu193

Bug: Report not found when submitting expense to someone else.

It looks like the problem here is that ConvertTrackedExpenseToRequest API call fails:

It's the same on the prod and with beta off, so it's not related to this ticket functionality.
The only difference is that with the beta on we don't create an optimistic thread, so the user sees loading.
But for example on prod if you clear cache and restart (or just relogin), the expense will be back to self dm too.

[hungvu193]

hmm yeah. I can also reproduce on other branch 👍

[hungvu193]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-10-22.at.22.42.44.mov

Screen.Recording.2025-10-22.at.22.33.14.mov

Screen.Recording.2025-10-22.at.22.52.11.mov

MacOS: Desktop

Screen.Recording.2025-10-22.at.22.45.33.mov

[hungvu193]

I'm having trouble while uploading videos, I'll upload it again later today.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.2.38-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[jponikarchuk]

This PR failing because of a regression issue #73514
This issue is reproducible in: Web, mWeb, Android, iOS

[OSBotify]

🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.38-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅