[Standardize payment button] Invoice feature#71748
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
Mostly ready, will do a round of test later today. |
|
I'd say this is ready for review! I'll complete the screenshots/videos tomorrow. About paying on Search page. I'd like to wait until we have final decision on our convo here. |
|
🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@hungvu193 could you merge main / fix the Mobil conflict? Is there anything I need to know for this review? |
Nothing special, please go ahead and review. I'm working on IOU, will resolve the conflict before EOD. |
|
Screen.Recording.2025-10-22.at.6.36.33.in.the.evening.mov |
Can you reproduce it consistently? Is there any precondition? Screen.Recording.2025-10-22.at.23.04.43.mov |
|
I think I found the case here 🤔 , but I found it during testing #72847 lol 😂 . I believe it's also on main.
Screen.Recording.2025-10-22.at.23.18.09.movScreen.Recording.2025-10-22.at.23.21.33.movSince it's expense related logic, I think we should also update the last payment method while changing the workspace. Can you handle it please? @getusha |
i think we handled this case before, i'll take a look. |
|
Cool. Let's not block this PR since this is also on main. |
grgia
left a comment
There was a problem hiding this comment.
@getusha @hungvu193 what's left to fix before merging?
|
All yours @getusha |
|
One small bug: Duplicate system message when marking an invoice as paid from Reports page Screen.Recording.2025-10-24.at.4.20.34.in.the.afternoon.mov |
It's on main I believe. |
…3/App into payment-button-invoices
|
Should be ready for your final review @grgia |
|
@hungvu193 @getusha great work getting this so thoroughly tested! It tests well on my end, let's get this to QA & Customers 🚀 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.2.39-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.39-3 🚀
|
Explanation of Change
This PR implements one-click payment for Invoices.
Fixed Issues
$ #55876
PROPOSAL: N/A
Tests
Same as QA steps.
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Prerequisite:
User A: Your workspace has the invoice feature enabled.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-10-22.at.17.05.58.mov
MacOS: Desktop
Screen.Recording.2025-10-22.at.17.07.00.mov