Update create report logic while moving expenses by ShridharGoel · Pull Request #73186 · Expensify/App

ShridharGoel · 2025-10-22T08:40:21Z

Explanation of Change

Fixed Issues

$ #72485, #73166, #73168, #73167, #73170
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-10-22T08:40:27Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ShridharGoel · 2025-10-22T08:41:09Z

@c3024

ShridharGoel · 2025-10-22T08:44:23Z

codecov · 2025-10-22T08:51:53Z

Codecov Report

❌ Patch coverage is 9.09091% with 70 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/hooks/useSelectedTransactionsActions.ts	0.00%	37 Missing ⚠️
src/pages/Search/SearchPage.tsx	0.00%	15 Missing ⚠️
...rc/pages/Search/SearchTransactionsChangeReport.tsx	0.00%	14 Missing ⚠️
src/components/Search/index.tsx	0.00%	2 Missing ⚠️
...es/iou/request/step/IOURequestEditReportCommon.tsx	77.77%	2 Missing ⚠️

Files with missing lines	Coverage Δ
src/components/Search/index.tsx	`0.00% <0.00%> (ø)`
...es/iou/request/step/IOURequestEditReportCommon.tsx	`77.41% <77.77%> (-0.75%)`	⬇️
...rc/pages/Search/SearchTransactionsChangeReport.tsx	`0.00% <0.00%> (-26.93%)`	⬇️
src/pages/Search/SearchPage.tsx	`0.00% <0.00%> (ø)`
src/hooks/useSelectedTransactionsActions.ts	`2.24% <0.00%> (-0.41%)`	⬇️

... and 1278 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ShridharGoel · 2025-10-22T10:44:48Z

Move expenses option is not shown when selected reports belong to different users

ShridharGoel · 2025-10-22T10:45:31Z

Member's reports are shown correctly as options when admin is moving expenses

c3024 · 2025-10-22T12:08:09Z

+        const knownOwnerIDs = new Set<number>();
+        let hasUnknownOwner = false;
+
+        Object.values(selectedTransactionsMeta ?? {}).forEach((selectedTransactionInfo) => {


This is only to check if the transactions have multiple owners. So, instead of running through all transactions, using a for loop and returning early the moment we found two different owners should be enough, right?

Updated, thanks for the suggestion.

c3024 · 2025-10-22T12:08:19Z

+            }
+        });
+
+        selectedTransactionsList.forEach((selectedTransaction) => {


c3024 · 2025-10-22T12:10:35Z


+        const ownerAccountIDs = new Set<number>();
+        let hasUnknownOwner = false;
+        selectedTransactionsKeys.forEach((id) => {


c3024 · 2025-10-22T12:17:43Z

@ShridharGoel

Thanks for the quick work. It tests well. Suggested a couple of minor efficiency improvements.

c3024 · 2025-10-22T12:19:56Z

@ShridharGoel

Is this #73170 from our PR too?

Nvm, it is fixed too with this PR. Please add it to the fixed issues.

c3024 · 2025-10-22T12:27:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

moveAndroid.mov

Android: mWeb Chrome

moveAndroidmWeb.mov

iOS: HybridApp

moveiOS.mov

iOS: mWeb Safari

moveiOSmWeb.mov

MacOS: Chrome / Safari

allReportsChrome.mov

moveExpenseChrome.mov

Uploading createReportChrome.mov…

notHereChrome1.mov

moveExpenseChrome.mov

allReportsChrome.mov

Uploading createReportChrome.mov…

MacOS: Desktop

moveDesktop.mov

ShridharGoel · 2025-10-22T12:30:05Z

Yes, just checked that #73170 is also fixed.

c3024

LGTM!

github-actions · 2025-10-22T14:06:42Z

🚧 @inimaga has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-10-22T14:10:48Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #73186.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	https://73186.pr-testing.expensify.com
The build for Desktop was skipped

👀 View the workflow run that generated this build 👀

inimaga

Tested well. 👍

OSBotify · 2025-10-22T14:36:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

inimaga · 2025-10-22T14:46:01Z

Okay, I tried to cherry pick this change to Staging but given the number of changes included, the team is more comfortable with reverting the original offending PR and this one, re-merging the changes in both and getting this through staging tomorrow so we don't miss anything and it can be properly tested. (internal discussion link)

cc: @c3024 & @ShridharGoel

OSBotify · 2025-10-23T13:11:29Z

🚀 Deployed to staging by https://github.com/inimaga in version: 9.2.37-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

izarutskaya · 2025-10-23T13:50:51Z

Hi @ShridharGoel Do we need QA today for this?

ShridharGoel · 2025-10-23T16:14:27Z

Not yet, this was reverted and will be added back soon.

OSBotify · 2025-10-24T17:53:40Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.2.37-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Update create report logic while moving expenses

70718c4

ShridharGoel requested a review from a team as a code owner October 22, 2025 08:40

melvin-bot Bot assigned ShridharGoel Oct 22, 2025

melvin-bot Bot requested review from sobitneupane and removed request for a team October 22, 2025 08:40

Update

8c22d10

More fixes

5a69657

c3024 suggested changes Oct 22, 2025

View reviewed changes

Optimise loops

ac5b37e

c3024 mentioned this pull request Oct 22, 2025

[$250] Expenses - Not here page opens when bulk moving member's expenses from different workspace #73166

Closed

8 tasks

inimaga mentioned this pull request Oct 22, 2025

Reports - Move expenses option is shown when selecting admin and member's expenses #73167

Closed

8 tasks

This was referenced Oct 22, 2025

Expense - Report field in self DM expense opens not here page, Create report button is missing #73168

Closed

[$250] Reports - All reports are not shown when open Report field in Expense details #73170

Open

c3024 approved these changes Oct 22, 2025

View reviewed changes

melvin-bot Bot requested a review from Gonals October 22, 2025 13:26

inimaga self-requested a review October 22, 2025 14:07

inimaga approved these changes Oct 22, 2025

View reviewed changes

inimaga merged commit b7ee9b8 into Expensify:main Oct 22, 2025
26 of 27 checks passed

inimaga mentioned this pull request Oct 22, 2025

Revert "Update create report logic while moving expenses" & "Allow admin and report managers to move expenses" #73227

Merged

52 tasks

OSBotify mentioned this pull request Oct 23, 2025

Deploy Checklist: New Expensify 2025-10-23 #73307

Closed

88 tasks

melvin-bot Bot mentioned this pull request Oct 24, 2025

[Due for payment 2025-11-04] [$250] [CFI] Admin Unable to Move Employee Expenses on NewDot Experience #72485

Closed

16 tasks

Conversation

ShridharGoel commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 22, 2025

Uh oh!

ShridharGoel commented Oct 22, 2025

Uh oh!

ShridharGoel commented Oct 22, 2025

Uh oh!

codecov Bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ShridharGoel commented Oct 22, 2025

Uh oh!

ShridharGoel commented Oct 22, 2025

Uh oh!

c3024 Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

c3024 Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

c3024 Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

c3024 commented Oct 22, 2025

Uh oh!

c3024 commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

c3024 commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ShridharGoel commented Oct 22, 2025

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 22, 2025

Uh oh!

github-actions Bot commented Oct 22, 2025

Uh oh!

inimaga left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 22, 2025

Uh oh!

inimaga commented Oct 22, 2025

Uh oh!

OSBotify commented Oct 23, 2025

Uh oh!

izarutskaya commented Oct 23, 2025

Uh oh!

ShridharGoel commented Oct 23, 2025

Uh oh!

OSBotify commented Oct 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ShridharGoel commented Oct 22, 2025 •

edited

Loading

codecov Bot commented Oct 22, 2025 •

edited

Loading

c3024 commented Oct 22, 2025 •

edited

Loading

c3024 commented Oct 22, 2025 •

edited

Loading