Skip to content

add new error message#7319

Merged
pecanoro merged 1 commit into
Expensify:mainfrom
Tushu17:fix-error-message
Jan 24, 2022
Merged

add new error message#7319
pecanoro merged 1 commit into
Expensify:mainfrom
Tushu17:fix-error-message

Conversation

@Tushu17

@Tushu17 Tushu17 commented Jan 19, 2022

Copy link
Copy Markdown
Contributor

Details

Added new error message

Fixed Issues

$ #7269

Tests

  • Verify that no errors appear in the JS console

QA Steps

  1. Navigate to Workspace > Add bank account or Settings > Payment > Add Payment > Add bank account
  2. Select Plaid > Wells Fargo & login
  3. Select Savings account and enter incorrect account password
  4. Verify that the error message says "Incorrect password. Please try again." or "Contraseña incorrecta. Por favor inténtalo de nuevo"
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@Tushu17 Tushu17 requested a review from a team as a code owner January 19, 2022 12:08
@MelvinBot MelvinBot requested review from parasharrajat and pecanoro and removed request for a team January 19, 2022 12:08
@github-actions

github-actions Bot commented Jan 19, 2022

Copy link
Copy Markdown
Contributor

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Tushu17

Tushu17 commented Jan 19, 2022

Copy link
Copy Markdown
Contributor Author

I haven't attached any screenshots as it can't be tested on development. It shows CORS error in local host.

@Tushu17

Tushu17 commented Jan 19, 2022

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Tushu17

Tushu17 commented Jan 19, 2022

Copy link
Copy Markdown
Contributor Author

recheck

Comment thread src/languages/es.js Outdated

@parasharrajat parasharrajat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is a small change and I can confirm it will work so it's fine to skip the screenshots.
cc: @pecanoro I have a small doubt for you.

🎀 👀 🎀 C+ reviewed

@parasharrajat parasharrajat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tushu17 Please sign your commits.

@parasharrajat parasharrajat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would need to sign all of your commits before this can be merged.

@Tushu17

Tushu17 commented Jan 21, 2022

Copy link
Copy Markdown
Contributor Author

@parasharrajat, is it good now?

@parasharrajat

Copy link
Copy Markdown
Member

Ok, it works.

parasharrajat
parasharrajat approved these changes Jan 21, 2022
@pecanoro pecanoro merged commit 8a31526 into Expensify:main Jan 24, 2022
@OSBotify

Copy link
Copy Markdown
Contributor

@Tushu17, Great job getting your first Expensify/App pull request over the finish line! 🎉

I know there's a lot of information in our contributing guidelines, so here are some points to take note of 📝:

  1. Now that your first PR has been merged, you can be hired for another issue. Once you've completed a few issues, you may be eligible to work on more than one job at a time.
  2. Once your PR is deployed to our staging servers, it will undergo quality assurance (QA) testing. If we find that it doesn't work as expected or causes a regression, you'll be responsible for fixing it. Typically, we would revert this PR and give you another chance to create a similar PR without causing a regression.
  3. Once your PR is deployed to production, we start a 7-day timer ⏰. After it has been on production for 7 days without causing any regressions, then we pay out the Upwork job. 💰

So it might take a while before you're paid for your work, but we typically post multiple new jobs every day, so there's plenty of opportunity. I hope you've had a positive experience contributing to this repo! 😊

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@mvtglobally

Copy link
Copy Markdown

@Tushu17 @pecanoro Should it be QAed on all platforms? Checkboxes are missing

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @pecanoro in version: 1.1.32-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Tushu17

Tushu17 commented Jan 26, 2022

Copy link
Copy Markdown
Contributor Author

@mvtglobally Yeah it's for all platforms.

@mvtglobally

Copy link
Copy Markdown

After few PRs and CPs were deployed this round, we are no longer able to se password field on Desktop. Other platforms were pass
Screen Shot 2022-01-28 at 1 24 01 PM

@mvtglobally

Copy link
Copy Markdown

Ignore previous message. Desktop is pass too

@OSBotify

OSBotify commented Feb 1, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.33-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants