add new error message#7319
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I haven't attached any screenshots as it can't be tested on development. It shows CORS error in local host. |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
parasharrajat
left a comment
There was a problem hiding this comment.
LGTM. It is a small change and I can confirm it will work so it's fine to skip the screenshots.
cc: @pecanoro I have a small doubt for you.
🎀 👀 🎀 C+ reviewed
parasharrajat
left a comment
There was a problem hiding this comment.
@Tushu17 Please sign your commits.
parasharrajat
left a comment
There was a problem hiding this comment.
You would need to sign all of your commits before this can be merged.
98f1c53 to
3bfe4ab
Compare
|
@parasharrajat, is it good now? |
|
Ok, it works. |
|
@Tushu17, Great job getting your first Expensify/App pull request over the finish line! 🎉 I know there's a lot of information in our contributing guidelines, so here are some points to take note of 📝:
So it might take a while before you're paid for your work, but we typically post multiple new jobs every day, so there's plenty of opportunity. I hope you've had a positive experience contributing to this repo! 😊 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
@mvtglobally Yeah it's for all platforms. |
|
Ignore previous message. Desktop is pass too |
|
🚀 Deployed to production by @roryabraham in version: 1.1.33-3 🚀
|

Details
Added new error message
Fixed Issues
$ #7269
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android