Fix/73175 - Empty space instead of keyboard if backgrounding app while creating expense#74904
Conversation
…e editing expense fields during creation, an empty space remains displayed instead of keyboard
|
@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
Code Review CompleteI've performed a comprehensive code review of this PR and found no rule violations. Review SummaryThe changes properly address the keyboard persistence issue by:
The implementation is clean and follows the codebase patterns. No performance or correctness issues detected. |
|
I’ve tested issue #72507, and it seems this PR doesn’t resolve it. 72507_test.mp4 |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
trjExpensify
left a comment
There was a problem hiding this comment.
No qualms from product on this bug fix 👍
Julesssss
left a comment
There was a problem hiding this comment.
LGTM, awaiting final C+ review
|
This is a very core component change. Give me more time to test it further. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-11-24.at.19.05.41-compressed.movAndroid: mWeb ChromeScreen.Recording.2025-11-24.at.19.09.02-compressed.moviOS: HybridAppScreen.Recording.2025-11-24.at.19.17.33.moviOS: mWeb SafariScreen.Recording.2025-11-24.at.19.18.22.movMacOS: Chrome / SafariMacOS: Desktop |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.2.63-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.63-8 🚀
|
Explanation of Change
While in the request money flow, at the confirm details step, if the user backgrounds the app while an input field like "Merchant" or "Description" is focused and the keyboard is visible, then returns to the foreground, a blank space appears at the bottom of the screen. This space replaces the missing keyboard. This PR fixes the issue.
Fixed Issues
$ #73175
PROPOSAL: #73175 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.native.mp4
Android: mWeb Chrome
The issue doesn't occur
iOS: Native
ios.native.mp4
iOS: mWeb Safari
The issue doesn't occur
MacOS: Chrome / Safari
The issue doesn't occur
MacOS: Desktop
The issue doesn't occur