Fix/73175b - Empty space instead of keyboard if backgrounding app while creating expense by dmkt9 · Pull Request #76281 · Expensify/App

dmkt9 · 2025-11-28T14:40:19Z

Explanation of Change

Follow-up #74904

While in the request money flow, at the confirm details step, if the user backgrounds the app while an input field like "Merchant" or "Description" is focused and the keyboard is visible, then returns to the foreground, a blank space appears at the bottom of the screen. This space replaces the missing keyboard. This PR fixes the issue.

Fixed Issues

$ #73175
PROPOSAL: #73175 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open the Expensify app.
Open any chat.
Start manual expense creation flow.
Add any amount and tap on "Next"
Open any field to edit. (For example: Merchant)
Open keyboard if it is not opened yet.
With keyboard still opened, background and reopen app.
Note that after backgrounding and reopening the app with the keyboard open during the expense creation flow, the keyboard should remain visible and no empty space should appear at the bottom of the screen.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.native.mp4

Android: mWeb Chrome

The issue doesn't occur

iOS: Native

ios.native.mp4

iOS: mWeb Safari

The issue doesn't occur

MacOS: Chrome / Safari

The issue doesn't occur

MacOS: Desktop

The issue doesn't occur

…ting expense

melvin-bot · 2025-11-28T14:40:26Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-11-28T14:40:26Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

codecov · 2025-11-28T14:48:55Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/AmountTextInput.tsx	`100.00% <ø> (ø)`
src/components/TextInput/index.native.tsx	`90.90% <75.00%> (+0.90%)`	⬆️
... and 13 files with indirect coverage changes

trjExpensify

Can you please explain what this PR is doing as a follow-up to the other one linked that has exactly the same title and explanation of changes: #74904

dmkt9 · 2025-11-28T14:54:15Z

Can you please explain what this PR is doing as a follow-up to the other one linked that has exactly the same title and explanation of changes: #74904

The #74904 was reverted, so I created this PR to continue fixing the original issue.

github-actions · 2025-11-28T17:14:32Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-11-28T17:50:42Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #76281.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/76281/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/76281/index.html

Web 🕸️
https://76281.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dominictb · 2025-12-04T16:09:17Z

    ref?: ForwardedRef<BaseTextInputRef>;
+
+    navigation?: Omit<NavigationProp<ReactNavigation.RootParamList>, 'getState'> & {
+        getState(): NavigationState | undefined;


Why do we need to redefine getState here? Also please add prop JSDoc comment.

Actually, I didn’t look into why it needs to redefine getState; I just took it from the type of useNavigation 😄:

export function useNavigation< T = Omit<NavigationProp<ReactNavigation.RootParamList>, 'getState'> & { getState(): NavigationState | undefined; }, >(): T {

dominictb · 2025-12-04T16:20:52Z

        }

+        if (!navigation) {
+            Log.warn('disableKeyboard is enabled, but "navigation" isn\'t passed to the TextInput component!');


Can you check similar places with enabled disableKeyboard where the bug can be reproduced and pass navigation accordingly?

Yes. I reviewed everything when creating this PR, and I added this log to ensure that nothing gets missed in the future.

dominictb · 2025-12-04T16:21:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-12-08.at.18.35.52-compressed.mov

Android: mWeb Chrome

Screen.Recording.2025-12-08.at.18.38.20-compressed.mov

iOS: HybridApp

Screen.Recording.2025-12-08.at.18.26.09.mov

iOS: mWeb Safari

Screen.Recording.2025-12-08.at.18.30.20.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-04.at.23.18.52.mov

…ting expense

dominictb

🎀

Responded to

OSBotify · 2025-12-09T15:29:33Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.2.74-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2025-12-10T21:38:42Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2025-12-10T21:54:56Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2025-12-10T22:59:21Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix - Empty space instead of keyboard if backgrounding app while crea…

765cd32

…ting expense

dmkt9 requested review from a team as code owners November 28, 2025 14:40

melvin-bot Bot assigned dmkt9 Nov 28, 2025

melvin-bot Bot requested review from dominictb and removed request for a team November 28, 2025 14:40

melvin-bot Bot requested review from trjExpensify and removed request for a team November 28, 2025 14:40

trjExpensify previously requested changes Nov 28, 2025

View reviewed changes

dmkt9 mentioned this pull request Nov 28, 2025

[payment due 12-17][$250] Android - Expense - Empty space instead of keyboard if backgrounding app while creating expense #73175

Closed

8 tasks

dominictb suggested changes Dec 4, 2025

View reviewed changes

dmkt9 added 3 commits December 5, 2025 15:07

Merge branch 'main' into fix/73175b

a1b7a63

Fix - Empty space instead of keyboard if backgrounding app while crea…

897db36

…ting expense

Fix - Empty space instead of keyboard if backgrounding app while crea…

eaec67c

…ting expense

dominictb approved these changes Dec 8, 2025

View reviewed changes

melvin-bot Bot requested a review from Julesssss December 8, 2025 11:40

Julesssss approved these changes Dec 8, 2025

View reviewed changes

Julesssss merged commit 4d481ad into Expensify:main Dec 8, 2025
32 checks passed

OSBotify mentioned this pull request Dec 9, 2025

Deploy Checklist: New Expensify 2025-12-09 #77123

Closed

Conversation

dmkt9 commented Nov 28, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 28, 2025

Uh oh!

melvin-bot Bot commented Nov 28, 2025

Uh oh!

codecov Bot commented Nov 28, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

dmkt9 commented Nov 28, 2025

Uh oh!

github-actions Bot commented Nov 28, 2025

Uh oh!

github-actions Bot commented Nov 28, 2025

Uh oh!

dominictb Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

dmkt9 Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

dominictb Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

dmkt9 Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

dominictb commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dominictb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Dec 9, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Nov 28, 2025 •

edited by github-actions Bot

Loading

dominictb commented Dec 4, 2025 •

edited

Loading