Persist all Report_AddComment actions (as well as attachments)#7520
Merged
thienlnam merged 1 commit intoFeb 2, 2022
Merged
Conversation
thienlnam
approved these changes
Feb 2, 2022
thienlnam
left a comment
Contributor
There was a problem hiding this comment.
Awesome work to get us to this point! Excited to see this live
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
22 tasks
Contributor
|
🚀 Deployed to staging by @thienlnam in version: 1.1.36-0 🚀
|
Contributor
|
🚀 Deployed to production by @roryabraham in version: 1.1.36-0 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Enable attachment persistence
If the app is killed while offline the attachment would be uploaded on the next launch
Fixed Issues
$ #3867
Tests
For all platforms
QA Steps
Same as Tests above
Tested On
Screenshots
Web
New.Expensify.-.Google.Chrome.2022-02-02.17-36-32.mp4
Mobile Web
Screen.Recording.2022-02-02.at.17.49.53.mov
Desktop
File.Persistence.Desktop.mp4
iOS
Screen.Recording.2022-02-02.at.17.47.46.mov
Android
Android.Emulator.-.Pixel_2_API_29_5554.2022-02-02.17-58-08.mp4