Skip to content

Persist all Report_AddComment actions (as well as attachments)#7520

Merged
thienlnam merged 1 commit into
Expensify:mainfrom
kidroca:kidroca/feature/persist-attachment-uploads
Feb 2, 2022
Merged

Persist all Report_AddComment actions (as well as attachments)#7520
thienlnam merged 1 commit into
Expensify:mainfrom
kidroca:kidroca/feature/persist-attachment-uploads

Conversation

@kidroca

@kidroca kidroca commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

Details

Enable attachment persistence
If the app is killed while offline the attachment would be uploaded on the next launch

Fixed Issues

$ #3867

Tests

For all platforms

  1. Go offline
  2. Open a conversation
  3. Select and send an attachment
  4. Terminated the app
  5. Resume connectivity
  6. Open the app again
  7. Go to the conversation and see the file appearing after it's uploaded
    • depending on how big the file is it may take some time to upload it
    • the file can either be already uploaded by the time you open the chat
    • but if it's still uploading - it'll not appear in chat history, any optimistic actions (pending comments) are cleared when you open a chat.

QA Steps

Same as Tests above

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

New.Expensify.-.Google.Chrome.2022-02-02.17-36-32.mp4

Mobile Web

Screen.Recording.2022-02-02.at.17.49.53.mov

Desktop

File.Persistence.Desktop.mp4

iOS

Screen.Recording.2022-02-02.at.17.47.46.mov

Android

Android.Emulator.-.Pixel_2_API_29_5554.2022-02-02.17-58-08.mp4

@kidroca kidroca requested a review from a team as a code owner February 2, 2022 16:40
@MelvinBot MelvinBot requested review from thienlnam and removed request for a team February 2, 2022 16:40

@thienlnam thienlnam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work to get us to this point! Excited to see this live

@thienlnam thienlnam merged commit dc9b289 into Expensify:main Feb 2, 2022
@OSBotify

OSBotify commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @thienlnam in version: 1.1.36-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Feb 7, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.36-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants