Skip to content

Persist all Report_AddComment actions (as well as attachments) #7520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thienlnam merged 1 commit into from
Feb 2, 2022
Merged

Persist all Report_AddComment actions (as well as attachments) #7520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/libs/actions/Report.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1171,11 +1171,7 @@ function addAction(reportID, text, file) {
file,
reportComment: commentText,
clientID: optimisticReportActionID,

// The persist flag enables this request to be retried if we are offline and the app is completely killed. We do
// not retry attachments as we have no solution for storing them persistently and attachments can't be "lost" in
// the same way report actions can.
persist: !isAttachment,
persist: true,
})
.then((response) => {
if (response.jsonCode === 408) {
Expand Down