[No QA] Update Verify-a-Domain.md#77168
Conversation
Updating the documentation to reflect the last release in Release 4 of the Domains & SAML in newdot project.
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@ZhenjaHorbach @RachCHopkins One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR consolidates domain verification documentation by replacing the brief "Verify-a-Domain.md" with a comprehensive "Claim-and-Verify-a-Domain.md" guide. The new documentation provides significantly improved coverage of the domain claiming and verification workflow, reflecting Release 4 of the Domains & SAML project. The article is well-structured with clear sections, helpful context, and logical progression through the claiming and verification process. Scores Summary
Key FindingsStrengths:
Areas for Improvement:
RecommendationsPriority Actions:
Style Improvements:
Content Enhancements:
Files Reviewed
Overall Recommendation: Approve with revisions. The content quality is strong and the consolidation improves user experience, but formatting and structural consistency should be addressed before merge to align with HelpDot standards. |
|
A preview of your ExpensifyHelp changes have been deployed to https://69ffc6b5.helpdot.pages.dev ⚡️ Updated articles: |
|
Thank you @RachCHopkins for the very thorough review! Ive made the changes and a new commit |
|
@clarajones-expensify I have no idea - are they modals that link to a help doc? @ZhenjaHorbach @mountiny do you know how to deciper those PRs? |
|
Ah seems like you need to update the redirects:
|
…ain" called out here: #77168 (comment)
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@chuckdries @twisterdotcom One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
|
thank you @chuckdries for the comments! i've addressed them and pushed a new commit |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.79-0 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.81-0 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀
|
Updating the documentation to reflect the last release in Release 4 of the Domains & SAML in newdot project.
Explanation of Change
Fixed Issues
$ #69195
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari