[No QA] Update claim domain & verify domain link#77415
Merged
Merged
Conversation
updating the link name after this PR gets released: https://github.com/Expensify/App/pull/77168/files
updating the link name after this PR gets released: https://github.com/Expensify/App/pull/77168/files
melvin-bot
Bot
requested review from
heyjennahay
and removed request for
a team
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@ZhenjaHorbach @lydiabarclay One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| }; | ||
|
|
||
| const confirmRemoveCurrentTransaction = () => { | ||
| showConfirmModal({ |
Contributor
There was a problem hiding this comment.
❌ PERF-4 (docs)
This function is passed as a prop to MoneyRequestConfirmationList but is not memoized with useCallback. This creates a new function instance on every render, causing unnecessary re-renders of the child component.
const confirmRemoveCurrentTransaction = useCallback(() => {
showConfirmModal({
title: translate('iou.removeExpense'),
prompt: translate('iou.removeExpenseConfirmation'),
confirmText: translate('common.remove'),
cancelText: translate('common.cancel'),
danger: true,
}).then((result) => {
if (result.action !== ModalActions.CONFIRM) {
return;
}
removeCurrentTransaction();
});
}, [showConfirmModal, translate, removeCurrentTransaction]);
| threeDotsMenuItems={[ | ||
| { | ||
| icon: Expensicons.Trashcan, | ||
| icon: expensifyIcons.Trashcan, |
Contributor
There was a problem hiding this comment.
❌ PERF-4 (docs)
The threeDotsMenuItems array is created inline on every render with a new function reference, causing unnecessary re-renders of HeaderWithBackButton.
const threeDotsMenuItems = useMemo(() => [
{
icon: expensifyIcons.Trashcan,
text: translate('iou.deleteSubrate'),
onSelected: () => {
showConfirmModal({
title: translate('iou.deleteSubrate'),
prompt: translate('iou.deleteSubrateConfirmation'),
confirmText: translate('common.delete'),
cancelText: translate('common.cancel'),
shouldEnableNewFocusManagement: true,
danger: true,
}).then((result) => {
if (result.action !== ModalActions.CONFIRM) {
return;
}
deleteSubrateAndHideModal();
});
},
shouldCallAfterModalHide: true,
},
], [expensifyIcons.Trashcan, translate, showConfirmModal, deleteSubrateAndHideModal]);
| threeDotsMenuItems={[ | ||
| { | ||
| icon: Expensicons.Trashcan, | ||
| icon: expensifyIcons.Trashcan, |
Contributor
There was a problem hiding this comment.
❌ PERF-4 (docs)
The threeDotsMenuItems array is created inline on every render with a new function reference, causing unnecessary re-renders of HeaderWithBackButton.
const threeDotsMenuItems = useMemo(() => [
{
icon: expensifyIcons.Trashcan,
text: translate('distance.deleteWaypoint'),
onSelected: () => {
showConfirmModal({
title: translate('distance.deleteWaypoint'),
prompt: translate('distance.deleteWaypointConfirmation'),
confirmText: translate('common.delete'),
cancelText: translate('common.cancel'),
shouldEnableNewFocusManagement: true,
danger: true,
}).then((result) => {
if (result.action !== ModalActions.CONFIRM) {
return;
}
deleteStopAndHideModal();
});
},
shouldCallAfterModalHide: true,
},
], [expensifyIcons.Trashcan, translate, showConfirmModal, deleteStopAndHideModal]);
| iconRight={Expensicons.Trashcan} | ||
| onPress={() => setIsDeleteReceiptConfirmModalVisible(true)} | ||
| iconRight={expensifyIcons.Trashcan} | ||
| onPress={() => { |
Contributor
There was a problem hiding this comment.
❌ PERF-4 (docs)
The inline arrow function creates a new function instance on every render. This should be extracted and memoized with useCallback.
const handleDeletePress = useCallback(() => {
showConfirmModal({
title: translate('receipt.deleteReceipt'),
prompt: translate('receipt.deleteConfirmation'),
confirmText: translate('common.delete'),
cancelText: translate('common.cancel'),
danger: true,
}).then((result) => {
if (result.action !== ModalActions.CONFIRM) {
return;
}
deleteReceipt();
});
}, [showConfirmModal, translate, deleteReceipt]);
// Then use:
<Button
shouldShowRightIcon
iconRight={expensifyIcons.Trashcan}
onPress={handleDeletePress}
innerStyles={styles.bgTransparent}
large
/>
59 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://04d320ef.helpdot.pages.dev ⚡️ Updated articles: |
Contributor
HelpDot Documentation ReviewOverall AssessmentThis PR updates a single documentation link in the SAML SSO setup guide. The change updates the link text from "Learn how to verify a domain" to "Learn how to claim and verify a domain" and updates the URL from Critical Issue: This PR has a dependency problem. It references a file ( Scores Summary
Key Findings
Recommendations
Files Reviewed
Merge OrderThis PR should be merged after PR #77168 to maintain link integrity and avoid broken documentation links. Note: This PR also contains TypeScript code changes unrelated to documentation (refactoring ConfirmModal usage). Those changes were not evaluated as part of this HelpDot documentation review. |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
This reverts commit 29dcc71.
mountiny
changed the title
mountiny
approved these changes
Dec 12, 2025
mountiny
changed the title
mountiny
changed the title
lydiabarclay
approved these changes
Dec 12, 2025
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
mountiny
changed the title
mountiny
approved these changes
Dec 16, 2025
Contributor
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.79-0 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.81-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
updating the link name after this PR gets released: https://github.com/Expensify/App/pull/77168/files
Fixed Issues
$ #69195
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari