Call the invite whisper for only workspace chats by parasharrajat · Pull Request #79299 · Expensify/App

parasharrajat · 2026-01-11T16:17:35Z

Explanation of Change

Fixed Issues

$ #77336
PROPOSAL: #77336

Tests

Go to staging.new.expensify.com
Log in with a new account.
Select Manage my team then continue with the onboarding flow
Click FAB >> Start Chat >> Room >> Enter Room name >> Create Room
User is directed to the created Room >> Click header >> Member >> Invite non-existing member to the room
Verify that user is invited.
Create a worksapce.
Go to worksapce chat.
Click header > member > Invite non-existing member to the room
Verify that invite whisper is shown.

Verify that no errors appear in the JS console

Offline tests

Follow upto step 6.

QA Steps

same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

11.01.2026_21.51.03_REC.mp4

melvin-bot · 2026-01-11T16:20:16Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-01-11T16:20:21Z

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-01-11T16:25:50Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/RoomInvitePage.tsx	`0.00% <0.00%> (ø)`
... and 10 files with indirect coverage changes

trjExpensify

Garrett had eyes on the parent issue, follow-up to rolling out the workspace chat whisper for incorrect invites 👍

DylanDylann · 2026-01-13T04:28:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-13.at.11.33.58.mov

Android: mWeb Chrome

Screen.Recording.2026-01-13.at.11.32.26.mov

iOS: HybridApp

Screen.Recording.2026-01-13.at.11.32.58.mov

iOS: mWeb Safari

Screen.Recording.2026-01-13.at.11.31.48.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-13.at.11.25.53.mov

DylanDylann

LGTM

DylanDylann · 2026-01-13T04:29:57Z

@parasharrajat Could you merge main to trigger GH actions again?

DylanDylann · 2026-01-15T07:47:49Z

@carlosmiceli Kindly bump

carlosmiceli · 2026-01-18T00:57:18Z

Sorry, was sick the last 3-4 days 🙇

OSBotify · 2026-01-18T01:06:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-20T17:42:17Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.5-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mitarachim · 2026-01-21T10:28:55Z

@parasharrajat This PR is failing because of a regression issue App crashes after inviting non-existing member to the room
The issue is reproducible in: iOS

Bug7054365_1768949624502.BUG-iOS.mp4

This reverts commit eafbcff, reversing changes made to 94c4ef9.

…490659be6853e7f57ca4e2 Revert "Merge pull request #79299 from parasharrajat/fix/whisper"

…490659be6853e7f57ca4e2 Revert "Merge pull request #79299 from parasharrajat/fix/whisper" (cherry picked from commit feb563f) (cherry-picked to staging by Beamanator)

…parasharrajat/fix/whisper""

OSBotify · 2026-01-21T23:06:46Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.5-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-21T23:37:17Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.6-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-22T22:24:33Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.6-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…afbcff79bd264acdc490659be6853e7f57ca4e2 Revert "[CP Staging] Revert "Merge pull request #79299 from parasharrajat/fix/whisper""

OSBotify · 2026-01-23T22:34:25Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.8-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-26T21:56:33Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.8-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

abzokhattab · 2026-05-23T02:04:49Z

This PR caused #81168 (iOS crash when inviting member to room).

The new inviteToRoom(reportID, invitedEmailsToAccountIDs, formatPhoneNumber) call for non-workspace rooms applies optimistic Onyx updates (updating report.participants) synchronously before Navigation.goBack() completes. On iOS, this causes the underlying RoomMembersPage to re-render during the native UINavigationController transition animation, resulting in a use-after-free crash in reanimated.

Fixed in #90261 by deferring the invite action into an afterTransition callback on Navigation.goBack().

Call the invite whisper for only workspace chats

e43677f

melvin-bot Bot assigned parasharrajat Jan 11, 2026

parasharrajat marked this pull request as ready for review January 11, 2026 16:20

parasharrajat requested review from a team as code owners January 11, 2026 16:20

melvin-bot Bot requested review from DylanDylann and trjExpensify and removed request for a team January 11, 2026 16:20

melvin-bot Bot requested review from a team and carlosmiceli and removed request for a team January 11, 2026 16:20

github-actions Bot reviewed Jan 11, 2026

View reviewed changes

Comment thread src/pages/RoomInvitePage.tsx

aimane-chnaif mentioned this pull request Jan 11, 2026

[Due for payment 2026-01-21] [$250] Investigate workflow job failing on main: test / test (job 4) #79297

Closed

trjExpensify approved these changes Jan 12, 2026

View reviewed changes

DylanDylann approved these changes Jan 13, 2026

View reviewed changes

Merge branch 'Expensify:main' into fix/whisper

e3b7d89

carlosmiceli merged commit eafbcff into Expensify:main Jan 18, 2026
29 checks passed

OSBotify mentioned this pull request Jan 20, 2026

Deploy Checklist: New Expensify 2026-01-20 #80009

Closed

85 tasks

carlosmiceli mentioned this pull request Jan 21, 2026

[Due for payment 2026-02-19] [$250] Invited to chat only user can't open expense report from the first try #80062

Closed

7 tasks

mitarachim mentioned this pull request Jan 21, 2026

[Due for payment 2026-01-29] iOS - App crashes after inviting non-existing member to the room #80101

Closed

7 tasks

carlosmiceli added a commit that referenced this pull request Jan 21, 2026

Revert "Merge pull request #79299 from parasharrajat/fix/whisper"

aac6d39

This reverts commit eafbcff, reversing changes made to 94c4ef9.

carlosmiceli mentioned this pull request Jan 21, 2026

[CP Staging] Revert "Merge pull request #79299 from parasharrajat/fix/whisper" #80117

Merged

53 tasks

carlosmiceli added a commit that referenced this pull request Jan 21, 2026

Merge pull request #80117 from Expensify/cm-revert-eafbcff79bd264acdc…

feb563f

…490659be6853e7f57ca4e2 Revert "Merge pull request #79299 from parasharrajat/fix/whisper"

parasharrajat added a commit to parasharrajat/App that referenced this pull request Jan 21, 2026

Revert "[CP Staging] Revert "Merge pull request Expensify#79299 from …

77a5278

…parasharrajat/fix/whisper""

melvin-bot Bot mentioned this pull request Jan 21, 2026

[Due for payment 2026-02-02] [Due for payment 2026-01-29] [Due for payment 2026-01-28] Email - No Invitation email sent to mailbox after user invite new user to Room #77336

Closed

8 tasks

OSBotify mentioned this pull request Jan 22, 2026

Chat - Whisper to invite member reappears after inviting member to submit expenses #80292

Closed

7 tasks

carlosmiceli added a commit that referenced this pull request Jan 23, 2026

Merge pull request #80121 from parasharrajat/revert-80117-cm-revert-e…

7982509

…afbcff79bd264acdc490659be6853e7f57ca4e2 Revert "[CP Staging] Revert "Merge pull request #79299 from parasharrajat/fix/whisper""

OSBotify mentioned this pull request Jan 23, 2026

Deploy Checklist: New Expensify 2026-01-23 #80389

Closed

43 tasks

abzokhattab mentioned this pull request May 23, 2026

[Due for payment 2026-05-29] [$250] iOS - Room - App crashes when inviting member to room #81168

Closed

7 tasks

Conversation

parasharrajat commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 11, 2026

Uh oh!

melvin-bot Bot commented Jan 11, 2026

Uh oh!

Uh oh!

codecov Bot commented Jan 11, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Jan 13, 2026

Uh oh!

DylanDylann commented Jan 15, 2026

Uh oh!

Uh oh!

carlosmiceli commented Jan 18, 2026

Uh oh!

OSBotify commented Jan 18, 2026

Uh oh!

OSBotify commented Jan 20, 2026

Uh oh!

mitarachim commented Jan 21, 2026

Uh oh!

OSBotify commented Jan 21, 2026

Uh oh!

OSBotify commented Jan 21, 2026

Uh oh!

OSBotify commented Jan 22, 2026

Uh oh!

OSBotify commented Jan 23, 2026

Uh oh!

OSBotify commented Jan 26, 2026

Uh oh!

abzokhattab commented May 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

parasharrajat commented Jan 11, 2026 •

edited

Loading

codecov Bot commented Jan 11, 2026 •

edited by github-actions Bot

Loading

DylanDylann commented Jan 13, 2026 •

edited

Loading