[CP Staging] Revert "Merge pull request #79299 from parasharrajat/fix/whisper" by carlosmiceli · Pull Request #80117 · Expensify/App

carlosmiceli · 2026-01-21T14:17:36Z

Straight revert of #79299 to fix blockers.

Explanation of Change

Fixed Issues

$ #80101
$ #80062

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

This reverts commit eafbcff, reversing changes made to 94c4ef9.

melvin-bot · 2026-01-21T14:18:20Z

@inimaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aac6d39878

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-01-21T14:24:08Z

        if (report?.reportID) {
-            if (isPolicyExpenseChat(report)) {
-                inviteToRoomAction(report, ancestors, invitedEmailsToAccountIDs, currentUserPersonalDetails.timezone ?? CONST.DEFAULT_TIME_ZONE);
-            } else {
-                inviteToRoom(reportID, invitedEmailsToAccountIDs, formatPhoneNumber);
-            }
+            inviteToRoomAction(report, ancestors, invitedEmailsToAccountIDs, currentUserPersonalDetails.timezone ?? CONST.DEFAULT_TIME_ZONE);
            clearUserSearchPhrase();


Use API invite for non-policy rooms

This now always uses inviteToRoomAction, but that helper (see inviteToRoomAction in src/libs/actions/Report.ts) only calls addComment(...) and never hits INVITE_TO_ROOM/INVITE_TO_GROUP_CHAT or updates pending members. That means in normal rooms/group chats (i.e., not policy expense chats where concierge whispers are handled) adding members will just post a message and won’t actually invite or add participants, so the “Invite” flow silently fails for those rooms.

Useful? React with 👍 / 👎.

codecov · 2026-01-21T14:28:38Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/RoomInvitePage.tsx	`0.00% <0.00%> (ø)`
... and 40 files with indirect coverage changes

…490659be6853e7f57ca4e2 Revert "Merge pull request #79299 from parasharrajat/fix/whisper" (cherry picked from commit feb563f) (cherry-picked to staging by Beamanator)

OSBotify · 2026-01-21T14:45:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-21T15:24:48Z

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.3.5-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-21T23:08:55Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.5-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-21T23:39:29Z

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.3.6-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-22T22:26:45Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.6-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Revert "Merge pull request #79299 from parasharrajat/fix/whisper"

aac6d39

This reverts commit eafbcff, reversing changes made to 94c4ef9.

carlosmiceli requested review from a team as code owners January 21, 2026 14:17

melvin-bot Bot assigned carlosmiceli Jan 21, 2026

melvin-bot Bot requested review from heyjennahay and inimaga and removed request for a team January 21, 2026 14:17

JS00001 approved these changes Jan 21, 2026

View reviewed changes

inimaga approved these changes Jan 21, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Jan 21, 2026

View reviewed changes

carlosmiceli mentioned this pull request Jan 21, 2026

[Due for payment 2026-01-29] iOS - App crashes after inviting non-existing member to the room #80101

Closed

7 tasks

carlosmiceli merged commit feb563f into main Jan 21, 2026
33 of 38 checks passed

carlosmiceli deleted the cm-revert-eafbcff79bd264acdc490659be6853e7f57ca4e2 branch January 21, 2026 14:35

carlosmiceli mentioned this pull request Jan 21, 2026

Deploy Checklist: New Expensify 2026-01-20 #80009

Closed

85 tasks

Beamanator changed the title ~~Revert "Merge pull request #79299 from parasharrajat/fix/whisper"~~ [CP Staging] Revert "Merge pull request #79299 from parasharrajat/fix/whisper" Jan 21, 2026

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jan 21, 2026

parasharrajat mentioned this pull request Jan 21, 2026

Revert "[CP Staging] Revert "Merge pull request #79299 from parasharrajat/fix/whisper"" #80121

Merged

54 tasks

melvin-bot Bot mentioned this pull request Jan 22, 2026

[Due for payment 2026-02-19] [$250] Invited to chat only user can't open expense report from the first try #80062

Closed

7 tasks

OSBotify mentioned this pull request Jan 22, 2026

Chat - Whisper to invite member reappears after inviting member to submit expenses #80292

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Revert "Merge pull request #79299 from parasharrajat/fix/whisper"#80117

[CP Staging] Revert "Merge pull request #79299 from parasharrajat/fix/whisper"#80117
carlosmiceli merged 1 commit into
mainfrom
cm-revert-eafbcff79bd264acdc490659be6853e7f57ca4e2

carlosmiceli commented Jan 21, 2026 •

edited by Beamanator

Loading

Uh oh!

melvin-bot Bot commented Jan 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jan 21, 2026

Uh oh!

codecov Bot commented Jan 21, 2026 •

edited by github-actions Bot

Loading

Uh oh!

Uh oh!

OSBotify commented Jan 21, 2026

Uh oh!

OSBotify commented Jan 21, 2026

Uh oh!

OSBotify commented Jan 21, 2026

Uh oh!

OSBotify commented Jan 21, 2026

Uh oh!

OSBotify commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

carlosmiceli commented Jan 21, 2026 • edited by Beamanator Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jan 21, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

OSBotify commented Jan 21, 2026

Uh oh!

OSBotify commented Jan 21, 2026

Uh oh!

OSBotify commented Jan 21, 2026

Uh oh!

OSBotify commented Jan 21, 2026

Uh oh!

OSBotify commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

carlosmiceli commented Jan 21, 2026 •

edited by Beamanator

Loading

codecov Bot commented Jan 21, 2026 •

edited by github-actions Bot

Loading