Make LHN rows look the same as chatswitcher ones#793
Conversation
|
Gonna tag in pullerbear on this one since I am leaving for a week + and won't have time to stick with this. |
| isChatSwitcher: false, | ||
| }; | ||
|
|
||
| const ChatLinkRow = ({ |
There was a problem hiding this comment.
Maybe just ChatRow would be good enough.
There was a problem hiding this comment.
I thought about it, but it felt like a row in the chat itself, instead of a row with a chat 🤷
|
@Gonals looks like the screenshot didn't quite come through - mind re-uploading? |
|
|
@robertjchen, @roryabraham, bumping this! |
|
You don't have to do this in this PR if you don't want to, but react-native-web v14 was just released and offers support for hover states on pressables like so: <Pressable
children={
({ pressed, hovered, focused }) => {}
}
style={
({ pressed, hovered, focused }) => {}
}
/>And it would be awesome if the chat switcher automatically focused the |
This is actually really nice! There are big plans for a LHN revamp, though, so I'll probably wait till that's decided! |
| to={ROUTES.getReportRoute(option.reportID)} | ||
| style={styles.textDecorationNoLine} | ||
| > | ||
| <TouchableOpacity |
There was a problem hiding this comment.
FYI, this broke mobile clients because the touchable opacity is on top of the pressable link and this prevents the link from triggering a router change.
Brings the companion build in line with the latest commits on Expensify/react-native-onyx#793: - align multiGet cache hit check with cache.hasCacheForKey - preserve cache-first merge when multiGet pre-warm rejects - multiGet: prefer cache over stale storage on concurrent writes - additional regression tests for mergeCollection pre-warm Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>


@shawnborton, can you review (although I have reused the ChatSwitcher file, so the styles should be fine)?
@marcaaron, can you review? Any reason we might want to keep these two in separate files?
Instead of applying the styles to
SideBarLink.js, I decided, instead, to useChatSwitcherRow(now renamed toChatLinkRowin both places, since we'll likely always want to keep the same format in both places and it just required a few changes.Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/144292
Tests/QA

2. Make sure receiving a message correctly bolds the row in the LHN:
3. Make sure ChatSwitcher still works correctly. 4. Check that 1-3 are all true across platforms