Feat: existing personal cards by waterim · Pull Request #79562 · Expensify/App

waterim · 2026-01-14T12:33:45Z

Details

This PR introduces personal cards to the Wallet page

Fixed Issues

$ #78384

Tests

Prerequisites: You need to add testing personal card in the OldDot:

in Expensify Classic, go to Settings > Account > Wallet > Import Card/Bank
select Discover card
use the creds expensifydemo / #USD

Test:

Go to Account
Go to Wallet
Observe assigned cards
Personal card is displayed correctly

Test 2:

Go to Account
Go to Wallet
Press on the personal card to see details
Test "Mark transaction as reimbursable"
Check optimistic data is correct and API call is correct

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Details

melvin-bot · 2026-01-14T12:33:52Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2026-01-20T11:17:27Z

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

waterim · 2026-01-20T11:24:55Z

Found few issues, reconverting to draft, will open as soon as I fix it

…onal-cards

codecov · 2026-01-20T12:39:25Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
src/SCREENS.ts	`100.00% <ø> (ø)`
src/libs/API/types.ts	`100.00% <ø> (ø)`
...igation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`75.00% <ø> (ø)`
...ExpensifyCardPage/ExpensifyCardContextProvider.tsx	`78.26% <ø> (ø)`
.../pages/settings/Wallet/ExpensifyCardPage/index.tsx	`67.77% <100.00%> (ø)`
src/selectors/Card.ts	`100.00% <100.00%> (ø)`
src/components/EReceipt.tsx	`3.50% <0.00%> (ø)`
...c/components/ReportActionItem/IssueCardMessage.tsx	`0.00% <0.00%> (ø)`
... and 22 more
... and 24 files with indirect coverage changes

github-actions · 2026-01-29T22:05:21Z

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-01-29T22:10:43Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #79562.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Web 🕸️
https://79562.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

amyevans

Looks good to me! 🎉

ShridharGoel · 2026-01-29T23:13:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-01-30.at.5.30.48.AM.mov

Feedback addressed

OSBotify · 2026-01-30T00:19:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

abzokhattab · 2026-01-30T00:31:44Z

 */
-const filterPersonalCards = (cards: OnyxEntry<CardList>): CardList => {
-    return filterObject(cards ?? {}, (key, card) => isPersonalCard(card));
+const filterOutPersonalCards = (cards: OnyxEntry<CardList>): CardList => {


I have a question about this one, i am a bit confused why we are duplicating this function here once and another time in the cardUtils file .. it looks like the one in the cardUtils is not used. Can I remove it? let me know what u think

@waterim @ShridharGoel

OSBotify · 2026-01-30T22:16:07Z

🚀 Deployed to staging by https://github.com/amyevans in version: 9.3.11-16 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-05T20:17:50Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

mkhutornyi · 2026-05-01T02:48:59Z

+                <MenuItemWithTopDescription
+                    description={translate('workspace.moreFeatures.companyCards.cardNumber')}
+                    title={customCardNames?.[cardID] ?? getDefaultCardName(cardholder?.firstName)}


This was overlooked. The description should be card name, NOT card number.
Issue: #88555

mkhutornyi · 2026-05-01T02:50:16Z

+            <HeaderWithBackButton
+                title={translate('workspace.moreFeatures.companyCards.cardNumber')}
+                onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET_PERSONAL_CARD_DETAILS.getRoute(cardID))}
+            />
+            <Text style={[styles.mh5, styles.mt3, styles.mb5]}>{translate('workspace.moreFeatures.companyCards.giveItNameInstruction')}</Text>
+            <FormProvider
+                formID={ONYXKEYS.FORMS.EDIT_PERSONAL_CARD_NAME_FORM}
+                submitButtonText={translate('common.save')}
+                onSubmit={submit}
+                style={[styles.flex1, styles.mh5]}
+                enabledWhenOffline
+                validate={validate}
+                shouldHideFixErrorsAlert
+            >
+                <InputWrapper
+                    InputComponent={TextInput}
+                    inputID={INPUT_IDS.NAME}
+                    label={translate('workspace.moreFeatures.companyCards.cardNumber')}
+                    aria-label={translate('workspace.moreFeatures.companyCards.cardNumber')}


Same here. This is card name edit page, NOT card number

situchan · 2026-05-26T02:15:44Z

+                    <ImageSVG
+                        contentFit="contain"
+                        src={getCardIconSource()}
+                        pointerEvents="none"
+                        height={variables.cardPreviewHeight}
+                        width={variables.cardPreviewWidth}
+                    />


This page calls getCardFeedIcon() for the card art, but didn't use the Plaid-aware rendering (getPlaidInstitutionIconUrl → PlaidCardFeedIcon) that the wallet list in PaymentMethodList.tsx already had in the same PR.

Issue: [Personal Card Import] Incorrect card art on card details for Plaid personal card

waterim added 4 commits January 12, 2026 16:20

update translations and upadte route name

c413274

update all places with new route name

714bef2

translations

3a1dd77

personal card changes

053f058

melvin-bot Bot assigned waterim Jan 14, 2026

waterim added 2 commits January 19, 2026 21:36

update filters

2211e29

update write command

f71d169

waterim marked this pull request as ready for review January 20, 2026 11:17

waterim requested review from a team as code owners January 20, 2026 11:17

melvin-bot Bot requested review from JmillsExpensify and ShridharGoel and removed request for a team January 20, 2026 11:17

github-actions Bot reviewed Jan 20, 2026

View reviewed changes

Comment thread src/pages/workspace/companyCards/WorkspaceCompanyCardDetailsPage.tsx Outdated

github-actions Bot reviewed Jan 20, 2026

View reviewed changes

Comment thread src/pages/workspace/companyCards/WorkspaceCompanyCardDetailsPage.tsx

github-actions Bot reviewed Jan 20, 2026

View reviewed changes

Comment thread src/pages/workspace/companyCards/WorkspaceCompanyCardEditCardNamePage.tsx Outdated

github-actions Bot reviewed Jan 20, 2026

View reviewed changes

Comment thread src/pages/workspace/companyCards/WorkspaceCompanyCardEditTransactionStartDatePage.tsx Outdated

waterim marked this pull request as draft January 20, 2026 11:24

waterim added 4 commits January 20, 2026 12:43

Merge remote-tracking branch 'origin' into feat/waterim/existing-pers…

f9c77e8

…onal-cards

updates

afc6bc9

update formatting

d70e42a

fix linter

e563a44

waterim added 3 commits January 20, 2026 13:46

fixes

ac97bf9

fixes

30d4215

revert route naming changes

6dfaf33

waterim added 4 commits January 29, 2026 23:20

feedback

0b46007

update tests

ace262d

update name to filterOutPersonalCards

9af9189

return name-value pairs

47cee24

amyevans approved these changes Jan 29, 2026

View reviewed changes

ShridharGoel approved these changes Jan 30, 2026

View reviewed changes

melvin-bot Bot requested a review from amyevans January 30, 2026 00:04

amyevans approved these changes Jan 30, 2026

View reviewed changes

amyevans merged commit 45642c4 into Expensify:main Jan 30, 2026
32 of 34 checks passed

amyevans mentioned this pull request Jan 30, 2026

[Personal card import] [R1] Assigned cards sub-sections #78385

Closed

abzokhattab reviewed Jan 30, 2026

View reviewed changes

rojiphil mentioned this pull request Jan 30, 2026

Filter unreported expenses by owner to prevent showing member expenses to admin #73230

Merged

51 tasks

situchan mentioned this pull request Jan 30, 2026

[RCA #80556] Reports - Card field is empty despite having CSV card selected #80865

Closed

7 tasks

OSBotify mentioned this pull request Jan 30, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Closed

mitarachim mentioned this pull request Jan 31, 2026

Card - Field title shows "Card number", but description shows "Give the card a name" #81093

Closed

7 tasks

francoisl mentioned this pull request Feb 2, 2026

Expensify Card - Expensify Card subtitle shows expensify-policy.exfy instead of workspace name #81101

Closed

7 tasks

joekaufmanexpensify mentioned this pull request Feb 3, 2026

[No QA] Update Personal-Cards.md #81351

Merged

57 tasks

amyevans mentioned this pull request Feb 4, 2026

[Personal card import] [R1] Existing personal cards on Wallet #78384

Closed

jponikarchuk mentioned this pull request Feb 5, 2026

Wallet - Assigned cards section is shown when there is no card #81586

Closed

7 tasks

mkhutornyi reviewed May 1, 2026

View reviewed changes

mkhutornyi mentioned this pull request May 1, 2026

[Due for payment 2026-05-07] [$125] Update personal card field name in NewDot #88555

Closed

7 tasks

MelvinBot mentioned this pull request May 22, 2026

[Due for payment 2026-05-26] [Personal Card Import] [$250] Incorrect card art on card details for Plaid personal card #88241

Closed

7 tasks

situchan reviewed May 26, 2026

View reviewed changes

Conversation

waterim commented Jan 14, 2026 • edited by amyevans Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 14, 2026

Uh oh!

melvin-bot Bot commented Jan 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waterim commented Jan 20, 2026

Uh oh!

codecov Bot commented Jan 20, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Jan 29, 2026

Uh oh!

github-actions Bot commented Jan 29, 2026

Uh oh!

amyevans left a comment

Choose a reason for hiding this comment

Uh oh!

ShridharGoel commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Jan 30, 2026

Uh oh!

abzokhattab Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 30, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

mkhutornyi May 1, 2026

Choose a reason for hiding this comment

Uh oh!

mkhutornyi May 1, 2026

Choose a reason for hiding this comment

Uh oh!

situchan May 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

waterim commented Jan 14, 2026 •

edited by amyevans

Loading

codecov Bot commented Jan 20, 2026 •

edited by github-actions Bot

Loading

ShridharGoel commented Jan 29, 2026 •

edited

Loading