[No QA] Update Personal-Cards.md#81351
Conversation
|
Putting this in review now because #79562 is on staging and passed QA |
HelpDot Documentation ReviewOverall AssessmentThis PR successfully transforms a placeholder article into comprehensive feature documentation for personal card management in New Expensify. The update provides clear, actionable guidance for users migrating from Expensify Classic, with well-structured sections covering discovery, functionality, and settings management. Scores Summary
Key FindingsPositive aspects:
Areas for improvement:
Critical items:
RecommendationsPriority 1 (Required):
Priority 2 (Strongly Recommended): Priority 3 (Nice to have): Files Reviewed
Overall verdict: Strong documentation update that effectively communicates the new feature. With the addition of breadcrumb navigation and minor clarity improvements, this will be excellent user-facing documentation. |
|
A preview of your ExpensifyHelp changes have been deployed to https://89145b68.helpdot.pages.dev ⚡️ Updated articles: |
|
Went through all the AI review comments 👍 |
|
Made some small changes to standardize breadcrumbs and headers, and incorporate some newer formatting rules. |
|
Nice, thanks! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚀 Deployed to staging by https://github.com/NicMendonca in version: 9.3.16-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.16-9 🚀
|
Explanation of Change
Updating personal cards article for R1 of the personal cards in NewDot project
Fixed Issues
https://github.com/Expensify/Expensify/issues/574406
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.