[CP Staging] Revert #79294 - Fix report title not updating when reimbursable expense is changed offline#80051
Conversation
|
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
There was a problem hiding this comment.
💡 Codex Review
Lines 6716 to 6719 in 5d88ce7
Because the dedicated {report:reimbursable} replacement was removed, the catch‑all replacement here will strip that token entirely, so any custom report title formulas that include {report:reimbursable} render a blank value in optimistic titles (e.g., when converting/creating expense reports before the server response). This regresses documented behavior and makes report titles lose reimbursable amounts until the server overwrites them.
App/src/libs/actions/IOU/index.ts
Lines 3136 to 3140 in 5d88ce7
This block updates the report totals and non‑reimbursable totals, but the report name is no longer recalculated afterward. When a policy uses a custom title formula (e.g., {report:total} or {report:reimbursable}), editing an expense amount or changing reimbursable status offline will leave the report title stale even though totals are updated optimistically.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Skipping checks, simple revert |
|
@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.3.5-4 🚀
|
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.5-7 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.3.6-0 🚀
|
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.6-4 🚀
|
This reverts PR #79294 which was merged on Jan 20, 2026.
Original PR: #79294
Merge commit: 9a6b28d
Test steps to validate fix:
Precondition
Expected Result: