Skip to content

[CP Staging] Revert "Hide paying invoices via Expensify behind a beta" (#82046)#82546

Closed
mountiny wants to merge 1 commit into
mainfrom
revert-82046-pay-invoice-beta
Closed

[CP Staging] Revert "Hide paying invoices via Expensify behind a beta" (#82046)#82546
mountiny wants to merge 1 commit into
mainfrom
revert-82046-pay-invoice-beta

Conversation

@mountiny

@mountiny mountiny commented Feb 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

This reverts PR #82046 ("Hide paying invoices via Expensify behind a beta").

PR #82046 introduced a PAY_INVOICE_VIA_EXPENSIFY beta gate that hid the ability to pay invoices via Expensify bank accounts/cards. This revert removes that beta gate, restoring the original invoice payment behavior where currency support alone determines whether pay-via-Expensify options are shown.

Changes across 4 files:

  1. src/CONST/index.ts — Removed the PAY_INVOICE_VIA_EXPENSIFY beta constant.
  2. src/components/SettlementButton/index.tsx — Removed isPayInvoiceViaExpensifyBetaEnabled checks; reverted showPayViaExpensifyOptions back to isCurrencySupported; removed the invoiceDefaultValue gating logic; restored the original hasIntentToPay ternary for default payment values.
  3. src/hooks/useBulkPayOptions.ts — Removed usePermissions import and beta check; reverted showPayViaExpensifyOptions back to isCurrencySupported.
  4. src/hooks/usePaymentOptions.ts — Removed usePermissions import and beta check; reverted showPayViaExpensifyOptions back to isCurrencySupported.

Conflict resolution:
There was one conflict in src/hooks/useBulkPayOptions.ts. After PR #82046 was merged, a separate PR added const activeAdminPolicies = useActiveAdminPolicies(); on an adjacent line. The revert wanted to remove the two lines added by #82046 (usePermissions destructure + beta check), but Git couldn't auto-resolve because the nearby activeAdminPolicies line didn't exist at the time of the original PR. Resolution: removed the two PR #82046 lines while keeping the activeAdminPolicies line which belongs to a different PR. The other 3 files auto-merged without conflicts.

Fixed Issues

$ #82485
PROPOSAL:

Tests

  1. Open an invoice report (as the recipient)
  2. Verify that the "Pay" button shows payment options including pay-via-Expensify bank account options (when currency is supported)
  3. Open Search, select invoice reports, and verify bulk pay options also include pay-via-Expensify options
  • Verify that no errors appear in the JS console

Offline tests

N/A - This is a revert of a beta gate, no new offline behavior introduced.

QA Steps

  1. Open an invoice report as the recipient
  2. Verify that payment options include pay-via-Expensify bank account/card options (when currency is supported)
  3. Verify invoices can be paid from Reports/Search and from invoice rooms
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@mountiny
Revert "Merge pull request #82046 from Expensify/cristi_hide-PayInvoi…
a285842 
…ce-via-Expensify"

This reverts commit 387c784, reversing
changes made to 9f0702f.
@mountiny mountiny requested review from a team as code owners February 16, 2026 11:03
@melvin-bot melvin-bot Bot requested review from joekaufmanexpensify and marcochavezf and removed request for a team February 16, 2026 11:03
@melvin-bot

melvin-bot Bot commented Feb 16, 2026

Copy link
Copy Markdown

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Feb 16, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a285842a07

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/components/SettlementButton/index.tsx
Comment on lines +464 to 465
if (hasIntentToPay) {
const currentBankInformation = formattedPaymentMethods.at(0) as BankAccount;

@chatgpt-codex-connector chatgpt-codex-connector Bot Feb 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Guard invoice one-tap pay on eligible Expensify option

This unconditional if (hasIntentToPay) now forces invoice payments down the EXPENSIFY path even when that option is not actually eligible (for example, unsupported invoice currency, or formattedPaymentMethods still empty while Onyx data is loading). That bypasses the isCurrencySupported gating used to build invoice submenu options and can either trigger an invalid pay-via-Expensify attempt or crash when formattedPaymentMethods.at(0) is undefined and currentBankInformation.accountData is accessed. Gate this branch with the same eligibility check used for invoice options and verify a payment method exists before forcing Expensify.

Useful? React with 👍 / 👎.

@codecov

codecov Bot commented Feb 16, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 87.39% <ø> (ø)
src/hooks/useBulkPayOptions.ts 45.83% <0.00%> (-1.11%) ⬇️
src/hooks/usePaymentOptions.ts 0.00% <0.00%> (ø)
src/components/SettlementButton/index.tsx 0.00% <0.00%> (ø)
... and 9 files with indirect coverage changes

@mountiny mountiny changed the title Revert "Hide paying invoices via Expensify behind a beta" (#82046) [CP Staging] Revert "Hide paying invoices via Expensify behind a beta" (#82046) Feb 16, 2026
@github-actions

github-actions Bot commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82546.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Web 🕸️
https://82546.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@mountiny

mountiny commented Feb 16, 2026

Copy link
Copy Markdown
Contributor Author

The behaviour is intentional now https://expensify.slack.com/archives/C01GTK53T8Q/p1771243142598549?thread_ts=1771064936.144169&cid=C01GTK53T8Q

@mountiny mountiny closed this Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@joekaufmanexpensify joekaufmanexpensify Awaiting requested review from joekaufmanexpensify

@marcochavezf marcochavezf Awaiting requested review from marcochavezf

Assignees

@mountiny mountiny

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mountiny