Hide paying invoices via Expensify behind a beta by cristipaval · Pull Request #82046 · Expensify/App

cristipaval · 2026-02-10T20:47:57Z

Explanation of Change

This PR hides the options to pay invoices with bank accounts or cards via Expensify. Even if invoices are not promoted in NewDot yet, we realised that some users use them, and we have an issue that prevents the senders from getting the funds in their bank account. Here is another Slack thread where you can see a user having the same problem. We decided not to prioritize fixing this right now, because this would require product changes, and it might not be worth it since #billpay is on the roadmap for sometime later this year.

Fixed Issues

#67218
PROPOSAL:

Tests

Test that the invoices can only be marked as paid from Reports/Search and from the invoice rooms.

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Test that invoices can only be marked as paid; they can't be paid via Expensify.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-11.at.13.36.03.mov

melvin-bot · 2026-02-10T20:48:38Z

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-02-10T20:55:00Z

Code Review Summary

I've completed a comprehensive review of PR #82046. The changes successfully implement hiding invoice payment via Expensify behind a beta flag.

Key Findings

Code Duplication (CONSISTENCY-3)
I found that the same invoice payment options logic pattern is duplicated across three files:

src/components/SettlementButton/index.tsx
src/hooks/useBulkPayOptions.ts
src/hooks/usePaymentOptions.ts

Each file independently implements:

A getInvoicesOptionsMarkAsPaidOnly function that returns "pay elsewhere" option only
A getInvoicesOptionsFull function that returns full payment options including bank accounts/cards
Logic to select between them based on the beta flag

Recommendation: Consider extracting this shared logic into a utility function or shared hook to reduce duplication and make future maintenance easier.

Overall Assessment

The implementation is functionally correct and follows the existing patterns in the codebase. The beta flag approach is appropriate for this use case. While there's code duplication, it's consistent with the current architectural patterns where each component/hook manages its own payment options independently.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c797b8a56d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-02-10T20:57:35Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`87.39% <ø> (ø)`
src/hooks/useBulkPayOptions.ts	`46.93% <25.00%> (+1.10%)`	⬆️
src/hooks/usePaymentOptions.ts	`0.00% <0.00%> (ø)`
src/components/SettlementButton/index.tsx	`0.00% <0.00%> (ø)`
... and 65 files with indirect coverage changes

cristipaval · 2026-02-11T11:25:34Z

@codex review
@claude review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5d9bf9d1f6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

cristipaval · 2026-02-11T12:55:04Z

@getusha , I see you reviewed the PR that aligned invoice payment with the settlement button. Could you please review the current PR as well? 🙏

getusha · 2026-02-12T14:04:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-12.at.4.59.46.in.the.afternoon.mov

getusha

Looks good!

cristipaval · 2026-02-12T17:44:44Z

Thanks @getusha! @MariaHCD, @youssef-lr, could any of you do the final review? 🙏

OSBotify · 2026-02-12T19:12:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-02-12T19:21:29Z

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-12T19:26:23Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82046.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-387c784-cdb7e5c9150c2c6c14d891fb2e286d4013730d10/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-387c784-cd605ac10e3975ad860bafa6593694216481276e/index.html

Web 🕸️
https://82046.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-13T19:11:36Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.3.19-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…ce-via-Expensify" This reverts commit 387c784, reversing changes made to 9f0702f.

OSBotify · 2026-02-16T15:26:59Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.19-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

cristipaval requested a review from MariaHCD February 10, 2026 20:47

cristipaval self-assigned this Feb 10, 2026

cristipaval requested review from a team as code owners February 10, 2026 20:47

cristipaval added the InternalQA This pull request required internal QA label Feb 10, 2026

melvin-bot Bot requested review from heyjennahay and youssef-lr and removed request for a team February 10, 2026 20:48

melvin-bot Bot removed the request for review from a team February 10, 2026 20:48

github-actions Bot reviewed Feb 10, 2026

View reviewed changes

Comment thread src/components/SettlementButton/index.tsx Outdated

github-actions Bot reviewed Feb 10, 2026

View reviewed changes

Comment thread src/hooks/useBulkPayOptions.ts Outdated

github-actions Bot reviewed Feb 10, 2026

View reviewed changes

Comment thread src/hooks/usePaymentOptions.ts

chatgpt-codex-connector Bot reviewed Feb 10, 2026

View reviewed changes

Comment thread src/components/SettlementButton/index.tsx Outdated

Comment thread src/hooks/usePaymentOptions.ts Outdated

cristipaval changed the title ~~Hide paying invoices via Expensify behind a beta~~ [WIP] Hide paying invoices via Expensify behind a beta Feb 10, 2026

cristipaval added 2 commits February 11, 2026 12:41

Add a beta flag

1f31675

Show Pay via Expensify for Invoice only if beta enabled

5d9bf9d

cristipaval force-pushed the cristi_hide-PayInvoice-via-Expensify branch from 04baf28 to 5d9bf9d Compare February 11, 2026 11:24

chatgpt-codex-connector Bot reviewed Feb 11, 2026

View reviewed changes

Comment thread src/components/SettlementButton/index.tsx

cristipaval changed the title ~~[WIP] Hide paying invoices via Expensify behind a beta~~ Hide paying invoices via Expensify behind a beta Feb 11, 2026

Default value according to the beta

660fa91

cristipaval requested a review from getusha February 11, 2026 12:54

Fix lint errors

fb1f818

getusha approved these changes Feb 12, 2026

View reviewed changes

youssef-lr approved these changes Feb 12, 2026

View reviewed changes

cristipaval merged commit 387c784 into main Feb 12, 2026
34 checks passed

cristipaval deleted the cristi_hide-PayInvoice-via-Expensify branch February 12, 2026 19:00

OSBotify mentioned this pull request Feb 13, 2026

Deploy Checklist: New Expensify 2026-02-13 #82449

Closed

69 tasks

OSBotify mentioned this pull request Feb 14, 2026

Invoice- Missing option "Add bank account" when click on Pay as an individual/ business #82485

Closed

7 tasks

mountiny added a commit that referenced this pull request Feb 16, 2026

Revert "Merge pull request #82046 from Expensify/cristi_hide-PayInvoi…

a285842

…ce-via-Expensify" This reverts commit 387c784, reversing changes made to 9f0702f.

mountiny mentioned this pull request Feb 16, 2026

[CP Staging] Revert "Hide paying invoices via Expensify behind a beta" (#82046) #82546

Closed

53 tasks

Conversation

cristipaval commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 10, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Feb 10, 2026

Code Review Summary

Key Findings

Overall Assessment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Feb 10, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cristipaval commented Feb 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

cristipaval commented Feb 11, 2026

Uh oh!

getusha commented Feb 12, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

getusha left a comment

Choose a reason for hiding this comment

Uh oh!

cristipaval commented Feb 12, 2026

Uh oh!

Uh oh!

OSBotify commented Feb 12, 2026

Uh oh!

github-actions Bot commented Feb 12, 2026

Uh oh!

github-actions Bot commented Feb 12, 2026

Uh oh!

OSBotify commented Feb 13, 2026

Uh oh!

OSBotify commented Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cristipaval commented Feb 10, 2026 •

edited

Loading

codecov Bot commented Feb 10, 2026 •

edited by github-actions Bot

Loading