[Android | iOS] Add borderRadius to mentions in chat#84556
Conversation
|
|
borderRadius to mentions in chatborderRadius to mentions in chat
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
borderRadius to mentions in chatborderRadius to mentions in chat
# Conflicts: # patches/react-native/details.md
j-piasecki
left a comment
There was a problem hiding this comment.
The implementation itself looks good to me!
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff0fd4ac20
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
# Conflicts: # patches/react-native/details.md
|
@parasharrajat kind bump 😄 |
|
Sure, I will check this asap. |
|
Kind bump 😅 cc: @parasharrajat |
Screenshots🔲 iOS / native🔲 iOS / Safari🔲 MacOS / Chrome🔲 Android / Chrome🔲 Android / native |
# Conflicts: # patches/react-native/details.md
|
@puneetlath could you retrigger the build? 🙏 Looks like there are some issues with it (#84556 (comment)) |
|
Sorry, just got back from OOO. Triggered a build now. |
|
🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
# Conflicts: # patches/react-native/details.md
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.4.8-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.4.8-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.8-3 🚀
|

Explanation of Change
React Native doesn't support
borderRadiuson nested<Text>components (only the outermost<Text>gets it). This means mentions in chat messages render with sharp corners on native, even though the live markdown preview (which uses custom rendering) shows them with rounded corners.This PR adds a React Native patch (
react-native+0.83.1+034+nested-text-border-radius.patch) that enablesborderRadiussupport for nested<Text>backgrounds on both iOS and Android:std::optional<Float> borderRadiusfield toTextAttributes, wired throughBaseTextPropsand attribute conversions.DrawCommandSpanwithReactBackgroundDrawSpanthat draws rounded-rect backgrounds behind text spans.NSLayoutManagersubclass (RCTTextLayoutManagerWithBorderRadius) that overridesfillBackgroundRectArrayto draw rounded rectangles usingUIBezierPath, with per-line corner rounding for multiline spans.With this patch, mentions in chat now correctly render with
borderRadius, matching the live markdown preview appearance.Fixed Issues
$ #78873
PROPOSAL:
Tests
@someone@somecompany.comor#roomor@here)Offline tests
N/A - This is a native rendering change that doesn't depend on network state.
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
N/A - patch only affects native rendering
iOS: Native
iOS: mWeb Safari
N/A - patch only affects native rendering
MacOS: Chrome / Safari
N/A - patch only affects native rendering