fix: borderRadius incorrectly drawn in headings#93594
Conversation
|
|
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 335ac434bc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7fb996bbb2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Thanks for waiting. I had to upgrade mac and xcode for local ios build. I do not have access to Adhoc at the moment. I will be testing it shortly |
Explanation of Change
Follow-up fix to #84556 (nested
<Text>borderRadius). On iOS, a mention's rounded background inside a heading rendered wider than the text, bleeding past it.Cause: the iOS path (
RCTTextLayoutManagerWithBorderRadius) took the rect width fromboundingRectForGlyphRange, whose trailing-whitespace/advance slack scales with font size. Fix: derive the horizontal extent from caret positions (locationForGlyphAtIndex), mirroring Android.Fixed Issues
$ #78873
PROPOSAL:
Tests
# abcd @here abcd.@herehugs the mention text and does not extend past it into the space before the next word.Hello @here, and a heading long enough that a mention wraps to a second line; verify that backgrounds stay tight around the text and multiline spans round only the outer corners (left on the first line, right on the last).Offline tests
N/A — mention rendering is local and does not depend on network state.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari