Add QBD Travel Invoicing payable account selector#88606
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@brunovjk dropping a coordination note from the IS side at https://github.com/Expensify/Integration-Server/pull/8922. For the QBD Travel payable account picker, source the dropdown from the same QBD synced accounts list that the IS exporter's For the Travel vendor picker, same idea, source from the QBD synced vendors list the IS exporter's ping if anything's unclear! |
|
@inimaga I don't think we need your review here, @rlinoz and @allgandalf are going to. Cc: @blimpich |
|
@allgandalf curious for your review on this |
|
@blimpich I addressed the QBD travel vendor feedback by removing the QBD travel vendor selector/route/config row/constant/setter and keeping only the payable account flow. For the payable account setter, I kept the existing |
on it nowww |
|
Implemented the update to use the dedicated command. I also updated the PR description and tests accordingly. Please let me know if I've missed anything.
@rlinoz This PR should be ready for review, but I’m currently unable to fully test it because we’re blocked from connecting to the QBD test environment until Rightworks restores access. cc: @blimpich |
|
Looks like we're close to being able to test here again? @brunovjk can you check? https://expensify.slack.com/archives/C9YU7BX5M/p1779307496491309?thread_ts=1778607693.575199&cid=C9YU7BX5M |
|
I got the same error when trying to connect to QBD with "Microsoft Remote Desktop": @blimpich I followed the steps on 1password, do you know if I need to do something different? Thank you. |
|
Okay we should be good to test with QBD now. @brunovjk can you try again? |
|
Update: I'm still connecting QBD to my account, I'll review it ASAP. |
|
@brunovjk were you able to test ? |
|
Yes, Im completing the checklist now |
|
@allgandalf the PR is ready for review now. Do you have an account with QBD connected and a "payable account" available? We need to test this PR. Thank you. |
allgandalf
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Verify section visibility
- Navigate to the workspace QuickBooks Desktop accounting integration settings page.
- Click Export.
Case A: Travel Invoicing disabled
Verify the Export travel invoice expenses as section is not shown.
Screen.Recording.2026-06-03.at.1.57.02.AM.mov
Case B: Travel Invoicing enabled
Verify the Export travel invoice expenses as section is shown.
Screen.Recording.2026-06-03.at.2.00.23.AM.mov
Verify configuration page contents
- Click Export travel invoice expenses as.
Verify a page opens showing exactly this row:
Travel payable account
Screen.Recording.2026-06-03.at.2.01.50.AM.mov
Verify travel payable account selector
- Click Travel payable account.
Verify a searchable picker (SelectionList) opens and shows available QuickBooks Desktop accounts. - Select a different payable account.
Verify you return to the previous page and Travel payable account shows the selected account.
Navigate back to the Export page.
Verify the Export travel invoice expenses as row reflects the updated configuration.
Screen.Recording.2026-06-03.at.2.02.46.AM.mov
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.3.97-0 🚀
Bundle Size Analysis (Sentry): |
Help site review — changes required ✅This PR adds an Export travel invoicing expenses as option (with a Travel payable account selector) to the QuickBooks Desktop Export settings, shown only when Travel Invoicing is enabled. The QuickBooks Desktop help article had no Travel Invoicing content, even though the equivalent option is already documented for Xero and NetSuite. So a docs update is required to keep the QuickBooks Desktop article consistent. What I changed: Added a short Travel Expenses entry under Step 3: Configure Export Settings in Draft help site PR: #92455 How I verified the UI labelsConfirmed against the translation strings in
These match the menu item and selector added in this PR ( @brunovjk, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.97-1 🚀
|
…port option Mirrors the Travel Invoicing export documentation already present for Xero and NetSuite, reflecting the new QBD selector added in Expensify#88606. Co-authored-by: Bruno Rocha <brunovjk@users.noreply.github.com>

Explanation of Change
Adds the Travel Invoicing configuration section to the QuickBooks Desktop accounting integration settings page, mirroring the existing QuickBooks Online behavior. This PR exposes only the Travel payable account selector for QuickBooks Desktop.
Fixed Issues
$ #88271
PROPOSAL:
Tests
Preconditions
1. Verify section visibility
2. Verify configuration page contents
3. Verify travel payable account selector
SelectionList) opens and shows available QuickBooks Desktop accounts.Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
88606_android_web.mov
iOS: Native
88606_ios_native.mov
iOS: mWeb Safari
88606_ios_web.mov
MacOS: Chrome / Safari
88606_web_chrome.mov