Skip to content

Add QBD Travel Invoicing payable account selector#88606

Merged
blimpich merged 13 commits into
Expensify:mainfrom
brunovjk:qbd-travel-invoicing-selectors
Jun 2, 2026
Merged

Add QBD Travel Invoicing payable account selector#88606
blimpich merged 13 commits into
Expensify:mainfrom
brunovjk:qbd-travel-invoicing-selectors

Conversation

@brunovjk

@brunovjk brunovjk commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Adds the Travel Invoicing configuration section to the QuickBooks Desktop accounting integration settings page, mirroring the existing QuickBooks Online behavior. This PR exposes only the Travel payable account selector for QuickBooks Desktop.

Fixed Issues

$ #88271
PROPOSAL:

Tests

Preconditions

  • Workspace has QuickBooks Desktop accounting integration enabled
  • Travel Invoicing beta and the feature should both be enabled (Central Invoicing ON)

1. Verify section visibility

  1. Navigate to the workspace QuickBooks Desktop accounting integration settings page.
  2. Click Export.
  3. Case A: Travel Invoicing disabled
    • Verify the Export travel invoice expenses as section is not shown.
  4. Case B: Travel Invoicing enabled
    • Verify the Export travel invoice expenses as section is shown.

2. Verify configuration page contents

  1. Click Export travel invoice expenses as.
  2. Verify a page opens showing exactly this row:
    • Travel payable account

3. Verify travel payable account selector

  1. Click Travel payable account.
  2. Verify a searchable picker (SelectionList) opens and shows available QuickBooks Desktop accounts.
  3. Select a different payable account.
  4. Verify you return to the previous page and Travel payable account shows the selected account.
  5. Navigate back to the Export page.
  6. Verify the Export travel invoice expenses as row reflects the updated configuration.
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline.
  2. Open Export > Export travel invoice expenses as.
  3. Change Travel payable account.
  4. Verify the new value is applied optimistically and a pending/offline state is shown.
  5. Go back online.
  6. Verify the pending state disappears and the selected value remains.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
88606_android_web.mov
iOS: Native
88606_ios_native.mov
iOS: mWeb Safari
88606_ios_web.mov
MacOS: Chrome / Safari
88606_web_chrome.mov

@codecov

codecov Bot commented Apr 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 93.84% <ø> (ø)
src/ROUTES.ts 18.80% <ø> (ø)
src/SCREENS.ts 100.00% <ø> (ø)
src/libs/API/types.ts 100.00% <ø> (ø)
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts 100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts 76.92% <ø> (ø)
src/libs/actions/connections/QuickbooksDesktop.ts 12.72% <100.00%> (+12.72%) ⬆️
...common/TravelInvoicingPayableAccountSelectPage.tsx 0.00% <0.00%> (ø)
...ounting/common/TravelInvoicingVendorSelectPage.tsx 0.00% <0.00%> (ø)
...gation/AppNavigator/ModalStackNavigators/index.tsx 6.91% <0.00%> (-0.02%) ⬇️
... and 3 more
... and 8 files with indirect coverage changes

@allgandalf

Copy link
Copy Markdown
Contributor

@brunovjk dropping a coordination note from the IS side at https://github.com/Expensify/Integration-Server/pull/8922.

For the QBD Travel payable account picker, source the dropdown from the same QBD synced accounts list that the IS exporter's getExportToAccountID validates against. Otherwise we'd hit the Bank Accounts vs Credit Cards mismatch ishpaul flagged on Sage.

For the Travel vendor picker, same idea, source from the QBD synced vendors list the IS exporter's getOrCreateVendor reads from.

ping if anything's unclear!

@brunovjk brunovjk marked this pull request as ready for review May 13, 2026 13:38
@brunovjk brunovjk requested review from a team as code owners May 13, 2026 13:38
@melvin-bot melvin-bot Bot requested review from inimaga and joekaufmanexpensify and removed request for a team May 13, 2026 13:38
@melvin-bot

melvin-bot Bot commented May 13, 2026

Copy link
Copy Markdown

@inimaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@brunovjk

Copy link
Copy Markdown
Contributor Author

@inimaga I don't think we need your review here, @rlinoz and @allgandalf are going to.

Cc: @blimpich

Comment thread src/libs/actions/connections/QuickbooksDesktop.ts Outdated
@blimpich

Copy link
Copy Markdown
Contributor

@allgandalf curious for your review on this

@brunovjk

Copy link
Copy Markdown
Contributor Author

@blimpich I addressed the QBD travel vendor feedback by removing the QBD travel vendor selector/route/config row/constant/setter and keeping only the payable account flow.

For the payable account setter, I kept the existing UpdateManyPolicyConnectionConfigs command per the follow-up here. I can update it to UpdateQuickbooksDesktopTravelInvoicingPayableAccount once the corresponding Web PR is merged/available in prod.

@allgandalf

Copy link
Copy Markdown
Contributor

@allgandalf curious for your review on this

on it nowww

@brunovjk

Copy link
Copy Markdown
Contributor Author

Implemented the update to use the dedicated command. I also updated the PR description and tests accordingly. Please let me know if I've missed anything.

Hey @brunovjk is this WIP or ready for review?

@rlinoz This PR should be ready for review, but I’m currently unable to fully test it because we’re blocked from connecting to the QBD test environment until Rightworks restores access.

cc: @blimpich

@blimpich

Copy link
Copy Markdown
Contributor

Looks like we're close to being able to test here again? @brunovjk can you check? https://expensify.slack.com/archives/C9YU7BX5M/p1779307496491309?thread_ts=1778607693.575199&cid=C9YU7BX5M

@brunovjk

Copy link
Copy Markdown
Contributor Author

I got the same error when trying to connect to QBD with "Microsoft Remote Desktop":
Screenshot 2026-05-22 at 10 09 19

@blimpich I followed the steps on 1password, do you know if I need to do something different? Thank you.

@blimpich

Copy link
Copy Markdown
Contributor

Okay we should be good to test with QBD now. @brunovjk can you try again?

@brunovjk

Copy link
Copy Markdown
Contributor Author

Update: I'm still connecting QBD to my account, I'll review it ASAP.

@blimpich blimpich changed the title [WIP] - Add QBD Travel Invoicing ventopr and payable account selector [WIP] - Add QBD Travel Invoicing payable account selector May 29, 2026
@allgandalf

Copy link
Copy Markdown
Contributor

@brunovjk were you able to test ?

@brunovjk

brunovjk commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

Yes, Im completing the checklist now

@brunovjk

brunovjk commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

@allgandalf the PR is ready for review now. Do you have an account with QBD connected and a "payable account" available? We need to test this PR. Thank you.

@blimpich blimpich changed the title [WIP] - Add QBD Travel Invoicing payable account selector Add QBD Travel Invoicing payable account selector Jun 1, 2026

@allgandalf allgandalf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Verify section visibility

  1. Navigate to the workspace QuickBooks Desktop accounting integration settings page.
  2. Click Export.
    Case A: Travel Invoicing disabled
    Verify the Export travel invoice expenses as section is not shown.
Screen.Recording.2026-06-03.at.1.57.02.AM.mov

Case B: Travel Invoicing enabled
Verify the Export travel invoice expenses as section is shown.

Screen.Recording.2026-06-03.at.2.00.23.AM.mov

Verify configuration page contents

  1. Click Export travel invoice expenses as.

Verify a page opens showing exactly this row:
Travel payable account

Screen.Recording.2026-06-03.at.2.01.50.AM.mov

Verify travel payable account selector

  1. Click Travel payable account.
    Verify a searchable picker (SelectionList) opens and shows available QuickBooks Desktop accounts.
  2. Select a different payable account.
    Verify you return to the previous page and Travel payable account shows the selected account.
    Navigate back to the Export page.
    Verify the Export travel invoice expenses as row reflects the updated configuration.
Screen.Recording.2026-06-03.at.2.02.46.AM.mov

@blimpich blimpich merged commit 85844ee into Expensify:main Jun 2, 2026
33 of 35 checks passed
@OSBotify

OSBotify commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

🚧 @blimpich has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.3.97-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site review — changes required ✅

This PR adds an Export travel invoicing expenses as option (with a Travel payable account selector) to the QuickBooks Desktop Export settings, shown only when Travel Invoicing is enabled.

The QuickBooks Desktop help article had no Travel Invoicing content, even though the equivalent option is already documented for Xero and NetSuite. So a docs update is required to keep the QuickBooks Desktop article consistent.

What I changed: Added a short Travel Expenses entry under Step 3: Configure Export Settings in Configure-QuickBooks-Desktop.md, mirroring the existing Xero wording and using the exact UI labels (Export travel invoicing expenses as, Travel payable account).

Draft help site PR: #92455

How I verified the UI labels

Confirmed against the translation strings in src/languages/en.ts:

  • workspace.common.travelInvoicingExport travel invoicing expenses as
  • workspace.common.travelInvoicingPayableAccountTravel payable account

These match the menu item and selector added in this PR (DynamicQuickbooksDesktopExportPage.tsx and QuickbooksDesktopTravelInvoicingConfigurationPage.tsx). The feature is gated behind the TRAVEL_INVOICING beta, so it isn't testable in the live UI yet — the en.ts strings are the authoritative source for the labels.


@brunovjk, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

@OSBotify

OSBotify commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.97-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

truph01 pushed a commit to truph01/App that referenced this pull request Jun 5, 2026
…port option

Mirrors the Travel Invoicing export documentation already present for Xero
and NetSuite, reflecting the new QBD selector added in Expensify#88606.

Co-authored-by: Bruno Rocha <brunovjk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants