Update personal card details UI by ShridharGoel · Pull Request #89396 · Expensify/App

ShridharGoel · 2026-05-01T14:44:49Z

Explanation of Change

Updated the personal card details page to match the finalized Figma layouts:

Moved the cardholder name onto the card artwork.
Centered the last updated text above the action buttons.
Used the shared card details action button helper for the personal-card action buttons.
Matched the personal card broken-connection error row spacing.
Updated the Fix card action to use the small danger button style.
Kept the card details rows in the Figma order.
Removed the extra gap between the PIN row and the next card menu item by grouping the menu rows under one top margin.

Fixed Issues

$ #87497
PROPOSAL: N/A

Tests

Open the personal card details page from Wallet.
Verify the cardholder name is shown inside the card artwork.
Verify the last updated text is centered above the action buttons.
Verify Update card and View transactions are shown as equal-width action buttons.
Open a personal card with a broken connection.
Verify the broken connection message appears below the action buttons.
Verify Fix card is shown as a small danger button.
Verify the card number, reimbursable setting, transaction start date, and remove card rows match the Figma order.
Verify that no errors appear in the JS console.

Verify that no errors appear in the JS console

Offline tests

Open the personal card details page.
Turn off the network connection.
Verify disabled card action buttons stay disabled where needed.
Verify the page layout stays the same.

QA Steps

Open the personal card details page from Wallet.
Verify the cardholder name is shown inside the card artwork.
Verify the last updated text is centered above the action buttons.
Verify Update card and View transactions are shown as equal-width action buttons.
Open a personal card with a broken connection.
Verify the broken connection message appears below the action buttons.
Verify Fix card is shown as a small danger button.
Verify the card number, reimbursable setting, transaction start date, and remove card rows match the Figma order.
Verify that no errors appear in the JS console.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-05-01T14:55:40Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/FrozenCardHeader.tsx	`0.00% <ø> (ø)`
...e/companyCards/WorkspaceCompanyCardDetailsPage.tsx	`0.00% <ø> (ø)`
...xpensifyCard/WorkspaceExpensifyCardDetailsPage.tsx	`0.00% <ø> (ø)`
.../settings/Wallet/PersonalCardDetailsHeaderMenu.tsx	`0.00% <0.00%> (ø)`
.../pages/settings/Wallet/ExpensifyCardPage/index.tsx	`73.40% <47.36%> (ø)`
.../pages/settings/Wallet/PersonalCardDetailsPage.tsx	`0.00% <0.00%> (ø)`
... and 10 files with indirect coverage changes

…CardUI # Conflicts: # src/pages/settings/Wallet/ExpensifyCardPage/index.tsx

melvin-bot · 2026-05-20T21:07:43Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify · 2026-05-21T01:22:00Z

Switching @flaviadefaria on for the product review.

Pujan92 · 2026-05-21T13:59:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Pujan92 · 2026-05-21T14:00:24Z

@ShridharGoel can we bring the changes of #91230 here in a single PR?

flaviadefaria · 2026-05-27T16:10:11Z

For visibility, this is now blocking two other projects, so @ShridharGoel, we'd really appreciate it if you could prioritize fixing these issues. Let me know if I can help in any way.

ShridharGoel · 2026-05-27T17:05:09Z

Updated

flaviadefaria · 2026-05-28T09:19:34Z

@ShridharGoel is this ready for review? One of our internal engineers also wants to help review the PR so I'll assign him once you're ready.

ShridharGoel · 2026-05-28T09:57:44Z

Yes it's ready

Pujan92

LGTM!

#89379 (comment) -- Fixed

#91138 - Fixed

Screen.Recording.2026-05-28.at.16.55.24.mov

Copilot

Pull request overview

Refreshes the personal card details page to match the finalized Figma layouts: the cardholder name is rendered on the card artwork, last-updated text is centered above the action buttons, the shared CardDetailsActionButtons helper now drives the Update card / View transactions buttons, the broken-connection error row is restyled with a small danger "Fix card" button, and the menu rows below are grouped under a single top margin. The PR also drops redundant iconFill={theme.icon} props and the now-unused useTheme imports across several card-detail pages, and moves the Change PIN row in ExpensifyCardPage into the lower action-rows group.

Changes:

Restructure PersonalCardDetailsPage to add the cardholder name overlay, centered last-updated text, shared action buttons, and a redesigned broken-connection row.
Slim down PersonalCardDetailsHeaderMenu by removing the update/view-transactions/last-updated rows (now lifted to the parent) and grouping the remaining rows under a single mt4 wrapper.
Remove unused useTheme/iconFill={theme.icon} props across several card pages, and regroup the Change PIN row inside ExpensifyCardPage under the bottom action-rows section.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/pages/settings/Wallet/PersonalCardDetailsPage.tsx	Adds cardholder overlay, centered last-updated text, shared action buttons, restyled broken-connection row, and grouped menu wrapper.
src/pages/settings/Wallet/PersonalCardDetailsHeaderMenu.tsx	Drops update/view-transactions/last-updated rows (now in the parent) and wraps trailing rows in a single `mt4` view.
src/pages/settings/Wallet/ExpensifyCardPage/index.tsx	Moves Change PIN row into the lower action-rows group, removes `useTheme`/`iconFill` props, sets `mb0` on action buttons.
src/pages/workspace/expensifyCard/WorkspaceExpensifyCardDetailsPage.tsx	Removes unused `useTheme` import and `iconFill={theme.icon}` from action buttons.
src/pages/workspace/companyCards/WorkspaceCompanyCardDetailsPage.tsx	Removes unused `useTheme` import and `iconFill={theme.icon}` from action buttons.
src/components/FrozenCardHeader.tsx	Removes unused `useTheme` import and `iconFill={theme.icon}` from the unfreeze button.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…CardUI

github-actions · 2026-05-29T10:18:26Z

🚧 @nkuoch has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-29T10:24:13Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89396.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-bbea63328d9-04e63f5-1b165335c5a66a33659b3a762bac0b1a05fc51ff/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-bbea633-04e63f5-ce71bc76a1e4f75bf5e2238a21b15bab017ff032/index.html

Web 🕸️
https://89396.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-29T10:28:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-06-01T10:20:21Z

🚀 Deployed to staging by https://github.com/nkuoch in version: 9.3.90-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-01T10:22:53Z

🤖 Help site review: no doc changes required.

I reviewed the changes in this PR against the help site articles under docs/articles. This PR is a purely visual/layout refinement to match the finalized Figma layouts for the personal card details page — it does not add, remove, or change any feature, behavior, copy string, or user flow.

The only article that documents this screen is Manage-Personal-Cards.md, and every behavior it documents remains accurate:

Documented action	Status after this PR
Fix card (fix broken connection)	Still present — restyled as a small danger button, same action
Update card (manual refresh)	Still present — moved into the shared action-button row
View transactions	Still present — equal-width action button
Rename card / Mark transactions as reimbursable toggle	Unchanged
Remove / unassign card	Unchanged
Last successful import ("last updated") info	Still shown — now centered above the action buttons

Why no changes are needed

The changes here are layout-only: cardholder name moved onto the card artwork, the "last updated" line centered, action buttons unified via the shared CardDetailsActionButtons helper, the broken-connection error row re-spaced, Fix card restyled, and card-detail rows reordered to match Figma. None of these alter what a user can do on the page.

The help article describes the page in terms of the actions available (steps like "Choose Fix card", "tap Update card"), not the visual arrangement or positioning of those elements. Since all of those actions and their labels are preserved, the article text stays correct. The article's screenshots are illustrative and are already tracked separately for a design refresh (see the existing SCREENSHOT/Design-request placeholder in the file), so they're out of scope for a markdown docs PR.

ShridharGoel — no draft docs PR was created because no help site copy changes are needed for this layout update. If you believe a screenshot refresh or wording tweak is warranted, let me know which behavior changed and I'll prepare a docs PR.

jponikarchuk · 2026-06-01T12:54:26Z

Deploy Blocker #92228 was identified to be related to this PR.

OSBotify · 2026-06-02T06:02:56Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.90-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot Bot assigned ShridharGoel May 1, 2026

ShridharGoel changed the title ~~Align personal card details with Figma~~ Update personal card details UI May 1, 2026

flaviadefaria mentioned this pull request May 12, 2026

[Due for payment 2026-06-09] Improve UX/UI for card details page #87497

Closed

ShridharGoel force-pushed the personalCardUI branch 5 times, most recently from ce85009 to b3c82da Compare May 19, 2026 22:14

Align personal card details with Figma

0e644df

ShridharGoel force-pushed the personalCardUI branch from b3c82da to 0e644df Compare May 19, 2026 22:16

ShridharGoel mentioned this pull request May 20, 2026

Update Expensify card UI #89379

Merged

52 tasks

ShridharGoel added 5 commits May 21, 2026 02:06

Merge branch 'main' of https://github.com/Expensify/App into personal…

74bf036

…CardUI # Conflicts: # src/pages/settings/Wallet/ExpensifyCardPage/index.tsx

Adjust card details menu spacing

e3fcebf

Add spacing before change PIN action

04e7ea8

Group card action row spacing

69b293d

Group personal card action row spacing

6f4cee5

ShridharGoel marked this pull request as ready for review May 20, 2026 21:07

ShridharGoel requested review from a team as code owners May 20, 2026 21:07

melvin-bot Bot requested review from Pujan92 and trjExpensify and removed request for a team May 20, 2026 21:07

trjExpensify requested review from flaviadefaria and removed request for trjExpensify May 21, 2026 01:21

Merge upstream main and update card button icon fills

4c8d97b

Pujan92 approved these changes May 28, 2026

View reviewed changes

melvin-bot Bot requested a review from nkuoch May 28, 2026 11:31

Pujan92 mentioned this pull request May 28, 2026

Remove iconFill={theme.icon} from card action buttons in high contrast mode #91230

Closed

30 tasks

nkuoch requested a review from Copilot May 28, 2026 11:34

Copilot started reviewing on behalf of nkuoch May 28, 2026 11:34 View session

Copilot AI reviewed May 28, 2026

View reviewed changes

Comment thread src/pages/settings/Wallet/PersonalCardDetailsPage.tsx Outdated

Remove redundant iconFill from personal card action buttons

a99ab63

ShridharGoel force-pushed the personalCardUI branch from df7d65f to a99ab63 Compare May 28, 2026 13:06

ShridharGoel requested a review from Pujan92 May 28, 2026 13:07

Merge branch 'main' of https://github.com/Expensify/App into personal…

257bb34

…CardUI

Pujan92 approved these changes May 28, 2026

View reviewed changes

nkuoch approved these changes May 29, 2026

View reviewed changes

nkuoch merged commit bbea633 into Expensify:main May 29, 2026
37 checks passed

OSBotify mentioned this pull request Jun 1, 2026

Deploy Checklist: New Expensify 2026-06-01 #92180

Closed

69 tasks

Pujan92 mentioned this pull request Jun 1, 2026

Expensify Card-Freeze card button icon shows hover effect when disabled in high contrast mode #91138

Closed

7 tasks

applause-bot Bot mentioned this pull request Jun 1, 2026

[Due for payment 2026-06-09] [Due for payment 2026-06-09] [$250] Wallet - Imported card name shows Hidden instead of user display name #92228

Closed

7 tasks

lakchote mentioned this pull request Jun 1, 2026

[CP Staging] Revert "Update personal card details UI" #92240

Closed

JS00001 mentioned this pull request Jun 2, 2026

Cleanup card rule details #91858

Merged

54 tasks

Conversation

ShridharGoel commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 1, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented May 20, 2026

Uh oh!

trjExpensify commented May 21, 2026

Uh oh!

Pujan92 commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Pujan92 commented May 21, 2026

Uh oh!

flaviadefaria commented May 27, 2026

Uh oh!

ShridharGoel commented May 27, 2026

Uh oh!

flaviadefaria commented May 28, 2026

Uh oh!

ShridharGoel commented May 28, 2026

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 29, 2026

Uh oh!

github-actions Bot commented May 29, 2026

Uh oh!

OSBotify commented May 29, 2026

Uh oh!

OSBotify commented Jun 1, 2026

Uh oh!

MelvinBot commented Jun 1, 2026

Uh oh!

jponikarchuk commented Jun 1, 2026

Uh oh!

OSBotify commented Jun 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

ShridharGoel commented May 1, 2026 •

edited

Loading

codecov Bot commented May 1, 2026 •

edited by github-actions Bot

Loading

Pujan92 commented May 21, 2026 •

edited

Loading