Remove iconFill={theme.icon} from card action buttons in high contrast mode#91230
Closed
MelvinBot wants to merge 1 commit into
Closed
Remove iconFill={theme.icon} from card action buttons in high contrast mode#91230MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
In high contrast mode, theme.icon and the Button component's default
icon fill (theme.textLight) have different values. Passing
iconFill={theme.icon} overrides the Button's built-in fill logic,
causing visible hover effects on disabled buttons (e.g., the Freeze
card button). Removing this prop lets the Button component use its
own fill which correctly handles hover and disabled states.
Co-authored-by: Pujan Shah <Pujan92@users.noreply.github.com>
52 tasks
Contributor
|
@MelvinBot you can close this PR as these changes are added here |
Contributor
Author
|
Closed as requested by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
In high contrast mode,
theme.iconand the Button component's default icon fill (theme.textLight) have different color values. PR #89379 addediconFill={theme.icon}to several card action buttons, which overrides the Button's built-in fill logic. This causes a visible hover effect on disabled buttons (e.g., the Freeze card button) because the icon color switches fromtheme.icontotheme.buttonIconon hover without checking the disabled state.This PR removes all
iconFill={theme.icon}props added in that PR, letting the Button component use its own default fill which correctly handles hover and disabled states across all theme modes.Fixed Issues
$ #91138
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
Offline tests
// TODO: The human co-author must fill out offline tests before marking this PR as "ready for review"
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followed