added Avatar column to Report table column selector#89421
Merged
Conversation
Other languages will be auto-filled by the generateTranslations workflow.
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
melvin-bot
Bot
requested review from
inimaga and
joekaufmanexpensify
and removed request for
a team
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 298b6004c4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
Author
|
@inimaga could you pls help here to run translations for other languages? thanks! |
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 142d4486..53cd8416 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -498,6 +498,7 @@ const translations: TranslationDeepObject<typeof en> = {
nextMonth: 'Nächster Monat',
previousYear: 'Vorheriges Jahr',
nextYear: 'Nächstes Jahr',
+ avatar: 'Avatar',
},
socials: {
podcast: 'Folgen Sie uns auf Podcast',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 6f6122bb..60b7a7b9 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -498,6 +498,7 @@ const translations: TranslationDeepObject<typeof en> = {
nextMonth: 'Le mois prochain',
previousYear: 'Année précédente',
nextYear: 'L’an prochain',
+ avatar: 'Avatar',
},
socials: {
podcast: 'Suivez-nous sur Podcast',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index a237681a..99183fd9 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -498,6 +498,7 @@ const translations: TranslationDeepObject<typeof en> = {
nextMonth: 'Il prossimo mese',
previousYear: 'Anno precedente',
nextYear: "L'anno prossimo",
+ avatar: 'Avatar',
},
socials: {
podcast: 'Seguici su Podcast',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 5292a3f4..852df682 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -497,6 +497,7 @@ const translations: TranslationDeepObject<typeof en> = {
nextMonth: '来月',
previousYear: '前年',
nextYear: '来年',
+ avatar: 'アバター',
},
socials: {
podcast: 'ポッドキャストでフォロー',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index f74f432e..5ae1caa4 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -497,6 +497,7 @@ const translations: TranslationDeepObject<typeof en> = {
nextMonth: 'Volgende maand',
previousYear: 'Vorig jaar',
nextYear: 'Volgend jaar',
+ avatar: 'Avatar',
},
socials: {
podcast: 'Volg ons op Podcast',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 99a2805a..fff88118 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -497,6 +497,7 @@ const translations: TranslationDeepObject<typeof en> = {
nextMonth: 'W przyszłym miesiącu',
previousYear: 'Poprzedni rok',
nextYear: 'W przyszłym roku',
+ avatar: 'Avatar',
},
socials: {
podcast: 'Śledź nas na Podcast',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 93cf7fa8..60f3ed40 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -496,6 +496,7 @@ const translations: TranslationDeepObject<typeof en> = {
nextMonth: 'Próximo mês',
previousYear: 'Ano anterior',
nextYear: 'Ano que vem',
+ avatar: 'Avatar',
},
socials: {
podcast: 'Siga-nos no Podcast',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index e90e1ce7..e44cdb8c 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -493,6 +493,7 @@ const translations: TranslationDeepObject<typeof en> = {
nextMonth: '下个月',
previousYear: '上一年',
nextYear: '明年',
+ avatar: '头像',
},
socials: {
podcast: '在播客上关注我们',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
7 tasks
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Contributor
|
🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Contributor
|
Tests pretty well on my end 👍 |
joekaufmanexpensify
approved these changes
May 4, 2026
joekaufmanexpensify
left a comment
joekaufmanexpensify
left a comment
Contributor
There was a problem hiding this comment.
Good for product!
Contributor
Author
|
@eVoloshchak kindly bump 😊 |
Contributor
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / SafariScreen.Recording.2026-05-08.at.11.30.08.mov |
inimaga
approved these changes
May 8, 2026
Contributor
|
🚧 @inimaga has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/inimaga in version: 9.3.69-0 🚀
Bundle Size Analysis (Sentry): |
2 tasks
Contributor
|
Yes, help site changes are required. PR #89421 makes the Avatar column toggleable in the Report table column selector, but the help site article (Using-Reports-in-New-Expensify.md) didn't list Avatar as an available column. I've created a draft PR to add it: #90017 The change adds Avatar to the list of customizable columns in the "How to customize the Spend column view" section. The |
Contributor
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.69-18 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #84393
PROPOSAL:
Tests
Prerequisites: account with multiple reports
type:expense-reportviews andgroup-by:fromAvataroption in column selectorOffline tests
QA Steps
The same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
this is desktop specific featureAndroid: mWeb Chrome
this is desktop specific featureiOS: Native
this is desktop specific featureiOS: mWeb Safari
this is desktop specific featureMacOS: Chrome / Safari