-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[No QA] [Bulk workspace edits] Scaffold Copy Policy Settings RHP flow #89959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
francoisl
merged 9 commits into
Expensify:main
from
fedirjh:copy-policy-settings-scaffold
May 8, 2026
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3ffaece
Add Copy Policy Settings routes and screen names
fedirjh a6a4e32
Add PolicyCopySettingsNavigatorParamList nav type
fedirjh 1cf07a9
Register PolicyCopySettings modal stack navigator
fedirjh f8ace97
Wire Copy Policy Settings into linking config and RHP relations
fedirjh 0f316f4
Add COPY_POLICY_SETTINGS Onyx key and CopyPolicySettings type
fedirjh 0ea35ad
Add CopyPolicySettings API params and write commands
fedirjh bdb8476
Merge branch 'Expensify:main' into copy-policy-settings-scaffold
fedirjh 3dd7ce8
Use named type import in CopyPolicySettings
fedirjh 16658f4
Merge branch 'Expensify:main' into copy-policy-settings-scaffold
fedirjh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| type CopyPolicySettingsParams = { | ||
| sourcePolicyID: string; | ||
|
|
||
| /** CSV list of target policy IDs to copy settings into */ | ||
| policyIDList: string; | ||
|
|
||
| /** CSV list of feature keys to copy */ | ||
| parts: string; | ||
| }; | ||
|
|
||
| export default CopyPolicySettingsParams; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
src/pages/workspace/copyPolicySettings/CopyPolicySettingsConfirmPage.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| function CopyPolicySettingsConfirmPage() { | ||
| return null; | ||
| } | ||
|
|
||
| CopyPolicySettingsConfirmPage.displayName = 'CopyPolicySettingsConfirmPage'; | ||
|
|
||
| export default CopyPolicySettingsConfirmPage; |
7 changes: 7 additions & 0 deletions
7
src/pages/workspace/copyPolicySettings/CopyPolicySettingsSelectFeaturesPage.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| function CopyPolicySettingsSelectFeaturesPage() { | ||
| return null; | ||
| } | ||
|
|
||
| CopyPolicySettingsSelectFeaturesPage.displayName = 'CopyPolicySettingsSelectFeaturesPage'; | ||
|
|
||
| export default CopyPolicySettingsSelectFeaturesPage; |
7 changes: 7 additions & 0 deletions
7
src/pages/workspace/copyPolicySettings/CopyPolicySettingsSelectWorkspacesPage.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| function CopyPolicySettingsSelectWorkspacesPage() { | ||
| return null; | ||
| } | ||
|
|
||
| CopyPolicySettingsSelectWorkspacesPage.displayName = 'CopyPolicySettingsSelectWorkspacesPage'; | ||
|
|
||
| export default CopyPolicySettingsSelectWorkspacesPage; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import type {Errors} from './OnyxCommon'; | ||
|
|
||
| /** Onyx state of the Copy Policy Settings (bulk workspace edits) flow */ | ||
| type CopyPolicySettings = { | ||
| /** The source policy ID we're copying settings FROM */ | ||
| sourcePolicyID?: string; | ||
|
|
||
| /** The list of target policy IDs we're copying settings TO */ | ||
| targetPolicyIDs?: string[]; | ||
|
|
||
| /** Which feature parts are selected for copying */ | ||
| parts?: string[]; | ||
|
|
||
| /** | ||
| * Which step of the copy is happening in the backend | ||
| * - `loading`: copy in progress | ||
| * - `complete`: backend finished | ||
| * - undefined: copy hasn't started yet (e.g. user is still selecting features) | ||
| */ | ||
| currentStep?: 'loading' | 'complete' | undefined; | ||
|
|
||
| /** Error state */ | ||
| errors?: Errors; | ||
| }; | ||
|
|
||
| export default CopyPolicySettings; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.