[No QA] [Bulk workspace edits] Scaffold Copy Policy Settings RHP flow by fedirjh · Pull Request #89959 · Expensify/App

fedirjh · 2026-05-07T18:41:10Z

Explanation of Change

Scaffolds the declarative plumbing for the new "Copy configuration" RHP flow that's part of the Bulk workspace edits project. No UI is wired up yet — every page component is an empty stub. Subsequent issues in the project will fill them in.

This PR introduces:

Routes (src/ROUTES.ts): POLICY_COPY_SETTINGS, POLICY_COPY_SETTINGS_SELECT_FEATURES, POLICY_COPY_SETTINGS_CONFIRM.
Screen names (src/SCREENS.ts): POLICY_COPY_SETTINGS.{ROOT, SELECT_FEATURES, CONFIRM} plus RIGHT_MODAL.POLICY_COPY_SETTINGS.
Navigation types (src/libs/Navigation/types.ts): PolicyCopySettingsNavigatorParamList, registered in RightModalNavigatorParamList.
Modal stack navigator (src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx): PolicyCopySettingsModalStackNavigator wired to three stub pages, registered in RightModalNavigator.tsx.
Linking config (src/libs/Navigation/linkingConfig/config.ts): entry for SCREENS.RIGHT_MODAL.POLICY_COPY_SETTINGS.
RHP relations (src/libs/Navigation/linkingConfig/RELATIONS/WORKSPACES_LIST_TO_RHP.ts): new screens added so the RHP slides over the Workspaces list during in-app navigation, deep links, and refreshes.
Onyx key + type (src/ONYXKEYS.ts, src/types/onyx/CopyPolicySettings.ts): new COPY_POLICY_SETTINGS key and CopyPolicySettings type, including currentStep: 'loading' | 'complete' | undefined.
API types (src/libs/API/parameters/CopyPolicySettingsParams.ts, src/libs/API/types.ts): CopyPolicySettingsParams and COPY_POLICY_SETTINGS / COPY_POLICY_SETTINGS_NOTIFY write commands.

The shape mirrors the existing Duplicate Workspace flow (WORKSPACE_DUPLICATE), with adjustments per the design doc sections "[App] New routes, screens, and navigator", "[App] Onyx state for the flow", and "[App] API Types".

Fixed Issues

$ #88667
PROPOSAL: N/A

Tests

Since this PR is pure scaffolding (no user-facing UI), there is nothing to interact with manually. To verify the scaffolding is wired correctly:

Navigate to /policy/<any-policyID>/copy-settings — the URL should resolve to an empty RHP (the stub page) without crashing.

Verify that no errors appear in the JS console

Offline tests

N/A — no runtime behavior is added in this PR. Offline behavior will be implemented and tested in the issues that follow.

QA Steps

This PR contains no user-facing changes and ships behind no UI entry point. The "Copy configuration" three-dot menu item that exposes this flow lands in a follow-up issue.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

N/A

iOS: Native

N/A

iOS: mWeb Safari

N/A

MacOS: Chrome / Safari

N/A

Declares POLICY_COPY_SETTINGS, POLICY_COPY_SETTINGS_SELECT_FEATURES, POLICY_COPY_SETTINGS_CONFIRM routes plus the matching screen name constants and RIGHT_MODAL.POLICY_COPY_SETTINGS entry. First slice of scaffolding for the bulk workspace edits flow.

Defines the param list for the new RHP flow (ROOT, SELECT_FEATURES, CONFIRM) and registers it in RightModalNavigatorParamList.

Adds PolicyCopySettingsModalStackNavigator wired to three stub page components and registers it on RightModalNavigator under SCREENS.RIGHT_MODAL.POLICY_COPY_SETTINGS. Pages are intentionally empty and will be filled in by the follow-up issues.

Maps the three new routes to their screens in linkingConfig and adds them to WORKSPACES_LIST_TO_RHP so the RHP slides over the Workspaces list during in-app navigation, deep links, and refreshes.

Adds the new Onyx key copyPolicySettings and its type definition, including currentStep ('loading' | 'complete' | undefined) which drives the progress modal state in later issues.

Defines CopyPolicySettingsParams (sourcePolicyID, policyIDList, parts) and registers COPY_POLICY_SETTINGS and COPY_POLICY_SETTINGS_NOTIFY in WRITE_COMMANDS so the action layer can call them in later issues.

codecov · 2026-05-07T18:59:19Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
src/SCREENS.ts	`100.00% <ø> (ø)`
src/libs/API/types.ts	`100.00% <ø> (ø)`
.../linkingConfig/RELATIONS/WORKSPACES_LIST_TO_RHP.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`76.92% <ø> (ø)`
...on/AppNavigator/Navigators/RightModalNavigator.tsx	`0.00% <0.00%> (ø)`
src/ROUTES.ts	`17.09% <0.00%> (-0.05%)`	⬇️
...gation/AppNavigator/ModalStackNavigators/index.tsx	`7.16% <25.00%> (+0.08%)`	⬆️
...pyPolicySettings/CopyPolicySettingsConfirmPage.tsx	`0.00% <0.00%> (ø)`
...ySettings/CopyPolicySettingsSelectFeaturesPage.tsx	`0.00% <0.00%> (ø)`
... and 1 more
... and 12 files with indirect coverage changes

Switches from `import type * as OnyxCommon` to `import type {Errors}` to satisfy the no-restricted-syntax rule that disallows namespace imports from sibling modules.

melvin-bot · 2026-05-07T20:42:53Z

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ShridharGoel · 2026-05-07T21:03:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-05-08T06:04:12Z

🚧 @francoisl has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-08T06:09:41Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89959.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-dbe5a31-16ca8cb-195bdd271bef3ce496cb177cdd8ac7acd58b0097/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-dbe5a31-16ca8cb-647d791d7739c4c85a0fa6d86cbf5c8a1387f43f/index.html

Web 🕸️
https://89959.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-08T06:11:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-08T15:44:10Z

🚀 Deployed to staging by https://github.com/francoisl in version: 9.3.69-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-05-11T23:44:39Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.69-18 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fedirjh added 6 commits May 7, 2026 19:32

Add PolicyCopySettingsNavigatorParamList nav type

a6a4e32

Defines the param list for the new RHP flow (ROOT, SELECT_FEATURES, CONFIRM) and registers it in RightModalNavigatorParamList.

Wire Copy Policy Settings into linking config and RHP relations

f8ace97

Maps the three new routes to their screens in linkingConfig and adds them to WORKSPACES_LIST_TO_RHP so the RHP slides over the Workspaces list during in-app navigation, deep links, and refreshes.

Add COPY_POLICY_SETTINGS Onyx key and CopyPolicySettings type

0f316f4

Adds the new Onyx key copyPolicySettings and its type definition, including currentStep ('loading' | 'complete' | undefined) which drives the progress modal state in later issues.

Add CopyPolicySettings API params and write commands

0ea35ad

Defines CopyPolicySettingsParams (sourcePolicyID, policyIDList, parts) and registers COPY_POLICY_SETTINGS and COPY_POLICY_SETTINGS_NOTIFY in WRITE_COMMANDS so the action layer can call them in later issues.

melvin-bot Bot assigned fedirjh May 7, 2026

fedirjh changed the title ~~Scaffold Copy Policy Settings RHP flow~~ [No QA] [Bulk workspace edits] Scaffold Copy Policy Settings RHP flow May 7, 2026

Merge branch 'Expensify:main' into copy-policy-settings-scaffold

bdb8476

fedirjh mentioned this pull request May 7, 2026

[No QA] [Bulk workspace edits] Add CopyPolicySettings action file and tests #89963

Merged

52 tasks

fedirjh added 2 commits May 7, 2026 21:01

Use named type import in CopyPolicySettings

3dd7ce8

Switches from `import type * as OnyxCommon` to `import type {Errors}` to satisfy the no-restricted-syntax rule that disallows namespace imports from sibling modules.

Merge branch 'Expensify:main' into copy-policy-settings-scaffold

16658f4

fedirjh requested a review from francoisl May 7, 2026 20:42

fedirjh marked this pull request as ready for review May 7, 2026 20:42

fedirjh requested review from a team as code owners May 7, 2026 20:42

melvin-bot Bot requested review from ShridharGoel and joekaufmanexpensify and removed request for a team May 7, 2026 20:42

melvin-bot Bot removed the request for review from a team May 7, 2026 20:42

ShridharGoel approved these changes May 7, 2026

View reviewed changes

ShridharGoel mentioned this pull request May 7, 2026

[Bulk workspace edits] Plumbing: routes, screens, navigator, Onyx key, API types [1] #88667

Closed

francoisl approved these changes May 8, 2026

View reviewed changes

Comment thread src/libs/API/parameters/CopyPolicySettingsParams.ts

francoisl merged commit dbe5a31 into Expensify:main May 8, 2026
43 checks passed

fedirjh deleted the copy-policy-settings-scaffold branch May 8, 2026 12:22

OSBotify mentioned this pull request May 8, 2026

Deploy Checklist: New Expensify 2026-05-08 #90006

Closed

This was referenced May 8, 2026

[Bulk workspace edits] Add Copy Policy Settings select-workspaces page (step 1 of 3) #90079

Merged

[Bulk workspace edits] Add Copy Policy Settings select-features page (step 2 of 3) #90220

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] [Bulk workspace edits] Scaffold Copy Policy Settings RHP flow#89959

[No QA] [Bulk workspace edits] Scaffold Copy Policy Settings RHP flow#89959
francoisl merged 9 commits into
Expensify:mainfrom
fedirjh:copy-policy-settings-scaffold

fedirjh commented May 7, 2026 •

edited

Loading

Uh oh!

codecov Bot commented May 7, 2026 •

edited by github-actions Bot

Loading

Uh oh!

melvin-bot Bot commented May 7, 2026

Uh oh!

ShridharGoel commented May 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 8, 2026

Uh oh!

github-actions Bot commented May 8, 2026

Uh oh!

OSBotify commented May 8, 2026

Uh oh!

OSBotify commented May 8, 2026

Uh oh!

OSBotify commented May 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

fedirjh commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 7, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented May 7, 2026

Uh oh!

ShridharGoel commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 8, 2026

Uh oh!

github-actions Bot commented May 8, 2026

Uh oh!

OSBotify commented May 8, 2026

Uh oh!

OSBotify commented May 8, 2026

Uh oh!

OSBotify commented May 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fedirjh commented May 7, 2026 •

edited

Loading

codecov Bot commented May 7, 2026 •

edited by github-actions Bot

Loading

ShridharGoel commented May 7, 2026 •

edited

Loading