Skip to content

[DB MileageRate] Replace workspace mileage rate list with table UI#90920

Merged
JS00001 merged 30 commits into
Expensify:mainfrom
Krishna2323:krishna/89831-distance-rates-table-ui
Jun 11, 2026
Merged

[DB MileageRate] Replace workspace mileage rate list with table UI#90920
JS00001 merged 30 commits into
Expensify:mainfrom
Krishna2323:krishna/89831-distance-rates-table-ui

Conversation

@Krishna2323

@Krishna2323 Krishna2323 commented May 17, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #89831
PROPOSAL:

Tests

Test 1: Table UI renders correctly

  1. Navigate to a workspace's Distance rates page
  2. Verify the new table UI appears with columns: Status, Name, Rate, Start date, End date, Enabled (toggle), and arrow
  3. Verify rates with no dates show empty Start/End date cells
  4. Verify the Status column shows colored badges (green for Active, blue for Future, orange for Expired, gray for Inactive)

Test 2: Status labels are correct

  1. Create a rate with a future start date — verify it shows a blue "Future" badge
  2. Create a rate with a past end date — verify it shows an orange "Expired" badge
  3. Disable a rate — verify it shows a gray "Inactive" badge
  4. Create a rate with no dates and enabled — verify it shows a green "Active" badge

Test 3: Sorting works

  1. Click each column header and verify sorting toggles between ascending, descending, and reset
  2. Verify status column sorts by priority: Active > Future > Expired > Inactive

Test 4: Selection and bulk actions

  1. Select individual rates via checkboxes and verify the bulk actions dropdown appears
  2. Use the select-all checkbox in the header, verify all rates are selected
  3. Verify Delete, Enable, and Disable bulk actions work correctly
  4. On mobile, long-press a row to enter selection mode, verify it works
  5. Delete the last rate while in selection mode — verify selection mode exits cleanly

Test 5: Narrow layout

  1. Resize to narrow/mobile width
  2. Verify the table collapses to a single-column layout showing: rate name (bold), then status badge + rate + date range (e.g., Active $0.68 / mile • Jun 10, 2026 to Dec 31, 2026)
  3. Verify rates with only a start date show Valid from ..., only end date show Valid until ...
  4. Verify row press navigates to rate details

Test 6: Enabled toggle and read-only

  1. Toggle a rate's enabled switch — verify it updates correctly
  2. Verify the last enabled rate shows a lock icon on its switch and cannot be disabled
  3. As a read-only user, verify the switch shows a lock icon and tapping shows a read-only modal

Test 7: Search

  1. Create at least 12 distance rates
  2. Verify the search bar appears above the table header
  3. Type a rate name (e.g., "Sales") — verify only rates whose name contains "Sales" are shown
  4. Clear the search, type a rate amount (e.g., "0.68") — verify rates matching that formatted rate value are shown
  5. Type a string that matches no rate — verify the table shows an empty state
  6. Clear the search — verify all rates reappear
  • Verify that no errors appear in the JS console

Offline tests

  • Same as tests

QA Steps

  • Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android_hybrid.mp4
Android: mWeb Chrome
android_mWeb.mp4
iOS: Native
ios_hybrid.mp4
iOS: mWeb Safari
ios_mWeb.mp4
MacOS: Chrome / Safari
web_chrome.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@melvin-bot

melvin-bot Bot commented May 17, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@Krishna2323

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bcdd150bdd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/components/Tables/WorkspaceDistanceRatesTable/index.tsx
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…tes table

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 93.84% <ø> (ø)
src/components/Table/Table.tsx 93.33% <100.00%> (ø)
src/components/Table/middlewares/selection.ts 55.00% <100.00%> (+3.21%) ⬆️
src/components/Table/middlewares/sorting.ts 95.00% <100.00%> (+0.26%) ⬆️
...s/workspace/categories/WorkspaceCategoriesPage.tsx 79.31% <ø> (+0.08%) ⬆️
src/styles/variables.ts 100.00% <ø> (ø)
src/libs/PolicyDistanceRatesUtils.ts 7.81% <0.00%> (-1.45%) ⬇️
src/libs/DistanceRequestUtils.ts 86.81% <0.00%> (-4.57%) ⬇️
...orkspace/distanceRates/PolicyDistanceRatesPage.tsx 0.00% <0.00%> (ø)
...tanceRatesTable/WorkspaceDistanceRatesTableRow.tsx 0.00% <0.00%> (ø)
... and 1 more
... and 13 files with indirect coverage changes

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…and date display

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 45570b339e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/PolicyDistanceRatesUtils.ts Outdated
…lity, and formatDate safety

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 23128f369d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/components/Tables/WorkspaceDistanceRatesTable/index.tsx Outdated
@melvin-bot melvin-bot Bot requested a review from neil-marcellini June 11, 2026 17:22
@Krishna2323

Copy link
Copy Markdown
Contributor Author

Please complete the author checklist

Just need to record the native platform videos. I'll do that in about 30 minutes.

JS00001
JS00001 previously approved these changes Jun 11, 2026
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323

Copy link
Copy Markdown
Contributor Author

@JS00001 recordings added

@JS00001

JS00001 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

:shipit:

@JS00001 JS00001 merged commit 38c20d9 into Expensify:main Jun 11, 2026
32 of 33 checks passed
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.6-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #93355 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #93360 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #93391 was identified to be related to this PR.

JS00001 pushed a commit that referenced this pull request Jun 12, 2026
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
JS00001 added a commit that referenced this pull request Jun 12, 2026
[cp staging] Fix distance rates table regressions from #90920
OSBotify pushed a commit that referenced this pull request Jun 12, 2026
[cp staging] Fix distance rates table regressions from #90920

(cherry picked from commit 7d9ecb0)

(cherry-picked to staging by Julesssss)
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.6-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants