[cp staging] Fix distance rates table regressions from #90920 by Krishna2323 · Pull Request #93378 · Expensify/App

Krishna2323 · 2026-06-12T05:02:08Z

Explanation of Change

Fixed Issues

$ #89831
$ #93355
$ #93360
$ #93391

PROPOSAL:

Tests

Test 1

Precondition:
- Enable Distance rates.
- Have at least two distance rates.

Go to staging.new.expensify.com
Go to workspace settings > Distance rates.
Delete any rate.
Verify deleted rate disappears immediately.

Test 2

Precondition:
- Enable Distance rates.
- Have at least 12 distance rates.

Launch Expensify app.
Go to workspace settings > Distance rates.
Long tap on any rate > Select.
Tap on the search field.
Type anything that will not return result.
Verify selection mode persists

Test 3

Prerequisite: Account has a workspace with "Distance Rates" enabled.
Prerequisite 2: Have 12 rates created to make search input available.

Open the staging.new.expensify.com website.
Navigate to "Workspaces" > Workspace > "Distance Rates"
Type anything on search input that will trigger more than one rate as result.
Select any rate from results and delete it.
Note that search input disappears
Verify all rates are displayed

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Monosnap.screencast.2026-06-12.11-15-44.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

Monosnap.screencast.2026-06-12.11-17-41.mp4

Monosnap.screencast.2026-06-12.18-17-12.mp4

Monosnap.screencast.2026-06-12.18-17-48.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-06-12T05:02:33Z

@codex review

codecov · 2026-06-12T05:05:30Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/Table/Table.tsx	`93.47% <100.00%> (+0.14%)`	⬆️
src/components/Table/TableSearchBar.tsx	`100.00% <100.00%> (ø)`
src/components/Table/middlewares/selection.ts	`55.00% <100.00%> (ø)`
...tanceRatesTable/WorkspaceDistanceRatesTableRow.tsx	`0.00% <0.00%> (ø)`
... and 57 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e6432d64a8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…ion mode exit Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-06-12T05:39:37Z

@codex review

chatgpt-codex-connector · 2026-06-12T05:44:18Z

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: a263fae086

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-06-12T05:51:35Z

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-06-12T05:51:41Z

@neil-marcellini @JS00001 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JS00001 · 2026-06-12T12:07:34Z

lmk when this is ready

Krishna2323 · 2026-06-12T12:31:18Z

@thelullabyy could you please review?

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

thelullabyy · 2026-06-12T17:03:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-06-12.at.12.50.10.mov

Screen.Recording.2026-06-12.at.12.49.32.mov

Screen.Recording.2026-06-12.at.12.48.54.mov

joekaufmanexpensify

Fixing deploy blockers

thelullabyy

LGTM

github-actions · 2026-06-12T17:58:41Z

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-06-12T18:02:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-12T18:05:54Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #93378.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-7d9ecb04095-1704fb4-3226ef2ee8a2fb4445d4de262136df84356130a4/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7d9ecb0-1704fb4-104ff400c8a15b73b537bad644b4f2cb45f8881c/index.html

Web 🕸️
https://93378.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

[cp staging] Fix distance rates table regressions from #90920 (cherry picked from commit 7d9ecb0) (cherry-picked to staging by Julesssss)

OSBotify · 2026-06-12T19:02:52Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.4.6-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-06-12T21:46:33Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.6-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-06-12T22:04:38Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.4.7-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-06-15T17:53:51Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.7-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix distance rates table regressions from Expensify#90920

e6432d6

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot Bot assigned Krishna2323 Jun 12, 2026

chatgpt-codex-connector Bot reviewed Jun 12, 2026

View reviewed changes

Comment thread src/components/Table/middlewares/selection.ts Outdated

Use originalSelectableCount instead of isDataFiltered to guard select…

a263fae

…ion mode exit Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 marked this pull request as ready for review June 12, 2026 05:51

Krishna2323 requested review from a team as code owners June 12, 2026 05:51

melvin-bot Bot requested review from joekaufmanexpensify and thelullabyy and removed request for a team June 12, 2026 05:51

melvin-bot Bot requested review from a team, JS00001 and neil-marcellini and removed request for a team June 12, 2026 05:51

Clear search string when TableSearchBar unmounts

c864ccd

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

neil-marcellini removed their request for review June 12, 2026 13:18

joekaufmanexpensify approved these changes Jun 12, 2026

View reviewed changes

thelullabyy approved these changes Jun 12, 2026

View reviewed changes

melvin-bot Bot requested a review from neil-marcellini June 12, 2026 17:51

JS00001 approved these changes Jun 12, 2026

View reviewed changes

JS00001 changed the title ~~Fix distance rates table regressions from #90920~~ [cp staging] Fix distance rates table regressions from #90920 Jun 12, 2026

JS00001 merged commit 7d9ecb0 into Expensify:main Jun 12, 2026
35 of 38 checks passed

OSBotify pushed a commit that referenced this pull request Jun 12, 2026

Merge pull request #93378 from Krishna2323/krishna/fix-90920-regressions

236a5b7

[cp staging] Fix distance rates table regressions from #90920 (cherry picked from commit 7d9ecb0) (cherry-picked to staging by Julesssss)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jun 12, 2026

OSBotify mentioned this pull request Jun 12, 2026

Deploy Checklist: New Expensify 2026-06-11 #93342

Closed

60 tasks

Conversation

Krishna2323 commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Test 1

Test 2

Test 3

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented Jun 12, 2026

Uh oh!

codecov Bot commented Jun 12, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Krishna2323 commented Jun 12, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 12, 2026

Uh oh!

melvin-bot Bot commented Jun 12, 2026

Uh oh!

melvin-bot Bot commented Jun 12, 2026

Uh oh!

JS00001 commented Jun 12, 2026

Uh oh!

Krishna2323 commented Jun 12, 2026

Uh oh!

thelullabyy commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

thelullabyy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 12, 2026

Uh oh!

OSBotify commented Jun 12, 2026

Uh oh!

github-actions Bot commented Jun 12, 2026

Uh oh!

OSBotify commented Jun 12, 2026

Uh oh!

OSBotify commented Jun 12, 2026

Uh oh!

OSBotify commented Jun 12, 2026

Uh oh!

OSBotify commented Jun 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Krishna2323 commented Jun 12, 2026 •

edited

Loading

codecov Bot commented Jun 12, 2026 •

edited by github-actions Bot

Loading

thelullabyy commented Jun 12, 2026 •

edited

Loading