[NoQA] [HR Import] Add MERGE_HR consts, types, and provider map by mhawryluk · Pull Request #90949 · Expensify/App

mhawryluk · 2026-05-18T10:04:34Z

Explanation of Change

Adds the essential constants and types needed for the merge.dev HR integrations, which are coming in following PRs.

Fixed Issues

$ #90594
PROPOSAL: N/A

Tests

Offline tests

QA Steps

No tests.

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

jmusial

LGTM 🚀

codecov · 2026-05-18T10:41:54Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/AccountingUtils.ts	`63.63% <ø> (ø)`
src/CONST/MERGE_HR_PROVIDERS.ts	`0.00% <0.00%> (ø)`
src/CONST/index.ts	`92.30% <0.00%> (ø)`
... and 66 files with indirect coverage changes

melvin-bot · 2026-05-18T10:43:49Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cristipaval · 2026-05-18T10:44:08Z

No need for a C+ review here.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 54e670fead

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

grgia · 2026-05-18T10:54:00Z

+        /** Approval mode */
        approvalMode: ValueOf<typeof CONST.GUSTO.APPROVAL_MODE> | null;


this is still gusto yea?

ie should we rename CONST.HR.APPROVAL_MODE

oh, good catch. we should either rename CONST.GUSTO.APPROVAL_MODE or create a separate for merge. will the approval modes be the same for merge hr that there are for gusto?

I see these values are also being changed for gusto: #90868

I'm assuming separate for merge unless they end up being the same. Seems like a safe guess to keep separate for now and | them?

I agree, will separate them, thanks!

grgia

minor comments @mhawryluk

grgia · 2026-05-18T10:57:43Z

+        /** Approval mode */
        approvalMode: ValueOf<typeof CONST.GUSTO.APPROVAL_MODE> | null;


ie should we rename CONST.HR.APPROVAL_MODE

grgia · 2026-05-18T11:15:50Z

+const MERGE_HR_PROVIDERS = {
+    workday: {
+        displayName: 'Workday',
+        iconUrl: 'https://merge-api-public.s3.amazonaws.com/media/PlatformWorkday.png',


Should these be saved and served locally?

NAB, we can deal with this when we start serving them in app

I think we settled on using the merge's url in the design doc to not increase the bundle

Agree. We have this internal issue to eventually cache these too but that's for R2: https://github.com/orgs/Expensify/projects/285/views/7?sliceBy%5BcolumnId%5D=348841703&sliceBy%5Bvalue%5D=R2%3A+60%2B+connections&pane=issue&itemId=188836197&issue=Expensify%7CExpensify%7C636853

grgia · 2026-05-18T12:54:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-05-18T14:15:08Z

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-18T14:20:24Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90949.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-140c82a-c55c030-65033e9d84787869f5d4c84e812659966e2241e9/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-140c82a-c55c030-0db03afff41e5e88bdfa278b250a4d48c2c5b6ea/index.html

Web 🕸️
https://90949.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-18T14:20:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-19T08:10:35Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.3.76-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-05-19T22:02:57Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.77-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[HR Import] Add MERGE_HR consts, types, and provider map

cc1c280

melvin-bot Bot assigned mhawryluk May 18, 2026

mhawryluk added 5 commits May 18, 2026 12:07

Fix type for mergeProviderSlug

39ed5b6

Remove fake icon urls

58ccec1

Small fix

ca0e56c

Update cspell

aa9aede

Small change to comment

4120358

jmusial approved these changes May 18, 2026

View reviewed changes

Move merge_hr_ to a constant

54e670f

cristipaval previously approved these changes May 18, 2026

View reviewed changes

mhawryluk marked this pull request as ready for review May 18, 2026 10:43

mhawryluk requested review from a team as code owners May 18, 2026 10:43

melvin-bot Bot requested review from dukenv0307 and heyjennahay and removed request for a team May 18, 2026 10:43

melvin-bot Bot removed the request for review from a team May 18, 2026 10:43

cristipaval removed the request for review from dukenv0307 May 18, 2026 10:43

cristipaval requested a review from grgia May 18, 2026 10:44

chatgpt-codex-connector Bot reviewed May 18, 2026

View reviewed changes

Comment thread src/CONST/MERGE_HR_PROVIDERS.ts Outdated

grgia reviewed May 18, 2026

View reviewed changes

Add iconUrls for merge hr providers

7c83415

mhawryluk dismissed cristipaval’s stale review via 7c83415 May 18, 2026 11:05

mhawryluk added 2 commits May 18, 2026 13:08

Add MergeHRConnectionData type alias

cc8c120

Rename CONST.GUSTO.APPROVAL_MODE to CONST.HR.APPROVAL_MODE

4ed0c3b

grgia reviewed May 18, 2026

View reviewed changes

mhawryluk added 2 commits May 18, 2026 13:23

Merge branch 'main' into merge-hr/foundations

2814f91

Separate GUSTO.APPROVAL_MODE and MERGE_HR.APPROVAL_MODE

ff04d75

mhawryluk requested a review from grgia May 18, 2026 11:32

jmusial mentioned this pull request May 18, 2026

[NoQA] [HR Import] Refactor policyUtils helpers for HR integrations #90959

Merged

50 tasks

grgia previously approved these changes May 18, 2026

View reviewed changes

jmusial mentioned this pull request May 18, 2026

[Due for payment 2026-05-28] [HR Import] PolicyUtils helpers for HR connections [F03] #90596

Closed

Replace multiple merge hr integrations with a single one

ec5fd17

mhawryluk dismissed grgia’s stale review via ec5fd17 May 18, 2026 13:47

Fix AccountingUtils

9a135fa

cristipaval approved these changes May 18, 2026

View reviewed changes

cristipaval merged commit 140c82a into Expensify:main May 18, 2026
34 checks passed

OSBotify mentioned this pull request May 19, 2026

Deploy Checklist: New Expensify 2026-05-19 #91039

Closed

75 tasks

melvin-bot Bot mentioned this pull request May 19, 2026

[Due for payment 2026-05-26] [HR Import] Add MERGE_HR consts, types, and provider map [F01] #90594

Closed

		/** Approval mode */
		approvalMode: ValueOf<typeof CONST.GUSTO.APPROVAL_MODE> \| null;

Conversation

mhawryluk commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

jmusial left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented May 18, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented May 18, 2026

Uh oh!

cristipaval commented May 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mhawryluk May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

grgia commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

OSBotify commented May 18, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mhawryluk commented May 18, 2026 •

edited

Loading

codecov Bot commented May 18, 2026 •

edited by github-actions Bot

Loading

mhawryluk May 18, 2026 •

edited

Loading

grgia commented May 18, 2026 •

edited

Loading