[NoQA] [HR Import] Refactor policyUtils helpers for HR integrations by jmusial · Pull Request #90959 · Expensify/App

jmusial · 2026-05-18T12:39:09Z

Explanation of Change

NOTE: This branch is based off #90949.

This PR adds new helpers and generalizes the Gusto-specific helpers so they work for any HR provider.

Fixed Issues

$ #90596
PROPOSAL:

Tests

Verify that Gusto integration is working as before:

Make sure that Gusto beta is enabled
Connect gusto or inject connection mock into FE (look snippet below)
Verify that Workflows -> Approvals and More features -> HR are locked and show popup with a correct message when user is trying to unlock

Snippet:

Onyx.merge(`policy_{workspace_id}`, {
    isHREnabled: true,
    connections: {
        gusto: {
            config: {
                approvalMode: 'custom',
                finalApprover: 'test@jmusial.dev',
            },
        },
    },
});

Offline tests

N/A

QA Steps

N/A

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2026-05-18.at.15.02.25.mov

melvin-bot · 2026-05-18T12:39:15Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

jmusial · 2026-05-18T12:39:16Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0462fc73b4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-05-18T12:48:05Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`92.30% <ø> (ø)`
src/pages/workspace/WorkspaceInitialPage.tsx	`0.00% <0.00%> (ø)`
src/libs/PolicyUtils.ts	`68.85% <92.10%> (+0.85%)`	⬆️
...ages/workspace/WorkspaceMoreFeaturesPage/index.tsx	`67.62% <25.00%> (-0.50%)`	⬇️
...ges/workspace/workflows/WorkspaceWorkflowsPage.tsx	`0.00% <0.00%> (ø)`
... and 10 files with indirect coverage changes

jmusial · 2026-05-18T14:53:02Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5fa3e9f176

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mhawryluk · 2026-05-18T15:42:35Z

+}
+
+/** Returns display info for every HR provider currently connected to the policy (Gusto, Zenefits, and Merge HR). */
+function getConnectedHRProviders(policy?: OnyxEntry<Policy>): HRProviderInfo[] {


I think we settled that there will only be one connection max for a workspace

This was the task specification but changing it makes since we're allowing only 1

melvin-bot · 2026-05-18T20:54:17Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2026-05-19T07:24:43Z

                gusto: 'Gusto',
                billCom: 'Bill.com',
                zenefits: 'TriNet',
+                merge_hris: 'Merge HR',


Unnecessary change

it's together with other integrations now, keeping context together

Fair enough😁

ZhenjaHorbach · 2026-05-19T10:02:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-05-19.12.28.33.mov

Android: mWeb Chrome

2026-05-19.12.37.20.mov

iOS: HybridApp

2026-05-19.12.28.33.mov

iOS: mWeb Safari

2026-05-19.12.25.14.mov

MacOS: Chrome / Safari

2026-05-19.12.15.09.mov

ZhenjaHorbach · 2026-05-19T10:14:51Z

I know that I use mocks for testing 😅
But should we add a guard for cases when HR is disabled in workspace settings?
Although I'm not sure how realistic this scenario is

2026-05-19.12.14.00.mov

twisterdotcom · 2026-05-19T10:24:40Z

should we add a guard for cases when HR is disabled in workspace settings?

I don't think there should be a situation where workflows are configured via HR, but HR is disabled.

ZhenjaHorbach · 2026-05-19T10:41:50Z

Good then 😁
LGTM!

grgia · 2026-05-19T11:16:05Z

+function isMergeHRConnected(policy?: OnyxEntry<Policy>): boolean {
+    return !!policy?.connections?.merge_hris;
+}


does it matter if they are added but not yet set up/synced?

For now we're assuming that we're showing isMergeHRConnected even when sync has failed / is syncing, but the RBR & UI is not in place yet.

github-actions · 2026-05-19T11:23:48Z

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-19T11:28:24Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90959.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d78ae0c-d67ad90-17a90a8f2b780d74e698d7cf41df4c9badc6e656/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d78ae0c-d67ad90-db02880e9b3b80afd1a66b1d653371cd81177201/index.html

Web 🕸️
https://90959.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-19T11:32:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-19T22:08:31Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.3.78-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-05-21T21:26:38Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.78-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

refactor policyUtils helpers for HR integrations

0462fc7

melvin-bot Bot assigned jmusial May 18, 2026

chatgpt-codex-connector Bot reviewed May 18, 2026

View reviewed changes

Comment thread src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

jmusial changed the title ~~refactor policyUtils helpers for HR integrations~~ [NoQA] [HR Import] Refactor policyUtils helpers for HR integrations May 18, 2026

fix lint

5f04a67

jmusial mentioned this pull request May 18, 2026

[Due for payment 2026-05-28] [HR Import] PolicyUtils helpers for HR connections [F03] #90596

Closed

jmusial added 7 commits May 18, 2026 16:19

update for changed upstream PR with consts

457c89a

Merge branch 'main' into feat/hr-imports-policy-helpers-refactor

7b60e65

revert next PRs changes

959d3e1

remove dead code

8a63a44

remove trainlong whitespace, refactor

c625d00

prettier fix

e205000

prettier fix v2

5fa3e9f

chatgpt-codex-connector Bot reviewed May 18, 2026

View reviewed changes

Comment thread src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

mhawryluk reviewed May 18, 2026

View reviewed changes

jmusial added 4 commits May 18, 2026 21:09

update zenfits case, allow only one conncted connection

ea3e102

add jsdoc to HRProviderInfo

ea95ed1

Merge branch 'main' into feat/hr-imports-policy-helpers-refactor

f962912

update tests to use CONSTs

7a1e6d2

jmusial mentioned this pull request May 18, 2026

[No QA][HR Import] Render per provider cards on hr page #91017

Merged

50 tasks

jmusial marked this pull request as ready for review May 18, 2026 20:54

jmusial requested review from a team as code owners May 18, 2026 20:54

melvin-bot Bot requested review from ZhenjaHorbach and flaviadefaria and removed request for a team May 18, 2026 20:54

melvin-bot Bot removed the request for review from a team May 18, 2026 20:54

ZhenjaHorbach reviewed May 19, 2026

View reviewed changes

ZhenjaHorbach approved these changes May 19, 2026

View reviewed changes

melvin-bot Bot requested a review from grgia May 19, 2026 10:42

cristipaval approved these changes May 19, 2026

View reviewed changes

Merge branch 'main' into feat/hr-imports-policy-helpers-refactor

edcb5a3

grgia reviewed May 19, 2026

View reviewed changes

grgia approved these changes May 19, 2026

View reviewed changes

grgia merged commit d78ae0c into Expensify:main May 19, 2026
43 checks passed

OSBotify mentioned this pull request May 19, 2026

Deploy Checklist: New Expensify 2026-05-19 #91122

Closed

39 tasks

Conversation

jmusial commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 18, 2026

Uh oh!

jmusial commented May 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov Bot commented May 18, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jmusial commented May 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mhawryluk May 18, 2026

Choose a reason for hiding this comment

Uh oh!

jmusial May 18, 2026

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 18, 2026

Uh oh!

ZhenjaHorbach May 19, 2026

Choose a reason for hiding this comment

Uh oh!

jmusial May 19, 2026

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach May 19, 2026

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

twisterdotcom commented May 19, 2026

Uh oh!

ZhenjaHorbach commented May 19, 2026

Uh oh!

grgia May 19, 2026

Choose a reason for hiding this comment

Uh oh!

jmusial May 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

jmusial commented May 18, 2026 •

edited

Loading

codecov Bot commented May 18, 2026 •

edited by github-actions Bot

Loading

ZhenjaHorbach commented May 19, 2026 •

edited

Loading

ZhenjaHorbach commented May 19, 2026 •

edited

Loading