[CP Stg] Fix Export to QuickBooks Online showing only after reopening report by roryabraham · Pull Request #91233 · Expensify/App

roryabraham · 2026-05-20T18:51:18Z

Explanation of Change

When QBO auto-export fails, MarkExportFailed merges errorFields.export onto the report in real time but does not update hasExportError. After #90154, hasExportError() trusted a stale hasExportError: false from the initial OpenApp payload and hid the Export primary action until the report was reopened.

This change treats active errorFields.export (and existing integration-message fallbacks) as export failures, so Export to QuickBooks Online appears immediately after auto-export fails.

Fixed Issues

$ #91153

Tests

Connect a workspace to QuickBooks Online with auto-sync enabled.
Create a workspace expense, open the expense report, submit, and approve.
Keep the report open until auto-export fails (integration failure message in the thread).
Verify the Export to QuickBooks Online primary action appears without closing/reopening the report.
Verify no new errors in the JS console.

Verify that no errors appear in the JS console

Offline tests

N/A — export failure state is delivered via Onyx updates when online.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Made with Cursor

MarkExportFailed updates errorFields.export in real time but not hasExportError. Treat active export errorFields as a failure signal so the Export to QuickBooks Online action appears without reopening. Co-authored-by: Cursor <cursoragent@cursor.com>

Krishna2323 · 2026-05-20T20:39:43Z

@roryabraham is this PR ready for review? I can review it since I was the C+ on the offending PR.

Krishna2323 · 2026-05-20T21:11:38Z

@roryabraham please fix the failing TS.

Krishna2323 · 2026-05-20T22:15:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Monosnap.screencast.2026-05-21.03-44-25.mp4

Krishna2323 · 2026-05-20T22:17:14Z

@codex review

chatgpt-codex-connector · 2026-05-20T22:22:12Z

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Use as unknown as Report for fixtures with errorFields to avoid TS2352 overlap errors. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-05-21T18:26:38Z

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

roryabraham · 2026-05-21T19:13:42Z

applause confirmed this fixes the issue: #91153 (comment)

melvin-bot · 2026-05-21T19:13:49Z

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323

LGTM!

melvin-bot · 2026-05-21T19:15:10Z

@inimaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2b03a443cb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-21T19:22:03Z

+    if (report?.hasExportError) {
+        return true;
+    }


Honor explicit false export-error state

The new truthy check (if (report?.hasExportError)) no longer treats hasExportError: false as authoritative, so execution falls through to the report-action fallback and marks the report as errored whenever any historical INTEGRATIONS_MESSAGE exists. Because report actions are historical/append-only while isExported() is reset by later submit/reopen actions, this can incorrectly produce !isExported && hasExportError after a reopen cycle and block normal pay/export action selection for reports that no longer have an active export error.

Useful? React with 👍 / 👎.

hasExportError: false wouldn't fall through to the next block.

roryabraham · 2026-05-21T19:24:40Z

not sure why claude review is failing, but it's not related. Merging

melvin-bot · 2026-05-21T19:24:55Z

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2026-05-21T19:35:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-21T19:39:46Z

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-21T19:45:29Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91233.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-3a5f14b-fdf8a2c-5e7c0434144e798272a0ed8d1325b8e7651cca29/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-3a5f14b-fdf8a2c-aa8900a6f1265a5b311c560613bdf2f375c98d72/index.html

Web 🕸️
https://91233.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Fix Export to QuickBooks Online showing only after reopening report (cherry picked from commit 3a5f14b) (cherry-picked to staging by roryabraham)

OSBotify · 2026-05-21T20:46:22Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.78-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-21T20:48:22Z

No help site changes required.

This PR is a bug fix to internal error-detection logic (hasExportError() in ReportUtils.ts). It makes the Export to QuickBooks Online button appear immediately after auto-export fails, rather than requiring the user to reopen the report.

No user-facing text, UI labels, workflows, settings, or error messages were changed. The existing FAQ in Expense-and-Report-Actions.md ("What happens if an export fails? An error message appears with next steps. You can fix the issue and retry the export.") remains accurate.

OSBotify · 2026-05-21T21:27:11Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.78-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-05-21T21:53:52Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.79-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-21T21:55:23Z

No help site changes are required for this PR.

This is a pure bug fix in internal error-detection logic (hasExportError in ReportUtils.ts and its callers in ReportPreviewActionUtils.ts). It ensures the Export to QuickBooks Online button appears immediately after auto-export fails, rather than requiring the user to close and reopen the report.

The change doesn't alter any user-facing feature, workflow, UI label, setting, or documented behavior — it fixes the timing of when an existing button becomes visible. The existing QBO export error troubleshooting articles describe error codes and resolution steps, which remain accurate and unaffected.

OSBotify · 2026-05-22T22:27:47Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.79-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot Bot assigned roryabraham May 20, 2026

Fix TypeScript errors in hasExportError tests

2b03a44

Use as unknown as Report for fixtures with errorFields to avoid TS2352 overlap errors. Co-authored-by: Cursor <cursoragent@cursor.com>

This comment has been minimized.

Sign in to view

roryabraham marked this pull request as ready for review May 21, 2026 19:13

roryabraham requested review from a team as code owners May 21, 2026 19:13

melvin-bot Bot requested review from dmkt9 and trjExpensify May 21, 2026 19:13

melvin-bot Bot removed request for a team and trjExpensify May 21, 2026 19:13

Krishna2323 approved these changes May 21, 2026

View reviewed changes

melvin-bot Bot requested a review from inimaga May 21, 2026 19:15

luacmartins approved these changes May 21, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed May 21, 2026

View reviewed changes

roryabraham merged commit 3a5f14b into main May 21, 2026
51 of 54 checks passed

roryabraham deleted the rory-91153-qbo-export-menu branch May 21, 2026 19:24

melvin-bot Bot added the Emergency label May 21, 2026

roryabraham changed the title ~~Fix Export to QuickBooks Online showing only after reopening report~~ [CP Stg] Fix Export to QuickBooks Online showing only after reopening report May 21, 2026

roryabraham removed the Emergency label May 21, 2026

OSBotify added the CP Staging marks PRs that have been CP'd to staging label May 21, 2026

OSBotify mentioned this pull request May 21, 2026

Deploy Checklist: New Expensify 2026-05-19 #91122

Closed

39 tasks

melvin-bot Bot mentioned this pull request May 21, 2026

[Due for payment 2026-05-29] [Due for payment 2026-05-28] Expense - 'Export to QuickBooks Online' option only appears after reopening report #91153

Closed

7 tasks

Conversation

roryabraham commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented May 20, 2026

Uh oh!

Krishna2323 commented May 20, 2026

Uh oh!

Krishna2323 commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented May 20, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 20, 2026

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

This comment has been minimized.

roryabraham commented May 21, 2026

Uh oh!

melvin-bot Bot commented May 21, 2026

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 21, 2026

Choose a reason for hiding this comment

Uh oh!

roryabraham May 21, 2026

Choose a reason for hiding this comment

Uh oh!

roryabraham commented May 21, 2026

Uh oh!

Uh oh!

melvin-bot Bot commented May 21, 2026

Uh oh!

OSBotify commented May 21, 2026

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

OSBotify commented May 21, 2026

Uh oh!

MelvinBot commented May 21, 2026

Uh oh!

OSBotify commented May 21, 2026

Uh oh!

OSBotify commented May 21, 2026

Uh oh!

MelvinBot commented May 21, 2026

Uh oh!

OSBotify commented May 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

roryabraham commented May 20, 2026 •

edited

Loading

Krishna2323 commented May 20, 2026 •

edited

Loading