Pass report to isExported/hasExportError to fix primary action after failed export by MelvinBot · Pull Request #90154 · Expensify/App

MelvinBot · 2026-05-11T08:57:21Z

Explanation of Change

Two utility calls in ReportPrimaryActionUtils.ts were missing the report parameter, causing them to fall back to scanning report actions instead of reading the authoritative report flags. After a failed QBO export:

isPrimaryPayAction called isExportedUtil(reportActions) without report — the stale optimistic EXPORTED_TO_INTEGRATION action made it return isExported = true, hiding the export failure and incorrectly showing the Pay button.
isExportAction called hasExportErrorUtil(reportActions) without report — even if control reached this function, the action-based fallback could miss the error, preventing the Export button from appearing.

Both fixes pass report to align with how other callers (e.g., ReportPreviewActionUtils) already use these utilities. Also fixes the same missing report parameter in ReportDetailsExportPage.tsx as requested in the issue review.

Fixed Issues

$ #87654
PROPOSAL: #87654 (comment)

Tests

Connect a workspace to QBO (or another accounting integration with auto-sync enabled)
Create and submit an expense report on that workspace
Approve the report so it is ready for export
Trigger an export that fails (e.g., by misconfiguring the QBO connection or using an invalid account mapping)
Open the report and verify the Export button appears (not the Pay button)
Navigate to the report details export page and verify the export status correctly reflects the failure
Verify that no errors appear in the JS console

Offline tests

N/A — this change only affects which primary action button is displayed; no network behavior is altered.

QA Steps

Connect a workspace to QBO (or another accounting integration with auto-sync enabled)
Create and submit an expense report on that workspace
Approve the report so it is ready for export
Trigger an export that fails (e.g., by misconfiguring the QBO connection or using an invalid account mapping)
Open the report and verify the Export button appears (not the Pay button)
Navigate to the report details export page and verify the export status correctly reflects the failure
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

AI Tests

Ran:

npm run typecheck-tsgo — passed (pre-existing errors in unrelated ConvertGpsPointsTo2DArray.ts only)
npm run lint-changed — passed (no lintable files changed)
npx prettier --write — passed (no formatting changes needed)
npm test -- --silent — 13,426 passed, 7 failed (all failures in createOrUpdateDeployChecklistTest.ts, pre-existing and unrelated)
npm run react-compiler-compliance-check check-changed — could not run (environment lacks upstream branch config)

After a failed QBO export, the primary action button incorrectly shows Pay instead of Export. Two utility calls in ReportPrimaryActionUtils were missing the report parameter, causing them to fall back to action-based scanning which returns stale results after export failure. Also fix the same missing parameter in ReportDetailsExportPage. Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>

codecov · 2026-05-11T09:06:34Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/ReportPrimaryActionUtils.ts	`92.30% <100.00%> (ø)`
src/pages/inbox/report/ReportDetailsExportPage.tsx	`0.00% <0.00%> (ø)`
... and 7 files with indirect coverage changes

Krishna2323 · 2026-05-15T20:16:07Z

@MelvinBot merge main and complete the checklist

…ryActionAfterFail Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>

MelvinBot · 2026-05-15T20:24:07Z

Merged main and completed the PR Author Checklist (checked off all N/A items — no new files, CSS, assets, UI changes, deeplinks, storybook, generic components, or message editing code). Left the testing steps, screenshots, and platform test items unchecked for the human co-author to fill out.

Krishna2323 · 2026-05-15T20:25:27Z

@MelvinBot add the testing steps as well and check off screenshots also, I'll be adding those in reviewer checklist so we don't need it in author checklist.

MelvinBot · 2026-05-15T20:27:46Z

Updated the PR body:

Added testing steps to both Tests and QA Steps sections (connect workspace to QBO, trigger a failed export, verify Export button appears instead of Pay button)
Checked off screenshots and platform test items in the author checklist
Checked off the testing steps checklist items

Krishna2323 · 2026-05-15T20:29:01Z

@MelvinBot mark this PR ready for review

MelvinBot · 2026-05-15T20:30:41Z

Marked this PR as ready for review.

melvin-bot · 2026-05-15T20:30:44Z

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-05-15T20:30:49Z

@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2026-05-15T20:46:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android_hybrid.mp4

Android: mWeb Chrome

android_mWeb.mp4

iOS: HybridApp

ios_hybrid.mp4

iOS: mWeb Safari

ios_mWeb.mp4

MacOS: Chrome / Safari

web_chrome.mp4

Krishna2323

LGTM!

trjExpensify

👍

melvin-bot · 2026-05-19T13:16:01Z

@madmax330 looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

github-actions · 2026-05-19T13:16:54Z

🚧 @madmax330 has triggered a test Expensify/App build. You can view the workflow run here.

madmax330 · 2026-05-19T13:18:23Z

Tests were passing

github-actions · 2026-05-19T13:21:14Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90154.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d8a8d01-d67ad90-17a90a8f2b780d74e698d7cf41df4c9badc6e656/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d8a8d01-d67ad90-db02880e9b3b80afd1a66b1d653371cd81177201/index.html

Web 🕸️
https://90154.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-19T13:25:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-19T22:08:04Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.3.78-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-19T22:11:12Z

No help site changes required.

This PR is a bug fix that passes a missing report parameter to isExportedUtil and hasExportErrorUtil so the correct primary action button (Export vs Pay) displays after a failed accounting integration export. No new features, UI labels, settings, or user-facing workflows were introduced or changed — the fix corrects internal logic so existing behavior works as intended.

jponikarchuk · 2026-05-20T07:37:24Z

Deploy Blocker #91153 was identified to be related to this PR.

OSBotify · 2026-05-21T21:26:11Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.78-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned Krishna2323 May 11, 2026

MelvinBot requested a review from a team May 11, 2026 08:57

MelvinBot mentioned this pull request May 11, 2026

[Due for payment 2026-05-28] [$250] IOU - The primary action shows pay button instead of Export #87654

Closed

7 tasks

Merge remote-tracking branch 'origin/main' into claude-fixExportPrima…

ec0c0b3

…ryActionAfterFail Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>

MelvinBot marked this pull request as ready for review May 15, 2026 20:30

MelvinBot requested a review from a team as a code owner May 15, 2026 20:30

melvin-bot Bot requested review from Krishna2323 and trjExpensify and removed request for a team May 15, 2026 20:30

melvin-bot Bot requested review from a team and madmax330 and removed request for a team May 15, 2026 20:30

Krishna2323 approved these changes May 15, 2026

View reviewed changes

trjExpensify approved these changes May 19, 2026

View reviewed changes

madmax330 approved these changes May 19, 2026

View reviewed changes

madmax330 merged commit d8a8d01 into main May 19, 2026
52 of 54 checks passed

madmax330 deleted the claude-fixExportPrimaryActionAfterFail branch May 19, 2026 13:15

melvin-bot Bot added the Emergency label May 19, 2026

madmax330 removed the Emergency label May 19, 2026

OSBotify mentioned this pull request May 19, 2026

Deploy Checklist: New Expensify 2026-05-19 #91122

Closed

39 tasks

applause-bot Bot mentioned this pull request May 20, 2026

[Due for payment 2026-05-29] [Due for payment 2026-05-28] Expense - 'Export to QuickBooks Online' option only appears after reopening report #91153

Closed

7 tasks

roryabraham mentioned this pull request May 20, 2026

[CP Stg] Fix Export to QuickBooks Online showing only after reopening report #91233

Merged

53 tasks

This was referenced May 22, 2026

fix: update the report primary action for when an export fails #72292

Merged

[Due for payment 2025-12-30] [$250] Update the report primary action for when an export fails #70101

Closed

Conversation

MelvinBot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 11, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Krishna2323 commented May 15, 2026

Uh oh!

MelvinBot commented May 15, 2026

Uh oh!

Krishna2323 commented May 15, 2026

Uh oh!

MelvinBot commented May 15, 2026

Uh oh!

Krishna2323 commented May 15, 2026

Uh oh!

MelvinBot commented May 15, 2026

Uh oh!

melvin-bot Bot commented May 15, 2026

Uh oh!

melvin-bot Bot commented May 15, 2026

Uh oh!

Krishna2323 commented May 15, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot Bot commented May 19, 2026

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

madmax330 commented May 19, 2026

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

MelvinBot commented May 19, 2026

Uh oh!

jponikarchuk commented May 20, 2026

Uh oh!

OSBotify commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

MelvinBot commented May 11, 2026 •

edited

Loading

codecov Bot commented May 11, 2026 •

edited by github-actions Bot

Loading