83367 migrate reports core part 2

[huult]

Explanation of Change

Fixed Issues

$ #83367
PROPOSAL:

Tests

Same QA step

• Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition:

• Have a group chat (DM with 3+ users) where you are the admin.
• Have an expense report (IOU/expense report preview) you can open.
• Have a workspace chat / policy expense chat to test the settings page.

REPORT_SETTINGS

1. Open any DM, group chat, or workspace chat.
2. Tap the chat header → opens Report Details.
3. Tap Settings
4. Verify that the Settings page opens and returns back normally.

REPORT_PARTICIPANTS

1. Open a group chat (admin).
2. Tap header → Report Details → Members
3. Verify that the Participants page opens and returns back normally.

REPORT_PARTICIPANTS_INVITE

1. Open a group chat (admin).
2. Tap header → Report Details → Members
3. Tap Invite Member button
4. Verify that the Invite Member page opens and returns back normally.

REPORT_PARTICIPANTS_DETAILS

1. Open a group chat (admin).
2. Tap header → Report Details → Members
3. Tap any member
4. Verify that the Member Details page opens and returns back normally.

REPORT_PARTICIPANTS_ROLE_SELECTION

1. Open a group chat (admin).
2. Tap header → Report Details → Members
3. Tap any member -> Role
4. Verify that the Member Role page opens and returns back normally.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-05-29.at.12.13.36.mov

Screen.Recording.2026-05-29.at.14.05.26.mov

[melvin-bot]

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[huult]

@MelvinBot I migrated REPORT_PARTICIPANTS, REPORT_PARTICIPANTS_INVITE, REPORT_PARTICIPANTS_DETAILS, REPORT_PARTICIPANTS_ROLE_SELECTION and REPORT_SETTINGS to use dynamic routes in this PR.

Could you help create some test steps so I can verify everything works correctly? Thanks!

[MelvinBot]

Here are test steps to verify the migration of REPORT_PARTICIPANTS, REPORT_PARTICIPANTS_INVITE, REPORT_PARTICIPANTS_DETAILS, REPORT_PARTICIPANTS_ROLE_SELECTION, and REPORT_SETTINGS to dynamic routes.

Pre-conditions

• Have a group chat (DM with 3+ users) where you are the admin.
• Have an expense report (IOU/expense report preview) you can open.
• Have a workspace chat / policy expense chat to test the settings page.
• Verify no errors appear in the JS console for every step below.

Test 1 — Report Settings dynamic route

1. Open any DM, group chat, or workspace chat.
2. Tap the chat header → opens Report Details.
3. Tap Settings.
   • ✅ Page opens, URL becomes /r/<reportID>/details/report-settings.
   • ✅ Page title is "Settings".
4. Tap Notification preferences → change preference → go back.
   • ✅ Returns to the Report Settings page (not the details page).
5. From Report Settings, tap Room name (if visible) → edit → save.
   • ✅ Returns to Report Settings page.
6. From Report Settings, tap Who can post (if visible) → change → save.
   • ✅ Returns to Report Settings page.
7. From Report Settings, tap Visibility (if visible) → change → save.
   • ✅ Returns to Report Settings page.
8. Tap the back button (header).
   • ✅ Returns to Report Details, not the chat.

Test 2 — Report Participants dynamic route

1. Open a group chat (admin).
2. Tap header → Report Details → Members.
   • ✅ URL becomes /r/<reportID>/details/participants.
   • ✅ Member list renders correctly with avatars/names.
3. Tap back.
   • ✅ Returns to Report Details.

Test 3 — Invite Participants dynamic route

1. From the Members page (Test 2), tap Invite (green button).
   • ✅ URL becomes /r/<reportID>/details/participants/invite.
2. Search a user, select, tap Invite.
   • ✅ Returns to the Members page, new member shows in the list.
3. Re-open invite → tap back without inviting.
   • ✅ Returns to Members page.

Test 4 — Participant Details dynamic route

1. From the Members page, tap a non-admin member row.
   • ✅ URL becomes /r/<reportID>/details/participants/<accountID>.
   • ✅ Member info renders (avatar, display name, role).
2. Tap back.
   • ✅ Returns to Members page.
3. Re-open the same member, tap Remove from chat → confirm.
   • ✅ Returns to Members page, member is removed.

Test 5 — Role selection dynamic route

1. From the Members page, tap a member row → opens Participant Details.
2. Tap Role.
   • ✅ URL becomes /r/<reportID>/details/participants/<accountID>/role.
3. Select a different role (Admin/Member) → tap.
   • ✅ Returns to Participant Details page, role updated.
4. Re-open Role page → tap back without changing.
   • ✅ Returns to Participant Details page.

Test 6 — Avatar header navigation (IOU/expense report)

1. Open an IOU or expense report.
2. Tap the avatars/header at the top.
   • ✅ Opens the Members page (/r/<reportID>/details/participants).
3. From inbox/LHN, open a money request preview.
4. In the report preview action, tap a multi-actor avatar.
   • ✅ Opens the Members page for the IOU report.

Test 7 — Deep-link / old-URL redirects (regression)

Paste each old URL into the browser address bar and press Enter. Each should auto-redirect to the new dynamic URL and render correctly.

Old URL	Should land on
/r/<reportID>/settings	/r/<reportID>/details/report-settings
/r/<reportID>/settings?backTo=/home	/r/<reportID>/details/report-settings?backTo=/home
/r/<reportID>/settings/name	/r/<reportID>/details/settings/name (already existed)

Also confirm that the new URLs work directly (cold deep-link from a signed-in browser tab):

• /r/<reportID>/details/report-settings
• /r/<reportID>/details/participants
• /r/<reportID>/details/participants/invite
• /r/<reportID>/details/participants/<accountID>
• /r/<reportID>/details/participants/<accountID>/role

Test 8 — Offline behavior

1. Turn off network connection.
2. Repeat Tests 1, 2, 4 (navigation only — do not invite/remove).
   • ✅ All pages render with cached data, no crashes.
3. Reconnect.
4. Invite a new user offline → confirm action queues and applies once back online.

Test 9 — Back-navigation chain

This is the highest-risk area since backTo was removed in favor of useDynamicBackPath.

1. From chat → Details → Settings → Notification preferences → back.
   • ✅ Lands on Settings, not Details.
2. From chat → Details → Members → Invite → back.
   • ✅ Lands on Members, not Details.
3. From chat → Details → Members → tap a member → Role → back.
   • ✅ Lands on Participant Details, then back again lands on Members, then back lands on Details.
4. From an IOU report → tap avatar header (opens Members) → back.
   • ✅ Returns to the IOU report, not Inbox.

Platforms to cover

• MacOS / Chrome
• MacOS / Safari
• iOS native
• Android native
• iOS mWeb (Safari)
• Android mWeb (Chrome)

Pay particular attention to mWeb and native back-button behavior — the migration from per-screen backTo params to useDynamicBackPath is most likely to surface bugs there.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9da9f1ee86

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/SCREENS.ts	100.00% <ø> (ø)
src/components/AvatarWithDisplayName.tsx	80.20% <ø> (ø)
src/libs/Navigation/linkingConfig/OldRoutes.ts	100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts	76.92% <ø> (ø)
src/pages/inbox/report/ReportActionItemSingle.tsx	86.56% <ø> (ø)
src/pages/inbox/report/withReportOrNotFound.tsx	97.14% <ø> (ø)
src/ROUTES.ts	20.38% <0.00%> (+0.07%)	⬆️
src/libs/ReportUtils.ts	84.79% <0.00%> (-0.02%)	⬇️
src/pages/DynamicReportDetailsPage.tsx	56.02% <0.00%> (ø)
src/pages/DynamicReportParticipantsInvitePage.tsx	0.00% <0.00%> (ø)
... and 5 more
... and 12 files with indirect coverage changes

[mananjadhav]

@huult Please resolve the conflicts.

[huult]

Resolved

[huult]

The failed checks are not related to this PR, so I will sync with main to fix them.

[huult]

@mananjadhav It's ready now.

[mananjadhav]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

web-bt-report-core.mov

[github-actions]

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #92040.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b74b0891842-928684c-586603cf1b9cf1fd0027a7800c6b1c75dd986ec7/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b74b089-928684c-6c04ca4befb00cb6678fface1e18220ce971ceee/index.html

Web 🕸️
https://92040.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.8-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• iOS

[MelvinBot]

🤖 No help site changes required.

This PR is an internal navigation/routing refactor — it migrates the report participants and settings screens to the dynamic-route pattern (createDynamicRoute), renames the screen constants (e.g. ROOT → DYNAMIC_ROOT), removes the legacy backTo params, and renames the page component files. Backward compatibility for the old URLs is preserved via redirects in OldRoutes.ts.

There is no user-facing behavior, UI, label, or feature change — the PR's own QA steps confirm each page "opens and returns back normally" (i.e. unchanged behavior). I also searched docs/articles for any references to these report routes/flows and found none.

Since nothing visible to end users changed, no updates to Expensify's help site files under docs/articles are needed, and no draft docs PR was created.

[OSBotify]

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.8-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android
• iOS

[OSBotify]

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.8-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅