Skip to content

[HOLD on feature] Docs updates for E/A#92270 Document Auditor read-only access to workspace settings#92800

Closed
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-auditor-readonly-workspace
Closed

[HOLD on feature] Docs updates for E/A#92270 Document Auditor read-only access to workspace settings#92800
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-auditor-readonly-workspace

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Summary

Documents the behavior added in #92270, which gives read-only workspace roles (most notably Auditor) the ability to open and view workspace settings pages in read-only mode on Control workspaces.

Updates docs/articles/new-expensify/workspaces/Managing-Workspace-Members.md:

  • Expands the Auditor role description to note that auditors can now view enabled workspace settings in read-only mode (Control workspaces only), in addition to viewing and commenting on reports.
  • Adds an FAQ entry, What can an Auditor view in a workspace?, explaining that auditors can open pages such as Categories, Tags, Taxes, Distance rates, Per diem, Report fields, and Accounting and drill into rows, while editing controls are disabled or hidden and edit attempts surface the Not so fast... message.

All feature/menu labels and the modal copy were verified against src/languages/en.ts in the source PR.

Source PR

@ShridharGoel, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 5, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

The failing build check is not caused by this PR — it's a CI infrastructure failure affecting every docs PR right now.

What's failing: The Deploy ExpensifyHelp workflow fails at the Install pcregrep step:

sudo apt-get install -y pcregrep
E: Unable to locate package pcregrep

This PR only edits a single markdown file (Managing-Workspace-Members.md) and doesn't touch the workflow, so there's nothing in the diff to fix — pushing to this branch won't make the check pass.

Evidence it's an environment/runner issue, not this PR
  • Every docs PR that started around 18:20 UTC today is failing at the same Install pcregrep step (e.g. branches docs-intacct-travel-invoicing-cr, melvin-docsTravelInvoicingLocksTravelToggle, claude-docs-qbo-travel-invoicing-cr, docs-xero-travel-invoicing-cr), not just this one.
  • The same workflow succeeded on main pushes earlier today (15:05 UTC and before) with no change to the Install pcregrep step.
  • That pattern — worked earlier, broke for all PRs at the same time — points to a CI runner-image change (blacksmith-2vcpu-ubuntu-2404), where apt can no longer locate pcregrep.

Recommended fix (separate workflow PR — affects all docs PRs):

  1. Add sudo apt-get update before the install step. Unable to locate package most often means a stale/empty apt index, which a runner-image refresh can cause. This is the minimal fix.
  2. If pcregrep (PCRE1, end-of-life) has actually been dropped from the runner's archive, migrate to pcre2grep: install pcre2-utils instead and update the pcregrep calls in enforceVideoFormats.sh to pcre2grep.

I didn't push this change because it's an unrelated CI-infrastructure fix that belongs in its own PR (it needs to land on main to unblock all docs PRs, not just this one), rather than being bundled into a docs change. Once that workflow fix is merged, re-running this PR's build check will pass with no edits needed here.

Want me to open that dedicated workflow PR? Reply @MelvinBot open the workflow fix PR and I'll put it up.

@stephanieelliott stephanieelliott changed the title Docs updates for E/A#92270 Document Auditor read-only access to workspace settings [HOLD on feature] Docs updates for E/A#92270 Document Auditor read-only access to workspace settings Jun 11, 2026
@stephanieelliott

Copy link
Copy Markdown
Contributor

taken care of in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants