Skip to content

[No QA] Docs updates for E/A#90537 add Approver column to Categories table#93205

Merged
stephanieelliott merged 1 commit into
mainfrom
melvin-docs-categories-table-approver-column
Jun 13, 2026
Merged

[No QA] Docs updates for E/A#90537 add Approver column to Categories table#93205
stephanieelliott merged 1 commit into
mainfrom
melvin-docs-categories-table-approver-column

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Summary

Follow-up docs update for #90537, which restyled the workspace Categories table and, on the Control plan, added an Approver column.

The help article Create-expense-categories.md enumerated the table's columns (Name, GL Code, Enabled) but did not mention the Approver column now shown on the Control plan. This PR adds it so the column list matches the current UI.

What changed

  • Updated the sentence describing the Categories table columns to include the Approver column (Control plan only).

What did NOT need a docs change

  • The visual restyle of the table is non-functional and not documented at the layout level.
  • Bulk selection via checkboxes is already documented ("Bulk actions are available using the checkboxes and Selected menu.").
  • Shift-click multi-select is a power-user keyboard interaction and isn't documented per Expensify conventions.
  • Assigning a category Approver is already documented under Category Rules.

All UI labels (Name, GL Code, Approver, Enabled) were verified against the live UI strings in src/languages/en.ts and the PR's column definitions.

@JS00001, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Co-authored-by: Jack Senyitko <JS00001@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 10, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#90537 add Approver column to Categories table [No QA] Docs updates for E/A#90537 add Approver column to Categories table Jun 10, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://fdfc0893.helpdot.pages.dev ⚡️

Updated articles:

@JS00001 JS00001 marked this pull request as ready for review June 11, 2026 11:08

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a7fd651fb6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread docs/articles/new-expensify/workspaces/Create-expense-categories.md
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a single, narrowly scoped update to Create-expense-categories.md -- adding the Approver column (Control plan only) to the sentence that enumerates the Categories table columns. The change accurately reflects the new UI introduced by #90537 and follows governance conventions well.

Scores Summary

  • Readability: 9/10 - The updated sentence remains clear and scannable. The parenthetical "(on the Control plan)" is a concise way to qualify plan-specific visibility. The sentence is getting long with four column items plus qualifiers, but it is still within acceptable limits.
  • AI Readiness: 9/10 - The existing YAML metadata (title, description, keywords, internalScope) is well-formed and the change does not introduce any retrieval issues. The diff itself does not add or modify headings, so heading compliance is not affected. One minor note: the keywords list could benefit from adding "category approver" or "approver column" to improve retrieval for users searching for that feature, but this is a suggestion rather than a requirement for this diff.
  • Style Compliance: 10/10 - The new text uses exact UI terminology: Approver is bolded and matches the column header label. Name, GL Code, and Enabled remain correctly bolded and cased. The plan name "Control" matches Expensify plan terminology. No prohibited language is introduced.

Key Findings

  • The added text correctly uses bold formatting for the UI column name Approver, consistent with button/tab naming standards in HELPSITE_NAMING_CONVENTIONS.md.
  • The parenthetical "(on the Control plan)" is an appropriate and concise way to indicate conditional visibility without breaking sentence flow.
  • All UI labels in the updated sentence were verified against live UI strings per the PR description, which is good practice.
  • No structural, heading, or metadata regressions are introduced by this change.

Recommendations

  • Consider adding "category approver" to the keywords list in the YAML frontmatter to improve search discoverability for users looking for approver-related help. This is optional and could be done in a follow-up.
  • No blocking issues found. This change is ready to merge from a documentation quality perspective.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Create-expense-categories.md -- Single sentence updated to add the Approver column reference. Clean, compliant change.

@stephanieelliott stephanieelliott merged commit 6cd7130 into main Jun 13, 2026
20 checks passed
@stephanieelliott stephanieelliott deleted the melvin-docs-categories-table-approver-column branch June 13, 2026 03:38
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.8-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.8-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.8-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants