Fix Concierge hidden-history hiding unread notification message on cold open

[MelvinBot]

Explanation of Change

The Concierge main DM collapses everything created before sessionStartTime behind Show full history. On a cold open (e.g. opening Concierge from an approval-notification email), startSession runs as soon as cached actions exist — before oldestUnreadReportAction resolves. At that instant the unread anchor is undefined, so the boundary locks to now and the unread notification message, created moments earlier, ends up on the hidden side of the boundary. The user only sees "Hi, how can I help?" until they click Show full history.

The C+ reviewer verified that re-invoking startSession alone is insufficient: ConciergeSessionContext keeps prev for the duration of an active session, so a second startSession call is a no-op. This PR fixes both halves:

1. ReportActionsView.tsx — the session-start effect now re-runs when oldestUnreadReportAction resolves (added oldestUnreadReportAction?.created to its deps), and passes that action's created time as the boundary. oldestUnreadReportAction.created is derived from the pre-read lastReadTime snapshot in usePaginatedReportActions, so it is immune to the readNewestAction optimistic bump of the live report.lastReadTime to now. It yields the same visible set as the intended pre-read boundary (nothing exists between lastReadTime and the oldest unread action by definition).

2. ConciergeSessionContext.tsx — within an active (non-expired) session, startSession now pulls sessionStartTime back to an earlier unreadBoundary when one arrives, instead of unconditionally returning prev. The session age (sessionCreatedAtRef) is left unchanged — only the display boundary is refined. When the boundary moves back, downstream useConciergeSidePanelReportActions recomputes hadMessagesAtSessionStart (it keys off sessionStartTime changing), so the unread message renders and the greeting-only collapse is suppressed.

When there is no unread action, the boundary still defaults to now, preserving the intended fresh-session collapse for already-read chats.

Fixed Issues

$ #93196
PROPOSAL: #93196 (comment)

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

1. Have a Concierge chat with prior history and an unread Concierge message (e.g. trigger an approval-notification email).
2. Cold-open the app (log in fresh / open from the notification deep link) and navigate to the Concierge chat.
3. Verify the unread message is visible immediately, without clicking Show full history.
4. Verify an already-read Concierge chat with no unread message still collapses to the greeting and Show full history still reveals older history.

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

1. Have a Concierge chat with prior history and an unread Concierge message.
2. Cold-open the app and open the Concierge chat.
3. Verify the unread message shows immediately without Show full history.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[MelvinBot]

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-conciergeSessionPullBackUnreadBoundary
git checkout -b claude-conciergeSessionPullBackUnreadBoundary upstream/claude-conciergeSessionPullBackUnreadBoundary
git push -u origin claude-conciergeSessionPullBackUnreadBoundary

Then you can close this PR and open a new one from your fork.

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/hooks/usePaginatedReportActions.ts	92.50% <100.00%> (ø)
src/pages/inbox/report/ReportActionsView.tsx	94.44% <100.00%> (+1.20%)	⬆️
src/pages/inbox/ConciergeSessionContext.tsx	55.55% <0.00%> (-3.27%)	⬇️
... and 61 files with indirect coverage changes

[Krishna2323]

Please extend the fix to cover:

1. Fallback to report.lastReadTime when isReportUnread but oldestUnreadReportAction is still undefined, and re-run startSession on both signals.
2. useInitial(report?.lastReadTime) in usePaginatedReportActions so the unread anchor can resolve on cold login.
3. Add oldestUnreadReportAction?.created to the focus-return effect deps.
4. If stale-cache repro still fails, capture open-time unread state before readNewestAction runs.

@MelvinBot please investigate these scenarios and apply if valid.

[MelvinBot]

Investigated all four scenarios. Applied 2 of them; the other 2 were either redundant or reintroduce a hazard this PR deliberately avoids. Pushed in 7c6fb2c.

✅ #2 — useInitial(report?.lastReadTime) in usePaginatedReportActions (applied)

This was a real cold-login bug. The old useRef(report?.lastReadTime) snapshots the value at first render — on a cold open report is still undefined then, so the ref latched undefined and never recovered, meaning oldestUnreadReportAction never resolved and the pull-back never fired. Switched to useInitial, which captures the first non-undefined (pre-read) lastReadTime, so the anchor resolves after the report loads.

✅ #3 — add oldestUnreadReportAction?.created to the focus-return effect deps (applied)

Done at ReportActionsView.tsx:157. On native the component stays mounted, so the native focus-return effect now also re-fires when the anchor resolves after returning to the chat, pulling the boundary back. Safe because startSession only ever moves the boundary earlier. (As a bonus, with the dep added the prior eslint-disable react-hooks/exhaustive-deps directive became unused, so it was removed.)

❌ #1 — fallback to report.lastReadTime when unread but anchor undefined (declined)

This reintroduces the exact hazard the PR was built to avoid. readNewestAction bumps the live report.lastReadTime to ~now on open, so by the time the report is open the fallback value is now — no better than the default. The PR chose oldestUnreadReportAction.created precisely because it's immune to that bump. With #2 fixed, the anchor now resolves reliably and the "still undefined" window closes on its own, so the fallback adds risk without value.

❌ #4 — capture open-time unread state before readNewestAction runs (no separate change needed)

This is already how the architecture works: oldestUnreadReportAction.created is derived from the pre-read lastReadTime snapshot in usePaginatedReportActions, captured at render before openReport/readNewestAction complete. #2 is what hardens that snapshot against the cold-login case, so #4 is covered by the same fix.

Verification: prettier, lint (both files clean), react-compiler-compliance-check (both COMPILED), and tests/ui/ReportActionsViewTest.tsx (16/16 passed). typecheck shows only pre-existing duplicate-identifier errors in src/libs/API/types.ts, unrelated to these changes (confirmed present with my changes stashed).