Fix tax amount input overwriting in-progress edits in new manual expense flow by MelvinBot · Pull Request #94538 · Expensify/App

MelvinBot · 2026-06-25T05:38:54Z

Explanation of Change

The inline tax amount input in the new manual expense flow re-added padding digits (.00) while the user was typing, because a force-sync useEffect in TaxFields.tsx overwrote the field on every keystroke.

The effect's guard compared raw strings: the in-progress text returned by getNumber() (e.g. "5.0") was compared against the re-padded taxAmountInput ("5.00"). Because the strings differ, the guard failed and updateNumber("5.00") overwrote the user's edit. This produced all three reported symptoms:

Deleting a digit from "5.00" → "5.0" got re-padded back to "5.00" (BUG 1/2).
Clearing the field and typing 10 stored 1000, which got re-padded to "10.00" (BUG 3).

The fix changes the guard to compare the numeric value instead of the formatted string. The current input is parsed to its backend amount (treating an empty field as 0) and compared against the stored taxAmount. An in-progress edit like "5.0" (≡ "5.00" ≡ backend 500) is now recognized as already in-sync and is left untouched. The field is only refreshed via updateNumber when the stored tax amount genuinely differs — e.g. when the tax rate is changed and the amount is recalculated externally.

Note: PR #94134 (which removed the isNewManualExpenseFlowEnabled beta) was reverted in #94312, so this input is currently behind the beta again. This change fixes the underlying bug so the new manual expense flow behaves correctly when the beta is re-enabled.

Fixed Issues

$ #94264
PROPOSAL: #94264 (comment)

Tests

Requires the new manual expense flow + Taxes enabled on the workspace.

Enable Taxes in workspace settings.
Go to a workspace chat → + → Create expense → Manual.
Enter an amount, tap Tax and set it to a 5% rate.
Focus the Tax amount field and press backspace once.
- Verify the removed digit is not replaced with 0 (BUG 1).
Press backspace again.
- Verify the last two digits are not replaced with 00 (BUG 2).
Clear the field and type 10.
- Verify .00 is not auto-appended (BUG 3).
Change the tax rate to a different percentage.
- Verify the tax amount field correctly refreshes to the newly calculated amount.

Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

Requires the new manual expense flow + Taxes enabled on the workspace.

Enable Taxes in workspace settings.
Go to a workspace chat → + → Create expense → Manual.
Enter an amount, tap Tax and set it to a 5% rate.
Focus the Tax amount field and press backspace once.
- Verify the removed digit is not replaced with 0 (BUG 1).
Press backspace again.
- Verify the last two digits are not replaced with 00 (BUG 2).
Clear the field and type 10.
- Verify .00 is not auto-appended (BUG 3).
Change the tax rate to a different percentage.
- Verify the tax amount field correctly refreshes to the newly calculated amount.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…nse flow Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>

thelullabyy · 2026-06-26T04:36:49Z

@MelvinBot You are using the wrong PR description template. Please use this one

https://raw.githubusercontent.com/Expensify/App/main/.github/PULL_REQUEST_TEMPLATE.md

After that replace all [ ] by [x]

Finally, open PR for review

thelullabyy · 2026-06-26T04:37:53Z

@codex review

melvin-bot · 2026-06-26T04:39:17Z

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-06-26T04:39:39Z

🤖 Done, thelullabyy:

Rebuilt the PR description from the current PULL_REQUEST_TEMPLATE.md, preserving the Explanation of Change, Fixed Issues, and test steps.
Replaced all [ ] with [x].
Marked the PR as Ready for review.

github-actions · 2026-06-26T04:42:44Z

+        // tax rate changed and the amount was recalculated externally).
+        const currentInput = numberFormRef.current?.getNumber();
+        if (currentInput !== undefined) {
+            const currentBackendAmount = currentInput.trim() === '' ? 0 : convertToBackendAmount(Number.parseFloat(currentInput));


❌ CONSISTENCY-3 (docs)

This expression currentInput.trim() === '' ? 0 : convertToBackendAmount(Number.parseFloat(currentInput)) duplicates the exact string-to-backend-amount conversion already used in handleTaxAmountChange (newAmount.trim() === '' ? 0 : convertToBackendAmount(Number.parseFloat(newAmount))). Both apply the same empty-string-to-zero guard before converting. Consolidating keeps the parsing rules in one place so the two sites can't drift apart.

Extract a small local helper and call it in both spots:

const toBackendTaxAmount = (input: string) => (input.trim() === '' ? 0 : convertToBackendAmount(Number.parseFloat(input))); // in handleTaxAmountChange const taxAmountInSmallestCurrencyUnits = toBackendTaxAmount(newAmount); // in the effect const currentBackendAmount = toBackendTaxAmount(currentInput);

Reviewed at: e29f18f | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

Good catch — addressed in 9750f66. Extracted a local toBackendTaxAmount helper and used it in both handleTaxAmountChange and the sync effect so the empty-string-to-zero guard and conversion live in one place.

thelullabyy · 2026-06-26T04:44:47Z

@MelvinBot Please check this comment #94538 (comment)

thelullabyy · 2026-06-26T04:45:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-06-26.at.00.38.26.mov

Screen.Recording.2026-06-26.at.00.59.02.mov

Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>

melvin-bot · 2026-06-26T04:50:59Z

@puneetlath Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-06-26T04:55:03Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...oneyRequestConfirmationList/sections/TaxFields.tsx	`81.48% <87.50%> (+0.23%)`	⬆️
... and 197 files with indirect coverage changes

trjExpensify

Another one bites the dust! 👍

OSBotify · 2026-06-26T13:49:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-26T13:53:03Z

🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-26T13:58:33Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94538.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-7f3e84e1704-27a47d6-b587fbf32fd2c1e5accd93cce4b8ea02847f718c/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7f3e84e-27a47d6-5ceb06dcbc5cc7695b2d44f3858b463d28fff29c/index.html

Web 🕸️
https://94538.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-26T20:01:13Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.4.21-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix tax amount input overwriting in-progress edits in new manual expe…

e29f18f

…nse flow Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>

MelvinBot assigned thelullabyy Jun 25, 2026

MelvinBot requested a review from a team June 25, 2026 05:38

MelvinBot mentioned this pull request Jun 25, 2026

[$250] [Due for payment 2026-07-01] [Due for payment 2026-06-30] Expense - When non-zero decimal amount in tax is removed, it is replaced with 0 #94264

Open

7 tasks

MelvinBot marked this pull request as ready for review June 26, 2026 04:39

MelvinBot requested a review from a team as a code owner June 26, 2026 04:39

melvin-bot Bot requested review from thelullabyy and removed request for a team June 26, 2026 04:39

melvin-bot Bot requested review from trjExpensify and removed request for a team June 26, 2026 04:39

github-actions Bot reviewed Jun 26, 2026

View reviewed changes

Extract toBackendTaxAmount helper to dedupe tax amount parsing

9750f66

Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>

MelvinBot requested a review from a team as a code owner June 26, 2026 04:50

melvin-bot Bot requested review from puneetlath and removed request for a team June 26, 2026 04:50

thelullabyy approved these changes Jun 26, 2026

View reviewed changes

thelullabyy mentioned this pull request Jun 26, 2026

[Due for payment 2026-07-02] [Due for payment 2026-06-30] [CFI] Show Merchant, Date, Amount Fields in the Scan flow #93854

Open

7 tasks

trjExpensify approved these changes Jun 26, 2026

View reviewed changes

puneetlath approved these changes Jun 26, 2026

View reviewed changes

puneetlath merged commit 7f3e84e into main Jun 26, 2026
40 checks passed

puneetlath deleted the claude-fixTaxAmountInputForceSync branch June 26, 2026 13:41

OSBotify mentioned this pull request Jun 26, 2026

Deploy Checklist: New Expensify 2026-06-26 #94730

Open

47 tasks

Uh oh!

Conversation

MelvinBot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

thelullabyy commented Jun 26, 2026

Uh oh!

thelullabyy commented Jun 26, 2026

Uh oh!

melvin-bot Bot commented Jun 26, 2026

Uh oh!

MelvinBot commented Jun 26, 2026

Uh oh!

github-actions Bot Jun 26, 2026

Choose a reason for hiding this comment

❌ CONSISTENCY-3 (docs)

Uh oh!

MelvinBot Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

thelullabyy commented Jun 26, 2026

Uh oh!

thelullabyy commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 26, 2026

Uh oh!

codecov Bot commented Jun 26, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

OSBotify commented Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MelvinBot commented Jun 25, 2026 •

edited

Loading

thelullabyy commented Jun 26, 2026 •

edited

Loading

codecov Bot commented Jun 26, 2026 •

edited by github-actions Bot

Loading