[CP staging] Revert "feat: remove isNewManualExpenseFlowEnabled beta flag"#94312
Conversation
|
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Merged since it's a pure revert. |
|
🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
[CP staging] Revert "feat: remove isNewManualExpenseFlowEnabled beta flag" (cherry picked from commit 9ad1a25) (cherry-picked to staging by puneetlath)
|
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.4.17-1 🚀
Bundle Size Analysis (Sentry): |
1 similar comment
|
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.4.17-1 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review: no docs changes required I reviewed the changes in this PR against the help articles in This PR is a revert of #94134 ("feat: remove isNewManualExpenseFlowEnabled beta flag") to fix deploy blockers. It restores the The changes are entirely internal:
There is no change to documented, user-facing behavior — no new or renamed features, settings, tabs, or buttons that appear in the help site. The expense-creation flow described in the help articles is unaffected from the end user's perspective. As such, I did not create a draft help site PR. If you believe a specific help article is affected by the underlying flow change, let me know which one and I'll take another look. @puneetlath, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.4.18-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 No help site changes required. This PR is a revert of #94134 that restores the Because the behavior is beta-gated and not a generally-available, user-facing feature change, there is nothing in If the new manual expense flow later graduates out of beta and changes the documented expense-creation steps, that would be the point to update the relevant @puneetlath, since no docs changes are required I did not open a help site PR. If you believe a help article does need updating here, let me know and I'll create the draft PR. |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.18-2 🚀
|
Explanation of Change
Revert of #94134 to fix deploy blockers.
Fixed Issues
$ #94289
$ #94282
$ #94274
$ #94273
$ #94271
$ #94266
$ #94262
$ #94263
$ #94264
$ #94261
$ #94260
$ #94259
$ #94258
$ #94255
$ #94246
$ #94234
$ #94244
$ #94233
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist