Skip to content

[CP staging] Revert "feat: remove isNewManualExpenseFlowEnabled beta flag"#94312

Merged
puneetlath merged 1 commit into
mainfrom
revert-94134-fix/93854
Jun 23, 2026
Merged

[CP staging] Revert "feat: remove isNewManualExpenseFlowEnabled beta flag"#94312
puneetlath merged 1 commit into
mainfrom
revert-94134-fix/93854

Conversation

@puneetlath

@puneetlath puneetlath commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Revert of #94134 to fix deploy blockers.

Fixed Issues

$ #94289
$ #94282
$ #94274
$ #94273
$ #94271
$ #94266
$ #94262
$ #94263
$ #94264
$ #94261
$ #94260
$ #94259
$ #94258
$ #94255
$ #94246
$ #94234
$ #94244
$ #94233

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

@puneetlath puneetlath marked this pull request as ready for review June 23, 2026 13:31
@puneetlath puneetlath requested review from a team as code owners June 23, 2026 13:31
@melvin-bot melvin-bot Bot requested review from thesahindia and trjExpensify and removed request for a team June 23, 2026 13:31
@melvin-bot

melvin-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@puneetlath puneetlath changed the title Revert "feat: remove isNewManualExpenseFlowEnabled beta flag" [CP staging] Revert "feat: remove isNewManualExpenseFlowEnabled beta flag" Jun 23, 2026
@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 93.84% <ø> (ø)
...onents/MoneyRequestConfirmationFields/Provider.tsx 100.00% <100.00%> (ø)
...mponents/MoneyRequestConfirmationFields/context.ts 80.00% <ø> (ø)
...onfirmationList/hooks/useConfirmationValidation.ts 81.94% <100.00%> (ø)
...eyRequestConfirmationList/sections/AmountField.tsx 43.96% <100.00%> (+0.98%) ⬆️
...oneyRequestConfirmationList/sections/DateField.tsx 77.77% <100.00%> (+20.00%) ⬆️
...uestConfirmationList/sections/DescriptionField.tsx 76.00% <100.00%> (+8.00%) ⬆️
...RequestConfirmationList/sections/MerchantField.tsx 71.73% <100.00%> (+21.73%) ⬆️
...oneyRequestConfirmationList/sections/TaxFields.tsx 81.25% <100.00%> (ø)
.../components/MoneyRequestConfirmationListFooter.tsx 100.00% <100.00%> (ø)
... and 11 more
... and 244 files with indirect coverage changes

@puneetlath puneetlath merged commit 9ad1a25 into main Jun 23, 2026
44 checks passed
@puneetlath puneetlath deleted the revert-94134-fix/93854 branch June 23, 2026 13:45
@puneetlath

Copy link
Copy Markdown
Contributor Author

Merged since it's a pure revert.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Jun 23, 2026
[CP staging] Revert "feat: remove isNewManualExpenseFlowEnabled beta flag"

(cherry picked from commit 9ad1a25)

(cherry-picked to staging by puneetlath)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jun 23, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.4.17-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Bundle Size Analysis (Sentry):

1 similar comment
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.4.17-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help site review: no docs changes required

I reviewed the changes in this PR against the help articles in App/docs/articles.

This PR is a revert of #94134 ("feat: remove isNewManualExpenseFlowEnabled beta flag") to fix deploy blockers. It restores the isNewManualExpenseFlowEnabled beta flag and the associated gating around the money request / manual expense confirmation flow.

The changes are entirely internal:

  • A beta flag (isNewManualExpenseFlowEnabled) and its conditional code paths.
  • Refactoring of confirmation-list components, hooks, and unit tests (MoneyRequestConfirmationList, IOURequestStep*, etc.).

There is no change to documented, user-facing behavior — no new or renamed features, settings, tabs, or buttons that appear in the help site. The expense-creation flow described in the help articles is unaffected from the end user's perspective. As such, I did not create a draft help site PR.

If you believe a specific help article is affected by the underlying flow change, let me know which one and I'll take another look.

@puneetlath, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review — n/a here, since no help site PR was created (no docs changes were required).

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

This was referenced Jun 23, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.4.18-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes required.

This PR is a revert of #94134 that restores the NEW_MANUAL_EXPENSE_FLOW beta flag (isNewManualExpenseFlowEnabled). The change re-gates the new manual expense creation flow behind a beta and toggles internal UI/navigation plumbing (MoneyRequestConfirmationList, confirmation field sections, participant picker routing, etc.) accordingly.

Because the behavior is beta-gated and not a generally-available, user-facing feature change, there is nothing in App/docs/articles that documents it as released behavior. I reviewed the changed files and searched the help articles — the existing "create expense" content describes GA behavior that this revert does not alter. No draft docs PR was created.

If the new manual expense flow later graduates out of beta and changes the documented expense-creation steps, that would be the point to update the relevant reports-and-expenses help articles.

@puneetlath, since no docs changes are required I did not open a help site PR. If you believe a help article does need updating here, let me know and I'll create the draft PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.18-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants