Fix: allow multi-line description in new manual expense flow by MelvinBot · Pull Request #94540 · Expensify/App

MelvinBot · 2026-06-25T05:41:13Z

Explanation of Change

On the new manual expense flow, the inline description input in the confirmation list was a multi-line (autoGrowHeight) TextInput that hardcoded submitBehavior="blurAndSubmit" (paired with onSubmitEditing={onSubmitForm}). On Android native, blurAndSubmit overrides React Native's default multi-line submitBehavior of "newline", so the Enter key blurs/submits the form (the keyboard shows Done) instead of inserting a line break — making it impossible to type a multi-line description.

This was only reproducible in staging (not production) because the inline input is gated behind the isNewManualExpenseFlowEnabled beta. The offending PR that removed the beta gate (#94134) was already reverted (#94312), so the bug is hidden in production again — but the underlying input bug remains and would resurface when the new flow is re-enabled.

This change removes submitBehavior="blurAndSubmit" / onSubmitEditing from the multi-line description input so it falls back to RN's default "newline" behavior, allowing Enter to insert a line break — matching the dedicated IOURequestStepDescription step page (used in the old/production path), which sets no submitBehavior.

Since the description field was the only consumer of the onSubmitForm callback, the now-dead onSubmitForm prop chain (MoneyRequestConfirmationList → MoneyRequestConfirmationListFooter → ConfirmationFieldList → TransactionDetailsFields → DescriptionField) is removed as well.

Fixed Issues

$ #94258
PROPOSAL: #94258 (comment)

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

Enable the new manual expense flow beta.
Open a workspace chat → FAB → Create expense → Manual.
Enter an amount and merchant, proceed to the confirmation screen.
Tap the Description field and type text, pressing Enter to start new lines.
Verify the keyboard shows Enter (not Done) and that multi-line descriptions can be created.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

Enable the new manual expense flow beta.
Open a workspace chat → FAB → Create expense → Manual.
Enter an amount and merchant, proceed to the confirmation screen.
Tap the Description field and type a multi-line description, pressing Enter between lines.
Verify the Enter key inserts a new line (keyboard shows Enter, not Done) and the multi-line description is saved correctly.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>

MelvinBot · 2026-06-25T05:47:13Z

I looked into the failing checks — there's nothing in the code to fix.

The only check reporting a failure is PR Author Checklist / checklist, and it's failing for the expected reason: "You completed 0 out of 41 checklist items." That check just verifies the author has ticked every box in the PR description — it isn't a CI/code failure and there's no code change that can resolve it. As the human co-author, thelullabyy needs to fill out the Tests/QA sections and check the author-checklist boxes before marking the PR ready for review.

Every actual code check is green: typecheck, all 8 test jobs, ESLint, Prettier, Bun tests, Storybook tests, React Compiler Compliance, knip, and the builds. The baseline-perf-tests / branch-perf-tests (Reassure) are still running — they're informational and non-blocking, and this change (removing a now-dead onSubmitForm prop chain) doesn't affect runtime performance.

So: no fix needed from me — just complete the author checklist.

thelullabyy · 2026-06-26T06:04:09Z

@MelvinBot Please resolve conflicts. After that replace all [ ] characters in PR description by [x]. Finally, open this PR for review

…scriptionManualExpense Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com> # Conflicts: # src/components/MoneyRequestConfirmationList.tsx # src/components/MoneyRequestConfirmationList/sections/DescriptionField.tsx # src/components/MoneyRequestConfirmationListFooter.tsx

melvin-bot · 2026-06-26T06:16:56Z

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-06-26T06:17:26Z

🤖 Done — all three requests handled:

Resolved merge conflicts by merging the latest main into the branch. Conflicts were in 3 files: MoneyRequestConfirmationList.tsx, MoneyRequestConfirmationListFooter.tsx, and MoneyRequestConfirmationList/sections/DescriptionField.tsx. In each, I kept main's newly-added scrollFocusedInputIntoView / onFocus keyboard-scroll logic while applying this PR's removal of the dead onSubmitForm chain and the submitBehavior="blurAndSubmit" / onSubmitEditing props. npm run typecheck-tsgo passes and no onSubmitForm references remain in src/.
Updated the PR description — replaced every [ ] with [x].
Marked the PR ready for review.

The PR is now mergeable (no conflicts).

MelvinBot · 2026-06-26T06:20:26Z

🤖 I looked into the failing checks — there's nothing to fix.

When the request came in, the only failing check was PR Author Checklist (checklist), which is a human-only check that verifies the checklist boxes in the PR body are ticked. Everything else was still in progress. I let the run finish:

31 checks pass (including typecheck, ESLint, Prettier, all 8 test jobs, all builds, Storybook tests, and the review check).
The PR Author Checklist check now passes on its re-run.
The only checks still running are baseline-perf-tests / branch-perf-tests, which are long-running and informational — not blocking.

So no code fix is needed. The PR Author Checklist is the one item I can't act on for you: please make sure every box in the PR description's author checklist is ticked.

thelullabyy · 2026-06-27T05:03:29Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f041f3c15e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-27T05:08:37Z

@@ -112,8 +110,6 @@ function DescriptionField({
                                    readOnly={didConfirm}
                                    onChangeText={handleDescriptionInputChange}
                                    onFocus={() => scrollFocusedInputIntoView?.(fieldContainerRef.current)}


Preserve desktop submit behavior for descriptions

When this inline field is used in the new manual expense flow on desktop/no-touch devices, dropping the submit props removes the only path that calls confirm from the focused description input. The existing form wrapper explicitly keeps blurAndSubmit for multiline text on hardware-keyboard setups (src/components/Form/InputWrapper.tsx:34-50) because Shift+Enter can still add a newline, so the Android/touch fix should be gated instead of removing Enter-to-confirm globally.

Useful? React with 👍 / 👎.

Good catch — this is valid. I confirmed the dedicated description step page (IOURequestStepDescription.tsx:202-215) renders through InputWrapper, which injects blurAndSubmit for multiline inputs only on hardware-keyboard setups (InputWrapper.tsx:34-50). So fully dropping the props made the inline field diverge from the step page on desktop, losing Enter-to-confirm there.

Fixed in 8b365fd by gating instead of removing, mirroring InputWrapper's logic (DescriptionField.tsx:120-121):

Touch devices: submitBehavior="newline", no onSubmitEditing → Enter inserts a line break (fixes the original Android bug, since the soft keyboard has no other way to add one).

Hardware keyboard (!canUseTouchScreen()): submitBehavior="blurAndSubmit" + onSubmitEditing={onSubmitForm} → Enter confirms, Shift+Enter adds a newline — matching the step page.

Rather than re-thread the removed onSubmitForm prop chain, I deliver confirm through the existing ConfirmationFields context (the same mechanism the PR already uses for scrollFocusedInputIntoView), so it reaches the field without passing through the intermediate components.

Typecheck and React Compiler compliance pass.

thelullabyy · 2026-06-27T05:13:02Z

@MelvinBot please check this comment and update code if needed

thelullabyy · 2026-06-27T05:18:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-06-27.at.01.30.04.mov

Android: mWeb Chrome

Screen.Recording.2026-06-27.at.01.28.03.mov

iOS: HybridApp

Screen.Recording.2026-06-27.at.01.11.33.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-06-27.at.01.18.04.mov

Keep Enter-to-confirm for the inline description on desktop/no-touch (Shift+Enter still adds a newline there), while keeping Enter as newline on touch devices so multi-line descriptions remain typable. Delivers the confirm callback via ConfirmationFields context instead of re-threading the prop chain. Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>

melvin-bot · 2026-06-27T05:23:23Z

@puneetlath Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Fix: allow multi-line description in new manual expense flow

6208d2a

Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>

MelvinBot assigned thelullabyy Jun 25, 2026

MelvinBot requested a review from a team June 25, 2026 05:41

MelvinBot mentioned this pull request Jun 25, 2026

[$250] [Due for payment 2026-07-01] [Due for payment 2026-06-30] Android - Expense - Unable to enter multi-line description #94258

Open

7 tasks

MelvinBot marked this pull request as ready for review June 26, 2026 06:16

MelvinBot requested a review from a team as a code owner June 26, 2026 06:16

melvin-bot Bot requested review from thelullabyy and removed request for a team June 26, 2026 06:16

melvin-bot Bot requested review from heyjennahay and removed request for a team June 26, 2026 06:16

chatgpt-codex-connector Bot reviewed Jun 27, 2026

View reviewed changes

MelvinBot requested a review from a team as a code owner June 27, 2026 05:23

melvin-bot Bot requested a review from puneetlath June 27, 2026 05:23

melvin-bot Bot removed the request for review from a team June 27, 2026 05:23

thelullabyy approved these changes Jun 27, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: allow multi-line description in new manual expense flow#94540

Fix: allow multi-line description in new manual expense flow#94540
MelvinBot wants to merge 3 commits into
mainfrom
claude-fixMultiLineDescriptionManualExpense

MelvinBot commented Jun 25, 2026 •

edited

Loading

Uh oh!

MelvinBot commented Jun 25, 2026

Uh oh!

thelullabyy commented Jun 26, 2026

Uh oh!

melvin-bot Bot commented Jun 26, 2026

Uh oh!

MelvinBot commented Jun 26, 2026

Uh oh!

MelvinBot commented Jun 26, 2026

Uh oh!

thelullabyy commented Jun 27, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jun 27, 2026

Uh oh!

MelvinBot Jun 27, 2026

Uh oh!

thelullabyy commented Jun 27, 2026

Uh oh!

thelullabyy commented Jun 27, 2026 •

edited

Loading

Uh oh!

melvin-bot Bot commented Jun 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

MelvinBot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Jun 25, 2026

Uh oh!

thelullabyy commented Jun 26, 2026

Uh oh!

melvin-bot Bot commented Jun 26, 2026

Uh oh!

MelvinBot commented Jun 26, 2026

Uh oh!

MelvinBot commented Jun 26, 2026

Uh oh!

thelullabyy commented Jun 27, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

thelullabyy commented Jun 27, 2026

Uh oh!

thelullabyy commented Jun 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MelvinBot commented Jun 25, 2026 •

edited

Loading

thelullabyy commented Jun 27, 2026 •

edited

Loading