Skip to content

Get the notification preference for all report types#9512

Merged
robertjchen merged 1 commit into
mainfrom
tgolen-fix-notification-pref
Jun 24, 2022
Merged

Get the notification preference for all report types#9512
robertjchen merged 1 commit into
mainfrom
tgolen-fix-notification-pref

Conversation

@tgolen

@tgolen tgolen commented Jun 21, 2022

Copy link
Copy Markdown
Contributor

Fixed Issues

$ #9511

Tests

  1. Be on the policyExpenseChat beta
  2. Open a policy expense chat
  3. Go to the report settings by clicking the report header
  4. Change the notification preference to something that isn't immediate
  5. Go to a different chat
  6. Refresh the page
  7. Go back to the policy expense chat
  8. Go to the chat settings
  9. Verify that the notification preference is what you set it to above
  • Verify that no errors appear in the JS console

QA Steps

Same as above. Not sure if you have access to that beta though? If not, please reach out and ask for access.

  • Verify that no errors appear in the JS console

Screenshots

I'm only including a video for web since this is all backend changes, there is no chance for a platform-specific regression

Web

2022-06-21_09-55-23.mp4

@tgolen tgolen requested a review from a team June 21, 2022 15:57
@tgolen tgolen requested a review from marcaaron as a code owner June 21, 2022 15:57
@tgolen tgolen self-assigned this Jun 21, 2022
@melvin-bot melvin-bot Bot requested review from robertjchen and removed request for a team June 21, 2022 15:57
@marcaaron marcaaron removed their request for review June 21, 2022 17:32

@robertjchen robertjchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgolen tgolen changed the title [HOLD Web-E PR#34064] Get the notification preference for all report types Get the notification preference for all report types Jun 23, 2022
@tgolen

tgolen commented Jun 23, 2022

Copy link
Copy Markdown
Contributor Author

Off hold now that the other PR is in production.

@robertjchen robertjchen merged commit 342f6b4 into main Jun 24, 2022
@robertjchen robertjchen deleted the tgolen-fix-notification-pref branch June 24, 2022 17:14
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @robertjchen in version: 1.1.79-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@mvtglobally

Copy link
Copy Markdown

@tgolen Can you pls confirm if all Expensifail accounts by default are on policyExpenseChatpolicyExpenseChat beta or we need to do anything to enable it?

@sketchydroide

Copy link
Copy Markdown
Contributor

just CCing so I can keep track for deplyment purposes

@sketchydroide

Copy link
Copy Markdown
Contributor

not sure policyExpenseChatpolicyExpenseChat exists or it was a double paste, policyExpenseChat exists though
and expensifail accounts are not added to it @mvtglobally

@sketchydroide

Copy link
Copy Markdown
Contributor

added the applause users to policyExpenseChat

@tgolen

tgolen commented Jul 4, 2022

Copy link
Copy Markdown
Contributor Author

Yeah, sorry... that was a typo. The beta was policyExpenseChat

@OSBotify

OSBotify commented Jul 8, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.79-17 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants