Revert to version 1.6.13 to fix actionlint regression#9574
Merged
Conversation
roryabraham
reviewed
Jun 27, 2022
| fi | ||
|
|
||
| bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash) | ||
| curl -s curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash | bash -s -- 1.6.13 |
Contributor
There was a problem hiding this comment.
This line broke my brain 😆 curl -s curl https:// ... ... is this right or should it just be curl -s https://... ?
Contributor
Author
There was a problem hiding this comment.
I have no idea how it works, but copied from here rhysd/actionlint#162 (comment), confirmed it worked as expected, and just using curl once will result in downloading it twice 🤔
roryabraham
approved these changes
Jun 27, 2022
Contributor
Author
|
I think Neil is OOO so going to merge! |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
71 tasks
Contributor
|
🚀 Deployed to staging by @AndrewGable in version: 1.1.79-0 🚀
|
Contributor
|
🚀 Deployed to production by @roryabraham in version: 1.1.79-17 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Adds an explicit version to
actionlintas we've discovered a regression in the latest version. We can revert this change when the regression is fixed.Fixed Issues
$ #9572
Tests
PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issuessection aboveTestssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*filesSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */displayNamepropertythisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)QA Steps
N/A - Just GitHub action changes
Screenshots
Web
N/A - Just GitHub action changes
Mobile Web
N/A - Just GitHub action changes
Desktop
N/A - Just GitHub action changes
iOS
N/A - Just GitHub action changes
Android
N/A - Just GitHub action changes