[No QA] Change createNewVersion back to dispatchable workflow#9873
[No QA] Change createNewVersion back to dispatchable workflow#9873roryabraham wants to merge 9 commits into
Conversation
melvin-bot
Bot
requested review from
sketchydroide
and removed request for
a team
Do we need to apply the label |
Checklist is currently unlocked, so no need for the CP Staging label |
| - name: Checkout main branch | ||
| uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f | ||
| with: | ||
| ref: main |
There was a problem hiding this comment.
we no longer need token: ${{ secrets.OS_BOTIFY_TOKEN }} for this step?
There was a problem hiding this comment.
Nope. Never did 🙂
| uses: Expensify/App/.github/actions/javascript/triggerWorkflowAndWait@main | ||
| with: | ||
| GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }} | ||
| WORKFLOW: createNewVersion.yml |
There was a problem hiding this comment.
I see that SEMVER_LEVEL is still an input of createNewVersion.yml. To clarify, it's fine not to pass it because it's required: false, right?
There was a problem hiding this comment.
Yep! Making that parameter optional is one of the changes I've decided to optimistically keep from the other PR
francoisl
left a comment
francoisl
left a comment
There was a problem hiding this comment.
LGTM but I'm not an expert at GH actions, I'll defer to @AndrewGable and @sketchydroide for the merge in case I missed something.
|
Going to let @roryabraham merge |
|
Not going to merge, because I think I know what's wrong |
|
Follow-up: #9879 |
|
We'll see if that works, and if it does then I'll close this. |
4 participants
Details
This is a partial revert of #9812, which didn't work due to a GitHub Actions bug, which can be tracked in a few places:
I've optimistically curated the revert to include some best practices updates, reduce the diff, and see if this bug we're seeing is related to the use of a callable action, as I suspect. This should hopefully make it easier to un-revert once the bug is fixed.
Fixed Issues
$ n/a – broken deploys
Tests